All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Philippe Brucker <jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
To: Shaokun Zhang
	<zhangshaokun-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: Miao Zhong <zhongmiao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH] iommu/arm-smmu-v3: sync the OVACKFLG to PRIQ consumer register
Date: Mon, 23 Jul 2018 15:08:18 +0100	[thread overview]
Message-ID: <07622bf1-161e-3cd2-eda5-334601d077d8@arm.com> (raw)
In-Reply-To: <1532350618-16486-1-git-send-email-zhangshaokun-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>

On 23/07/18 13:56, Shaokun Zhang wrote:
> From: Miao Zhong <zhongmiao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
> 
> When PRI queue occurs overflow, driver should update the OVACKFLG to
> the PRIQ consumer register, otherwise subsequent PRI requests will not
> be processed.

Since the upstream driver doesn't enable PRI in endpoints, I'm not sure
this patch makes sense on its own, but it seems correct anyway. I had a
similar patch in my initial SVA RFC, but for some reason dropped it in
later versions (https://patchwork.kernel.org/patch/9594021/)

It's worth noting that the event queue doesn't have the same problem,
because the SMMU can record new events even if the overflow hasn't been
acknowledged.

Thanks,
Jean

WARNING: multiple messages have this Message-ID (diff)
From: jean-philippe.brucker@arm.com (Jean-Philippe Brucker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu/arm-smmu-v3: sync the OVACKFLG to PRIQ consumer register
Date: Mon, 23 Jul 2018 15:08:18 +0100	[thread overview]
Message-ID: <07622bf1-161e-3cd2-eda5-334601d077d8@arm.com> (raw)
In-Reply-To: <1532350618-16486-1-git-send-email-zhangshaokun@hisilicon.com>

On 23/07/18 13:56, Shaokun Zhang wrote:
> From: Miao Zhong <zhongmiao@hisilicon.com>
> 
> When PRI queue occurs overflow, driver should update the OVACKFLG to
> the PRIQ consumer register, otherwise subsequent PRI requests will not
> be processed.

Since the upstream driver doesn't enable PRI in endpoints, I'm not sure
this patch makes sense on its own, but it seems correct anyway. I had a
similar patch in my initial SVA RFC, but for some reason dropped it in
later versions (https://patchwork.kernel.org/patch/9594021/)

It's worth noting that the event queue doesn't have the same problem,
because the SMMU can record new events even if the overflow hasn't been
acknowledged.

Thanks,
Jean

  parent reply	other threads:[~2018-07-23 14:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23 12:56 [PATCH] iommu/arm-smmu-v3: sync the OVACKFLG to PRIQ consumer register Shaokun Zhang
2018-07-23 12:56 ` Shaokun Zhang
     [not found] ` <1532350618-16486-1-git-send-email-zhangshaokun-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2018-07-23 14:08   ` Jean-Philippe Brucker [this message]
2018-07-23 14:08     ` Jean-Philippe Brucker
2018-07-27  9:41   ` Zhangshaokun
2018-07-27  9:41     ` Zhangshaokun
     [not found]     ` <dfeaf347-afd4-b3f2-eb01-2781028371e8-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2018-07-27  9:48       ` Will Deacon
2018-07-27  9:48         ` Will Deacon
     [not found]         ` <20180727094816.GM28088-5wv7dgnIgG8@public.gmane.org>
2018-07-27  9:59           ` Zhangshaokun
2018-07-27  9:59             ` Zhangshaokun
2018-07-23 14:43 Zhongmiao
     [not found] ` <8CD08B4737CACA4ABE0228F45E441A916382021E-0LhPdUyVHB9UuCJht5byYAK1hpo4iccwjNknBlVQO8k@public.gmane.org>
2018-07-23 15:14   ` Jean-Philippe Brucker
2018-07-23 15:14     ` Jean-Philippe Brucker
2018-07-24  2:04 Zhongmiao
2018-07-24  4:44 Zhongmiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07622bf1-161e-3cd2-eda5-334601d077d8@arm.com \
    --to=jean-philippe.brucker-5wv7dgnigg8@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    --cc=zhangshaokun-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
    --cc=zhongmiao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.