* [PATCH resend] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830
@ 2022-06-23 11:27 Hans de Goede
2022-06-23 11:46 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2022-06-23 11:27 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann
Cc: Hans de Goede, Javier Martinez Canillas, dri-devel
The Lenovo Yoga Tablet 2 830F / 830L use a panel which has been mounted
90 degrees rotated. Add a quirk for this.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 4e853acfd1e8..cc8556ac673b 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -280,6 +280,21 @@ static const struct dmi_system_id orientation_data[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"),
},
.driver_data = (void *)&lcd1200x1920_rightside_up,
+ }, { /* Lenovo Yoga Tablet 2 830F / 830L */
+ .matches = {
+ /*
+ * Note this also matches the Lenovo Yoga Tablet 2 1050F/L
+ * since that uses the same mainboard. The resolution match
+ * will limit this to only matching on the 830F/L. Neither has
+ * any external video outputs so those are not a concern.
+ */
+ DMI_MATCH(DMI_SYS_VENDOR, "Intel Corp."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "VALLEYVIEW C0 PLATFORM"),
+ DMI_MATCH(DMI_BOARD_NAME, "BYT-T FFD8"),
+ /* Partial match on beginning of BIOS version */
+ DMI_MATCH(DMI_BIOS_VERSION, "BLADE_21"),
+ },
+ .driver_data = (void *)&lcd1200x1920_rightside_up,
}, { /* OneGX1 Pro */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "SYSTEM_MANUFACTURER"),
--
2.36.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH resend] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830
2022-06-23 11:27 [PATCH resend] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830 Hans de Goede
@ 2022-06-23 11:46 ` Javier Martinez Canillas
2022-07-01 8:51 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2022-06-23 11:46 UTC (permalink / raw)
To: Hans de Goede, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann
Cc: dri-devel
Hello Hans,
On 6/23/22 13:27, Hans de Goede wrote:
> The Lenovo Yoga Tablet 2 830F / 830L use a panel which has been mounted
> 90 degrees rotated. Add a quirk for this.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
The patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH resend] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830
2022-06-23 11:46 ` Javier Martinez Canillas
@ 2022-07-01 8:51 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2022-07-01 8:51 UTC (permalink / raw)
To: Javier Martinez Canillas, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann
Cc: dri-devel
Hi,
On 6/23/22 13:46, Javier Martinez Canillas wrote:
> Hello Hans,
>
> On 6/23/22 13:27, Hans de Goede wrote:
>> The Lenovo Yoga Tablet 2 830F / 830L use a panel which has been mounted
>> 90 degrees rotated. Add a quirk for this.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>
> The patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thanks. I've pushed this to drm-misc-fixes now.
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-01 8:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-23 11:27 [PATCH resend] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Tablet 2 830 Hans de Goede
2022-06-23 11:46 ` Javier Martinez Canillas
2022-07-01 8:51 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.