* [PATCH v1 1/3] iommu/vt-d: Unify format of the printed messages
@ 2020-05-07 16:18 Andy Shevchenko
2020-05-07 16:18 ` [PATCH v1 2/3] iommu/iova: " Andy Shevchenko
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-05-07 16:18 UTC (permalink / raw)
To: Joerg Roedel, David Woodhouse, Lu Baolu, iommu; +Cc: Andy Shevchenko
Unify format of the printed messages, i.e. replace printk(LEVEL ... )
with pr_level(...).
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iommu/intel-iommu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 0182cff2c7ac7..624831e5a583c 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -480,8 +480,7 @@ static int __init intel_iommu_setup(char *str)
pr_info("Intel-IOMMU: scalable mode supported\n");
intel_iommu_sm = 1;
} else if (!strncmp(str, "tboot_noforce", 13)) {
- printk(KERN_INFO
- "Intel-IOMMU: not forcing on after tboot. This could expose security risk for tboot\n");
+ pr_info("Intel-IOMMU: not forcing on after tboot. This could expose security risk for tboot\n");
intel_iommu_tboot_noforce = 1;
} else if (!strncmp(str, "nobounce", 8)) {
pr_info("Intel-IOMMU: No bounce buffer. This could expose security risks of DMA attacks\n");
--
2.26.2
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v1 2/3] iommu/iova: Unify format of the printed messages
2020-05-07 16:18 [PATCH v1 1/3] iommu/vt-d: Unify format of the printed messages Andy Shevchenko
@ 2020-05-07 16:18 ` Andy Shevchenko
2020-05-07 16:18 ` [PATCH v1 3/3] iommu/amd: " Andy Shevchenko
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-05-07 16:18 UTC (permalink / raw)
To: Joerg Roedel, David Woodhouse, Lu Baolu, iommu; +Cc: Andy Shevchenko
Unify format of the printed messages, i.e. replace printk(LEVEL ... )
with pr_level(...).
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iommu/iova.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c
index 0e6a9536eca62..49fc01f2a28d4 100644
--- a/drivers/iommu/iova.c
+++ b/drivers/iommu/iova.c
@@ -253,7 +253,7 @@ int iova_cache_get(void)
SLAB_HWCACHE_ALIGN, NULL);
if (!iova_cache) {
mutex_unlock(&iova_cache_mutex);
- printk(KERN_ERR "Couldn't create iova cache\n");
+ pr_err("Couldn't create iova cache\n");
return -ENOMEM;
}
}
@@ -718,8 +718,8 @@ copy_reserved_iova(struct iova_domain *from, struct iova_domain *to)
new_iova = reserve_iova(to, iova->pfn_lo, iova->pfn_hi);
if (!new_iova)
- printk(KERN_ERR "Reserve iova range %lx@%lx failed\n",
- iova->pfn_lo, iova->pfn_lo);
+ pr_err("Reserve iova range %lx@%lx failed\n",
+ iova->pfn_lo, iova->pfn_lo);
}
spin_unlock_irqrestore(&from->iova_rbtree_lock, flags);
}
--
2.26.2
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v1 3/3] iommu/amd: Unify format of the printed messages
2020-05-07 16:18 [PATCH v1 1/3] iommu/vt-d: Unify format of the printed messages Andy Shevchenko
2020-05-07 16:18 ` [PATCH v1 2/3] iommu/iova: " Andy Shevchenko
@ 2020-05-07 16:18 ` Andy Shevchenko
2020-05-08 0:20 ` [PATCH v1 1/3] iommu/vt-d: " Lu Baolu
2020-05-13 8:56 ` Joerg Roedel
3 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-05-07 16:18 UTC (permalink / raw)
To: Joerg Roedel, David Woodhouse, Lu Baolu, iommu; +Cc: Andy Shevchenko
Unify format of the printed messages, i.e. replace printk(LEVEL ... )
with pr_level(...).
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iommu/amd_iommu_types.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iommu/amd_iommu_types.h b/drivers/iommu/amd_iommu_types.h
index ca8c4522045b3..cf829ebe37cb5 100644
--- a/drivers/iommu/amd_iommu_types.h
+++ b/drivers/iommu/amd_iommu_types.h
@@ -395,10 +395,10 @@
#define PD_IOMMUV2_MASK (1UL << 3) /* domain has gcr3 table */
extern bool amd_iommu_dump;
-#define DUMP_printk(format, arg...) \
- do { \
- if (amd_iommu_dump) \
- printk(KERN_INFO "AMD-Vi: " format, ## arg); \
+#define DUMP_printk(format, arg...) \
+ do { \
+ if (amd_iommu_dump) \
+ pr_info("AMD-Vi: " format, ## arg); \
} while(0);
/* global flag if IOMMUs cache non-present entries */
--
2.26.2
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/3] iommu/vt-d: Unify format of the printed messages
2020-05-07 16:18 [PATCH v1 1/3] iommu/vt-d: Unify format of the printed messages Andy Shevchenko
2020-05-07 16:18 ` [PATCH v1 2/3] iommu/iova: " Andy Shevchenko
2020-05-07 16:18 ` [PATCH v1 3/3] iommu/amd: " Andy Shevchenko
@ 2020-05-08 0:20 ` Lu Baolu
2020-05-13 8:56 ` Joerg Roedel
3 siblings, 0 replies; 5+ messages in thread
From: Lu Baolu @ 2020-05-08 0:20 UTC (permalink / raw)
To: Andy Shevchenko, Joerg Roedel, David Woodhouse, iommu
On 5/8/20 12:18 AM, Andy Shevchenko wrote:
> Unify format of the printed messages, i.e. replace printk(LEVEL ... )
> with pr_level(...).
Thanks!
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/iommu/intel-iommu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 0182cff2c7ac7..624831e5a583c 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -480,8 +480,7 @@ static int __init intel_iommu_setup(char *str)
> pr_info("Intel-IOMMU: scalable mode supported\n");
> intel_iommu_sm = 1;
> } else if (!strncmp(str, "tboot_noforce", 13)) {
> - printk(KERN_INFO
> - "Intel-IOMMU: not forcing on after tboot. This could expose security risk for tboot\n");
> + pr_info("Intel-IOMMU: not forcing on after tboot. This could expose security risk for tboot\n");
> intel_iommu_tboot_noforce = 1;
> } else if (!strncmp(str, "nobounce", 8)) {
> pr_info("Intel-IOMMU: No bounce buffer. This could expose security risks of DMA attacks\n");
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/3] iommu/vt-d: Unify format of the printed messages
2020-05-07 16:18 [PATCH v1 1/3] iommu/vt-d: Unify format of the printed messages Andy Shevchenko
` (2 preceding siblings ...)
2020-05-08 0:20 ` [PATCH v1 1/3] iommu/vt-d: " Lu Baolu
@ 2020-05-13 8:56 ` Joerg Roedel
3 siblings, 0 replies; 5+ messages in thread
From: Joerg Roedel @ 2020-05-13 8:56 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: iommu, David Woodhouse
On Thu, May 07, 2020 at 07:18:02PM +0300, Andy Shevchenko wrote:
> Unify format of the printed messages, i.e. replace printk(LEVEL ... )
> with pr_level(...).
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/iommu/intel-iommu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied all, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-13 8:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 16:18 [PATCH v1 1/3] iommu/vt-d: Unify format of the printed messages Andy Shevchenko
2020-05-07 16:18 ` [PATCH v1 2/3] iommu/iova: " Andy Shevchenko
2020-05-07 16:18 ` [PATCH v1 3/3] iommu/amd: " Andy Shevchenko
2020-05-08 0:20 ` [PATCH v1 1/3] iommu/vt-d: " Lu Baolu
2020-05-13 8:56 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.