All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Jerry.Hoemann@hpe.com
Cc: erosca@de.adit-jv.com, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [V2 PATCH] selftests: watchdog: Add gettimeout and get|set pretimeout
Date: Wed, 26 Sep 2018 15:04:03 -0600	[thread overview]
Message-ID: <07a8e98e-1e25-d87d-51e5-66ff9dd65245@kernel.org> (raw)
In-Reply-To: <20180926200320.GB14558@anatevka.americas.hpqcorp.net>

On 09/26/2018 02:03 PM, Jerry Hoemann wrote:
> On Wed, Sep 26, 2018 at 01:47:25PM -0600, Shuah Khan wrote:
>> On 09/26/2018 10:29 AM, Jerry Hoemann wrote:
>>> On Tue, Sep 25, 2018 at 02:51:15PM -0600, Shuah Khan wrote:
>>>> Hi Jerry,
>>>>
>>>>
>>>> The rest looks good to me.
>>
>> I spoke too soon. I ran your patch on softdog and error messages in unsupported
>> cases could you refinement. Please see below:
>>
>> Sorry for not catching this earlier.
>>
>>>>
>>>>>  }
>>>>>  
>>>>>  int main(int argc, char *argv[])
>>>>> @@ -135,6 +142,30 @@ int main(int argc, char *argv[])
>>>>>  			else
>>>>>  				printf("WDIOC_SETTIMEOUT errno '%s'\n", strerror(errno));
>>>>>  			break;
>>>>> +		case 'T':
>>>>> +			oneshot = 1;
>>>>> +			ret = ioctl(fd, WDIOC_GETTIMEOUT, &flags);
>>>>> +			if (!ret)
>>>>> +				printf("WDIOC_GETTIMEOUT returns %u seconds.\n", flags);
>>>>> +			else
>>>>> +				printf("WDIOC_GETTIMEOUT errno '%s'\n", strerror(errno));
>>
>> Either remove "errno" or change it to "error '%s'"
> 
> Oh, I see. I did a cut/paste from prior printf in file which have same issue.
> I'll fix those while I'm at it.
> 
> 
> 

Thanks. That will be awesome.

-- Shuah

WARNING: multiple messages have this Message-ID (diff)
From: shuah at kernel.org (Shuah Khan)
Subject: [V2 PATCH] selftests: watchdog: Add gettimeout and get|set pretimeout
Date: Wed, 26 Sep 2018 15:04:03 -0600	[thread overview]
Message-ID: <07a8e98e-1e25-d87d-51e5-66ff9dd65245@kernel.org> (raw)
In-Reply-To: <20180926200320.GB14558@anatevka.americas.hpqcorp.net>

On 09/26/2018 02:03 PM, Jerry Hoemann wrote:
> On Wed, Sep 26, 2018 at 01:47:25PM -0600, Shuah Khan wrote:
>> On 09/26/2018 10:29 AM, Jerry Hoemann wrote:
>>> On Tue, Sep 25, 2018 at 02:51:15PM -0600, Shuah Khan wrote:
>>>> Hi Jerry,
>>>>
>>>>
>>>> The rest looks good to me.
>>
>> I spoke too soon. I ran your patch on softdog and error messages in unsupported
>> cases could you refinement. Please see below:
>>
>> Sorry for not catching this earlier.
>>
>>>>
>>>>>  }
>>>>>  
>>>>>  int main(int argc, char *argv[])
>>>>> @@ -135,6 +142,30 @@ int main(int argc, char *argv[])
>>>>>  			else
>>>>>  				printf("WDIOC_SETTIMEOUT errno '%s'\n", strerror(errno));
>>>>>  			break;
>>>>> +		case 'T':
>>>>> +			oneshot = 1;
>>>>> +			ret = ioctl(fd, WDIOC_GETTIMEOUT, &flags);
>>>>> +			if (!ret)
>>>>> +				printf("WDIOC_GETTIMEOUT returns %u seconds.\n", flags);
>>>>> +			else
>>>>> +				printf("WDIOC_GETTIMEOUT errno '%s'\n", strerror(errno));
>>
>> Either remove "errno" or change it to "error '%s'"
> 
> Oh, I see. I did a cut/paste from prior printf in file which have same issue.
> I'll fix those while I'm at it.
> 
> 
> 

Thanks. That will be awesome.

-- Shuah

WARNING: multiple messages have this Message-ID (diff)
From: shuah@kernel.org (Shuah Khan)
Subject: [V2 PATCH] selftests: watchdog: Add gettimeout and get|set pretimeout
Date: Wed, 26 Sep 2018 15:04:03 -0600	[thread overview]
Message-ID: <07a8e98e-1e25-d87d-51e5-66ff9dd65245@kernel.org> (raw)
Message-ID: <20180926210403.78fkU6J0y141SnnYFqzjEjv8ZOIQJ07OkKWsVbflrUk@z> (raw)
In-Reply-To: <20180926200320.GB14558@anatevka.americas.hpqcorp.net>

On 09/26/2018 02:03 PM, Jerry Hoemann wrote:
> On Wed, Sep 26, 2018@01:47:25PM -0600, Shuah Khan wrote:
>> On 09/26/2018 10:29 AM, Jerry Hoemann wrote:
>>> On Tue, Sep 25, 2018@02:51:15PM -0600, Shuah Khan wrote:
>>>> Hi Jerry,
>>>>
>>>>
>>>> The rest looks good to me.
>>
>> I spoke too soon. I ran your patch on softdog and error messages in unsupported
>> cases could you refinement. Please see below:
>>
>> Sorry for not catching this earlier.
>>
>>>>
>>>>>  }
>>>>>  
>>>>>  int main(int argc, char *argv[])
>>>>> @@ -135,6 +142,30 @@ int main(int argc, char *argv[])
>>>>>  			else
>>>>>  				printf("WDIOC_SETTIMEOUT errno '%s'\n", strerror(errno));
>>>>>  			break;
>>>>> +		case 'T':
>>>>> +			oneshot = 1;
>>>>> +			ret = ioctl(fd, WDIOC_GETTIMEOUT, &flags);
>>>>> +			if (!ret)
>>>>> +				printf("WDIOC_GETTIMEOUT returns %u seconds.\n", flags);
>>>>> +			else
>>>>> +				printf("WDIOC_GETTIMEOUT errno '%s'\n", strerror(errno));
>>
>> Either remove "errno" or change it to "error '%s'"
> 
> Oh, I see. I did a cut/paste from prior printf in file which have same issue.
> I'll fix those while I'm at it.
> 
> 
> 

Thanks. That will be awesome.

-- Shuah

  reply	other threads:[~2018-09-26 21:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24 19:36 [V2 PATCH] selftests: watchdog: Add gettimeout and get|set pretimeout Jerry Hoemann
2018-09-24 19:36 ` Jerry Hoemann
2018-09-24 19:36 ` jerry.hoemann
2018-09-24 19:36 ` Jerry Hoemann
2018-09-24 19:36   ` Jerry Hoemann
2018-09-24 19:36   ` jerry.hoemann
2018-09-25 20:51   ` Shuah Khan
2018-09-25 20:51     ` Shuah Khan
2018-09-25 20:51     ` shuah
2018-09-26 16:29     ` Jerry Hoemann
2018-09-26 16:29       ` Jerry Hoemann
2018-09-26 16:29       ` jerry.hoemann
2018-09-26 19:47       ` Shuah Khan
2018-09-26 19:47         ` Shuah Khan
2018-09-26 19:47         ` shuah
2018-09-26 20:03         ` Jerry Hoemann
2018-09-26 20:03           ` Jerry Hoemann
2018-09-26 20:03           ` jerry.hoemann
2018-09-26 21:04           ` Shuah Khan [this message]
2018-09-26 21:04             ` Shuah Khan
2018-09-26 21:04             ` shuah
2018-09-24 19:57 ` Shuah Khan
2018-09-24 19:57   ` Shuah Khan
2018-09-24 19:57   ` shuah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07a8e98e-1e25-d87d-51e5-66ff9dd65245@kernel.org \
    --to=shuah@kernel.org \
    --cc=Jerry.Hoemann@hpe.com \
    --cc=erosca@de.adit-jv.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.