[Buildroot] [PATCH] package/audit: Fix type output on log folder creation

[Buildroot] [PATCH] package/audit: Fix type output on log folder creation

[José Pekkarinen]

Testing buildroot 2021.05 I observed that after first
boot I was having the following folders:

/context:
/system_u:object_r:auditd_log_t

The root of this problem turned to be a difference in the
output of $(selabel_lookup -b file -k /var/log/audit) called
by S02auditd that from this verison on looks like:

$ selabel_lookup -b file -k /var/log/audit
Default context: system_u:object_r:auditd_log_t

This patch will cut it to retrieve the type piece only.

Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
---
 package/audit/S02auditd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/audit/S02auditd b/package/audit/S02auditd
index 0eef881cee..dd3dc22d6d 100644
--- a/package/audit/S02auditd
+++ b/package/audit/S02auditd
@@ -20,7 +20,7 @@ start(){
 	# the directory with SELinux permissions if possible
 	command -v selabel_lookup >/dev/null 2>&1
 	if [ $? = 0 ]; then
-		mkdir -p /var/log/audit -Z `selabel_lookup -b file -k /var/log/audit`
+		mkdir -p /var/log/audit -Z `selabel_lookup -b file -k /var/log/audit | cut -d ' ' -f 3`
 	else
 		mkdir -p /var/log/audit
 	fi
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/audit: Fix type output on log folder creation

[Arnout Vandecappelle]

On 01/10/2021 08:20, José Pekkarinen wrote:
> Testing buildroot 2021.05 I observed that after first
> boot I was having the following folders:
> 
> /context:
> /system_u:object_r:auditd_log_t
> 
> The root of this problem turned to be a difference in the
> output of $(selabel_lookup -b file -k /var/log/audit) called
> by S02auditd that from this verison on looks like:
> 
> $ selabel_lookup -b file -k /var/log/audit
> Default context: system_u:object_r:auditd_log_t

  What is the chance that this output format is going to change again? Does 
selabel_lookup has a "scriptable" output format that we can rely on not to change?


  Regards,
  Arnout

> 
> This patch will cut it to retrieve the type piece only.
> 
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
> ---
>   package/audit/S02auditd | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/audit/S02auditd b/package/audit/S02auditd
> index 0eef881cee..dd3dc22d6d 100644
> --- a/package/audit/S02auditd
> +++ b/package/audit/S02auditd
> @@ -20,7 +20,7 @@ start(){
>   	# the directory with SELinux permissions if possible
>   	command -v selabel_lookup >/dev/null 2>&1
>   	if [ $? = 0 ]; then
> -		mkdir -p /var/log/audit -Z `selabel_lookup -b file -k /var/log/audit`
> +		mkdir -p /var/log/audit -Z `selabel_lookup -b file -k /var/log/audit | cut -d ' ' -f 3`
>   	else
>   		mkdir -p /var/log/audit
>   	fi
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/audit: Fix type output on log folder creation

[José Pekkarinen]

[-- Attachment #1.1: Type: text/plain, Size: 1947 bytes --]

On Sun, Oct 3, 2021 at 1:15 PM Arnout Vandecappelle <arnout@mind.be> wrote:

>
>
> On 01/10/2021 08:20, José Pekkarinen wrote:
> > Testing buildroot 2021.05 I observed that after first
> > boot I was having the following folders:
> >
> > /context:
> > /system_u:object_r:auditd_log_t
> >
> > The root of this problem turned to be a difference in the
> > output of $(selabel_lookup -b file -k /var/log/audit) called
> > by S02auditd that from this verison on looks like:
> >
> > $ selabel_lookup -b file -k /var/log/audit
> > Default context: system_u:object_r:auditd_log_t
>
>   What is the chance that this output format is going to change again?
> Does
> selabel_lookup has a "scriptable" output format that we can rely on not to
> change?
>

I'm afraid I have tried both all the options around

without any clearer output, for instance, -r(of raw) still
writes the 'Default context:' piece, as well as the -t(of type).
I know it doesn't look elegant, but for now it seems the
best we can afford.

Best regards.

José.



>
> >
> > This patch will cut it to retrieve the type piece only.
> >
> > Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>
> > ---
> >   package/audit/S02auditd | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/audit/S02auditd b/package/audit/S02auditd
> > index 0eef881cee..dd3dc22d6d 100644
> > --- a/package/audit/S02auditd
> > +++ b/package/audit/S02auditd
> > @@ -20,7 +20,7 @@ start(){
> >       # the directory with SELinux permissions if possible
> >       command -v selabel_lookup >/dev/null 2>&1
> >       if [ $? = 0 ]; then
> > -             mkdir -p /var/log/audit -Z `selabel_lookup -b file -k
> /var/log/audit`
> > +             mkdir -p /var/log/audit -Z `selabel_lookup -b file -k
> /var/log/audit | cut -d ' ' -f 3`
> >       else
> >               mkdir -p /var/log/audit
> >       fi
> >

[-- Attachment #1.2: Type: text/html, Size: 3096 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/audit: Fix type output on log folder creation

[Arnout Vandecappelle]

On 04/10/2021 07:56, José Pekkarinen wrote:
> 
> 
> On Sun, Oct 3, 2021 at 1:15 PM Arnout Vandecappelle <arnout@mind.be 
> <mailto:arnout@mind.be>> wrote:
> 
> 
> 
>     On 01/10/2021 08:20, José Pekkarinen wrote:
>      > Testing buildroot 2021.05 I observed that after first
>      > boot I was having the following folders:
>      >
>      > /context:
>      > /system_u:object_r:auditd_log_t
>      >
>      > The root of this problem turned to be a difference in the
>      > output of $(selabel_lookup -b file -k /var/log/audit) called
>      > by S02auditd that from this verison on looks like:
>      >
>      > $ selabel_lookup -b file -k /var/log/audit
>      > Default context: system_u:object_r:auditd_log_t
> 
>        What is the chance that this output format is going to change again? Does
>     selabel_lookup has a "scriptable" output format that we can rely on not to
>     change?
> 
> 
>     I'm afraid I have tried both all the options around
> 
> without any clearer output, for instance, -r(of raw) still
> writes the 'Default context:' piece, as well as the -t(of type).
> I know it doesn't look elegant, but for now it seems the
> best we can afford.

  I've added a summary to the commit message and applied to master, thanks.

  Regards,
  Arnout

> 
>     Best regards.
> 
>     José.
> 
> 
>      >
>      > This patch will cut it to retrieve the type piece only.
>      >
>      > Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com
>     <mailto:jose.pekkarinen@unikie.com>>
>      > ---
>      >   package/audit/S02auditd | 2 +-
>      >   1 file changed, 1 insertion(+), 1 deletion(-)
>      >
>      > diff --git a/package/audit/S02auditd b/package/audit/S02auditd
>      > index 0eef881cee..dd3dc22d6d 100644
>      > --- a/package/audit/S02auditd
>      > +++ b/package/audit/S02auditd
>      > @@ -20,7 +20,7 @@ start(){
>      >       # the directory with SELinux permissions if possible
>      >       command -v selabel_lookup >/dev/null 2>&1
>      >       if [ $? = 0 ]; then
>      > -             mkdir -p /var/log/audit -Z `selabel_lookup -b file -k
>     /var/log/audit`
>      > +             mkdir -p /var/log/audit -Z `selabel_lookup -b file -k
>     /var/log/audit | cut -d ' ' -f 3`
>      >       else
>      >               mkdir -p /var/log/audit
>      >       fi
>      >
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/audit: Fix type output on log folder creation

[Peter Korsgaard]

>>>>> "José" == José Pekkarinen <jose.pekkarinen@unikie.com> writes:

 > Testing buildroot 2021.05 I observed that after first
 > boot I was having the following folders:

 > /context:
 > /system_u:object_r:auditd_log_t

 > The root of this problem turned to be a difference in the
 > output of $(selabel_lookup -b file -k /var/log/audit) called
 > by S02auditd that from this verison on looks like:

 > $ selabel_lookup -b file -k /var/log/audit
 > Default context: system_u:object_r:auditd_log_t

 > This patch will cut it to retrieve the type piece only.

 > Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>

Committed to 2021.02.x and 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot