* [PATCH] fuzz-test: remove unneccessary debugging flags
@ 2021-02-16 18:13 Alexander Bulekov
2021-02-16 18:21 ` Peter Maydell
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Alexander Bulekov @ 2021-02-16 18:13 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Peter Maydell, Thomas Huth, qemu-trivial,
Alexander Bulekov, Paolo Bonzini, Philippe Mathieu-Daudé
These flags cause the output to look strange for 'make check', and
they aren't needed to reproduce bugs, if they reappear.
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
tests/qtest/fuzz-test.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
index cdb1100a0b..6f161c93be 100644
--- a/tests/qtest/fuzz-test.c
+++ b/tests/qtest/fuzz-test.c
@@ -39,8 +39,7 @@ static void test_lp1878642_pci_bus_get_irq_level_assert(void)
QTestState *s;
s = qtest_init("-M pc-q35-5.0 "
- "-nographic -monitor none -serial none "
- "-d guest_errors -trace pci*");
+ "-nographic -monitor none -serial none");
qtest_outl(s, 0xcf8, 0x8400f841);
qtest_outl(s, 0xcfc, 0xebed205d);
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fuzz-test: remove unneccessary debugging flags
2021-02-16 18:13 [PATCH] fuzz-test: remove unneccessary debugging flags Alexander Bulekov
@ 2021-02-16 18:21 ` Peter Maydell
2021-02-17 6:32 ` Thomas Huth
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2021-02-16 18:21 UTC (permalink / raw)
To: Alexander Bulekov
Cc: Laurent Vivier, Thomas Huth, QEMU Trivial, QEMU Developers,
Paolo Bonzini, Philippe Mathieu-Daudé
On Tue, 16 Feb 2021 at 18:13, Alexander Bulekov <alxndr@bu.edu> wrote:
>
> These flags cause the output to look strange for 'make check', and
> they aren't needed to reproduce bugs, if they reappear.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> tests/qtest/fuzz-test.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fuzz-test: remove unneccessary debugging flags
2021-02-16 18:13 [PATCH] fuzz-test: remove unneccessary debugging flags Alexander Bulekov
2021-02-16 18:21 ` Peter Maydell
@ 2021-02-17 6:32 ` Thomas Huth
2021-02-17 9:57 ` Philippe Mathieu-Daudé
2021-03-09 20:49 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2021-02-17 6:32 UTC (permalink / raw)
To: Alexander Bulekov, qemu-devel
Cc: qemu-trivial, Peter Maydell, Philippe Mathieu-Daudé,
Laurent Vivier, Paolo Bonzini
On 16/02/2021 19.13, Alexander Bulekov wrote:
> These flags cause the output to look strange for 'make check', and
> they aren't needed to reproduce bugs, if they reappear.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> tests/qtest/fuzz-test.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
> index cdb1100a0b..6f161c93be 100644
> --- a/tests/qtest/fuzz-test.c
> +++ b/tests/qtest/fuzz-test.c
> @@ -39,8 +39,7 @@ static void test_lp1878642_pci_bus_get_irq_level_assert(void)
> QTestState *s;
>
> s = qtest_init("-M pc-q35-5.0 "
> - "-nographic -monitor none -serial none "
> - "-d guest_errors -trace pci*");
> + "-nographic -monitor none -serial none");
>
> qtest_outl(s, 0xcf8, 0x8400f841);
> qtest_outl(s, 0xcfc, 0xebed205d);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fuzz-test: remove unneccessary debugging flags
2021-02-16 18:13 [PATCH] fuzz-test: remove unneccessary debugging flags Alexander Bulekov
2021-02-16 18:21 ` Peter Maydell
2021-02-17 6:32 ` Thomas Huth
@ 2021-02-17 9:57 ` Philippe Mathieu-Daudé
2021-03-09 20:49 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-17 9:57 UTC (permalink / raw)
To: Alexander Bulekov, qemu-devel
Cc: qemu-trivial, Peter Maydell, Thomas Huth, Laurent Vivier, Paolo Bonzini
On 2/16/21 7:13 PM, Alexander Bulekov wrote:
> These flags cause the output to look strange for 'make check', and
> they aren't needed to reproduce bugs, if they reappear.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> tests/qtest/fuzz-test.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fuzz-test: remove unneccessary debugging flags
2021-02-16 18:13 [PATCH] fuzz-test: remove unneccessary debugging flags Alexander Bulekov
` (2 preceding siblings ...)
2021-02-17 9:57 ` Philippe Mathieu-Daudé
@ 2021-03-09 20:49 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2021-03-09 20:49 UTC (permalink / raw)
To: Alexander Bulekov, qemu-devel
Cc: Laurent Vivier, Peter Maydell, Thomas Huth, qemu-trivial,
Paolo Bonzini, Philippe Mathieu-Daudé
Le 16/02/2021 à 19:13, Alexander Bulekov a écrit :
> These flags cause the output to look strange for 'make check', and
> they aren't needed to reproduce bugs, if they reappear.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> tests/qtest/fuzz-test.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c
> index cdb1100a0b..6f161c93be 100644
> --- a/tests/qtest/fuzz-test.c
> +++ b/tests/qtest/fuzz-test.c
> @@ -39,8 +39,7 @@ static void test_lp1878642_pci_bus_get_irq_level_assert(void)
> QTestState *s;
>
> s = qtest_init("-M pc-q35-5.0 "
> - "-nographic -monitor none -serial none "
> - "-d guest_errors -trace pci*");
> + "-nographic -monitor none -serial none");
>
> qtest_outl(s, 0xcf8, 0x8400f841);
> qtest_outl(s, 0xcfc, 0xebed205d);
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-09 21:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 18:13 [PATCH] fuzz-test: remove unneccessary debugging flags Alexander Bulekov
2021-02-16 18:21 ` Peter Maydell
2021-02-17 6:32 ` Thomas Huth
2021-02-17 9:57 ` Philippe Mathieu-Daudé
2021-03-09 20:49 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.