* [PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
@ 2018-03-02 5:05 Hui Wang
2018-03-02 8:59 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Hui Wang @ 2018-03-02 5:05 UTC (permalink / raw)
To: alsa-devel, tiwai; +Cc: stable, kailang
With the alc289, the Pin 0x1b is Headphone-Mic, so we should assign
ALC269_FIXUP_DELL4_MIC_NO_PRESENCE rather than
ALC225_FIXUP_DELL1_MIC_NO_PRESENCE to it. And this change is suggested
by Kailang of Realtek and is verified on the machine.
(This fixes the commit 3f2f7c55)
Cc: Kailang Yang <kailang@realtek.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
sound/pci/hda/patch_realtek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b9c93fa..7a9a867 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6872,7 +6872,7 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
{0x12, 0x90a60120},
{0x14, 0x90170110},
{0x21, 0x0321101f}),
- SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
+ SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE,
{0x12, 0xb7a60130},
{0x14, 0x90170110},
{0x21, 0x04211020}),
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
2018-03-02 5:05 [PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines Hui Wang
@ 2018-03-02 8:59 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2018-03-02 8:59 UTC (permalink / raw)
To: Hui Wang; +Cc: alsa-devel, stable, kailang
On Fri, 02 Mar 2018 06:05:36 +0100,
Hui Wang wrote:
>
> With the alc289, the Pin 0x1b is Headphone-Mic, so we should assign
> ALC269_FIXUP_DELL4_MIC_NO_PRESENCE rather than
> ALC225_FIXUP_DELL1_MIC_NO_PRESENCE to it. And this change is suggested
> by Kailang of Realtek and is verified on the machine.
>
> (This fixes the commit 3f2f7c55)
Please use "Fixes:" tag to indicate that.
> Cc: Kailang Yang <kailang@realtek.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Applied now, thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
@ 2018-03-02 8:59 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2018-03-02 8:59 UTC (permalink / raw)
To: Hui Wang; +Cc: alsa-devel, kailang, stable
On Fri, 02 Mar 2018 06:05:36 +0100,
Hui Wang wrote:
>
> With the alc289, the Pin 0x1b is Headphone-Mic, so we should assign
> ALC269_FIXUP_DELL4_MIC_NO_PRESENCE rather than
> ALC225_FIXUP_DELL1_MIC_NO_PRESENCE to it. And this change is suggested
> by Kailang of Realtek and is verified on the machine.
>
> (This fixes the commit 3f2f7c55)
Please use "Fixes:" tag to indicate that.
> Cc: Kailang Yang <kailang@realtek.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Applied now, thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
2018-03-02 8:59 ` Takashi Iwai
(?)
@ 2018-03-03 12:38 ` Hui Wang
-1 siblings, 0 replies; 4+ messages in thread
From: Hui Wang @ 2018-03-03 12:38 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel, kailang, stable
On 2018年03月02日 16:59, Takashi Iwai wrote:
> On Fri, 02 Mar 2018 06:05:36 +0100,
> Hui Wang wrote:
>> With the alc289, the Pin 0x1b is Headphone-Mic, so we should assign
>> ALC269_FIXUP_DELL4_MIC_NO_PRESENCE rather than
>> ALC225_FIXUP_DELL1_MIC_NO_PRESENCE to it. And this change is suggested
>> by Kailang of Realtek and is verified on the machine.
>>
>> (This fixes the commit 3f2f7c55)
> Please use "Fixes:" tag to indicate that.
Got it, will use "Fixes:" in future.
Thanks,
Hui.
>
>> Cc: Kailang Yang <kailang@realtek.com>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Applied now, thanks.
>
>
> Takashi
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-03 12:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-02 5:05 [PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines Hui Wang
2018-03-02 8:59 ` Takashi Iwai
2018-03-02 8:59 ` Takashi Iwai
2018-03-03 12:38 ` [alsa-devel] " Hui Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.