Re: [PATCH v4 11/11] xen/x86: remove cf_check attribute from hypercall handlers

From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
	"George Dunlap" <george.dunlap@citrix.com>,
	"Julien Grall" <julien@xen.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Christopher Clark" <christopher.w.clark@gmail.com>,
	"Dario Faggioli" <dfaggioli@suse.com>,
	"Daniel De Graaf" <dgdegra@tycho.nsa.gov>,
	"Daniel P. Smith" <dpsmith@apertussolutions.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 11/11] xen/x86: remove cf_check attribute from hypercall handlers
Date: Thu, 17 Mar 2022 17:53:03 +0100	[thread overview]
Message-ID: <07f6d45d-b23e-9b2c-4475-dcc5d2ca20c9@suse.com> (raw)
In-Reply-To: <ac5efb3d-e55b-6717-de7f-78447d29f1b9@suse.com>

On 17.03.2022 17:47, Jan Beulich wrote:
> On 10.03.2022 08:34, Juergen Gross wrote:
>> Now that the hypercall handlers are all being called directly instead
>> through a function vector, the "cf_check" attribute can be removed.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> V4:
>> - new patch
>> ---
>>  xen/arch/x86/compat.c               |  6 +++---
>>  xen/arch/x86/cpu/mcheck/mce.c       |  2 +-
>>  xen/arch/x86/cpu/vpmu.c             |  2 +-
>>  xen/arch/x86/domain.c               |  3 +--
>>  xen/arch/x86/hvm/dm.c               |  2 +-
>>  xen/arch/x86/hvm/hvm.c              |  2 +-
>>  xen/arch/x86/hvm/hypercall.c        |  6 +++---
>>  xen/arch/x86/mm.c                   | 12 ++++++------
>>  xen/arch/x86/mm/paging.c            |  2 +-
>>  xen/arch/x86/physdev.c              |  2 +-
>>  xen/arch/x86/platform_hypercall.c   |  2 +-
>>  xen/arch/x86/pv/callback.c          | 16 ++++++++--------
>>  xen/arch/x86/pv/descriptor-tables.c |  8 ++++----
>>  xen/arch/x86/pv/iret.c              |  4 ++--
>>  xen/arch/x86/pv/misc-hypercalls.c   | 10 +++++-----
>>  xen/arch/x86/pv/shim.c              |  4 ++--
>>  xen/arch/x86/x86_64/compat/mm.c     |  2 +-
>>  xen/common/argo.c                   |  4 ++--
>>  xen/common/compat/grant_table.c     |  2 +-
>>  xen/common/compat/kernel.c          |  2 +-
>>  xen/common/compat/memory.c          |  3 +--
>>  xen/common/dm.c                     |  2 +-
>>  xen/common/domain.c                 |  2 +-
>>  xen/common/domctl.c                 |  2 +-
>>  xen/common/event_channel.c          |  2 +-
>>  xen/common/grant_table.c            |  3 +--
>>  xen/common/hypfs.c                  |  2 +-
>>  xen/common/kernel.c                 |  2 +-
>>  xen/common/kexec.c                  |  4 ++--
>>  xen/common/memory.c                 |  2 +-
>>  xen/common/multicall.c              |  3 +--
>>  xen/common/sched/compat.c           |  2 +-
>>  xen/common/sched/core.c             |  4 ++--
>>  xen/common/sysctl.c                 |  2 +-
>>  xen/common/xenoprof.c               |  2 +-
>>  xen/drivers/char/console.c          |  2 +-
>>  xen/scripts/gen_hypercall.awk       |  2 +-
>>  xen/xsm/xsm_core.c                  |  4 ++--
>>  38 files changed, 67 insertions(+), 71 deletions(-)
> 
> But that's only the definitions; for a reason I forget the annotations
> are present also on the declarations (really the "also" applies the
> other way around; perhaps it was that a future gcc will want to warn
> about declaration and definition having gone out of sync).

Actually wait, this was nonsense - the declarations are gone by this
point, and the awk script adjustment is all that's needed.

Acked-by: Jan Beulich <jbeulich@suse.com>

Jan