All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	"Jan Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH v4 07/11] xen: generate hypercall interface related code
Date: Tue, 22 Mar 2022 15:31:40 +0000	[thread overview]
Message-ID: <Yjnr3FAS3G94Yf6+@perard.uk.xensource.com> (raw)
In-Reply-To: <20220310073420.15622-8-jgross@suse.com>

On Thu, Mar 10, 2022 at 08:34:16AM +0100, Juergen Gross wrote:
> diff --git a/xen/include/Makefile b/xen/include/Makefile
> index a3c2511f5f..b52a2da40c 100644
> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -77,6 +77,18 @@ $(obj)/compat/xlat.h: $(addprefix $(obj)/compat/.xlat/,$(xlat-y)) $(obj)/config/
>  	cat $(filter %.h,$^) >$@.new
>  	mv -f $@.new $@
>  
> +quiet_cmd_genhyp = GEN     $@
> +define cmd_genhyp
> +    awk -f $(src)/../scripts/gen_hypercall.awk <$< >$@

You should use "$(srctree)" instead of "$(src)/..".

$(srctree) always point to the source tree of the hypervisor. ( $(src)
doesn't necessarily point to "include/" in the source tree. )

> +endef
> +
> +all: $(obj)/xen/hypercall-defs.h
> +
> +$(obj)/xen/hypercall-defs.h: $(obj)/hypercall-defs.i $(src)/../scripts/gen_hypercall.awk FORCE

Here as well, it would be better to use $(srctree) instead of $(src)/.. .


> +	$(call if_changed,genhyp)
> +
> +targets += xen/hypercall-defs.h
> +
>  ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>  
>  all: $(obj)/headers.chk $(obj)/headers99.chk $(obj)/headers++.chk

Cheers,

-- 
Anthony PERARD


  reply	other threads:[~2022-03-22 15:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10  7:34 [PATCH v4 00/11] xen: drop hypercall function tables Juergen Gross
2022-03-10  7:34 ` [PATCH v4 01/11] xen/arm: rename do_phydev_op() to do_arm_physdev_op() Juergen Gross
2022-03-22 20:09   ` Julien Grall
2022-03-10  7:34 ` [PATCH v4 02/11] xen: move do_vcpu_op() to arch specific code Juergen Gross
2022-03-22 20:13   ` Julien Grall
2022-03-10  7:34 ` [PATCH v4 03/11] xen: switch non style compliant hypercall handler parameter types Juergen Gross
2022-03-10  7:34 ` [PATCH v4 04/11] xen: harmonize return types of hypercall handlers Juergen Gross
2022-03-10  7:34 ` [PATCH v4 05/11] xen: don't include asm/hypercall.h from C sources Juergen Gross
2022-03-22 20:15   ` Julien Grall
2022-03-10  7:34 ` [PATCH v4 06/11] xen: include compat/platform.h from hypercall.h Juergen Gross
2022-03-10  7:34 ` [PATCH v4 07/11] xen: generate hypercall interface related code Juergen Gross
2022-03-22 15:31   ` Anthony PERARD [this message]
2022-03-22 15:51     ` Juergen Gross
2022-03-22 20:25   ` Julien Grall
2022-03-10  7:34 ` [PATCH v4 08/11] xen: use generated prototypes for hypercall handlers Juergen Gross
2022-03-22 20:26   ` Julien Grall
2022-03-10  7:34 ` [PATCH v4 09/11] xen/x86: call hypercall handlers via generated macro Juergen Gross
2022-03-10  7:34 ` [PATCH v4 10/11] xen/arm: " Juergen Gross
2022-03-23  9:40   ` Julien Grall
2022-03-24  6:58     ` Juergen Gross
2022-03-10  7:34 ` [PATCH v4 11/11] xen/x86: remove cf_check attribute from hypercall handlers Juergen Gross
2022-03-14 17:25   ` Daniel P. Smith
2022-03-17 16:47   ` Jan Beulich
2022-03-17 16:52     ` Juergen Gross
2022-03-17 16:53     ` Jan Beulich
2022-03-22 15:06   ` Teo Couprie Diaz
2022-03-21  7:15 ` [PATCH v4.1 02/11] xen: move do_vcpu_op() to arch specific code Juergen Gross
2022-03-21  7:15   ` [PATCH v4.1 11/11] xen/x86: remove cf_check attribute from hypercall handlers Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yjnr3FAS3G94Yf6+@perard.uk.xensource.com \
    --to=anthony.perard@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.