* [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
@ 2020-10-02 23:16 José Roberto de Souza
2020-10-02 23:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: José Roberto de Souza @ 2020-10-02 23:16 UTC (permalink / raw)
To: intel-gfx
Writes to CURSURFLIVE in TGL are causing IOMMU errors and visual
glitches that are often reproduced when executing CPU intensive
workloads while a eDP 4K panel is attached.
Manually exiting PSR causes the frontbuffer to be updated without
glitches and the IOMMU errors are also gone but this comes at the cost
of less time with PSR active.
So using this workaround until this issue is root caused and a better
fix is found.
The current code is already ready to enable PSR after this exit if
there is not other frontbuffer modifications.
Adding a new if block in psr_force_hw_tracking_exit() instead of reuse
the else/gen8- block because the plan is to revert this workaround
as soon as a better solution is found.
Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 8a9d0bdde1bf..8630121dbbbe 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1152,7 +1152,21 @@ void intel_psr_disable(struct intel_dp *intel_dp,
static void psr_force_hw_tracking_exit(struct drm_i915_private *dev_priv)
{
- if (INTEL_GEN(dev_priv) >= 9)
+ if (IS_TIGERLAKE(dev_priv))
+ /*
+ * Writes to CURSURFLIVE in TGL are causing IOMMU errors and
+ * visual glitches that are often reproduced when executing
+ * CPU intensive workloads while a eDP 4K panel is attached.
+ *
+ * Manually exiting PSR causes the frontbuffer to be updated
+ * without glitches and the IOMMU errors are also gone but
+ * this comes at the cost of less time with PSR active.
+ *
+ * So using this workaround until this issue is root caused
+ * and a better fix is found.
+ */
+ intel_psr_exit(dev_priv);
+ else if (INTEL_GEN(dev_priv) >= 9)
/*
* Display WA #0884: skl+
* This documented WA for bxt can be safely applied
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
2020-10-02 23:16 [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications José Roberto de Souza
@ 2020-10-02 23:46 ` Patchwork
2020-10-03 1:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-10-02 23:46 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5127 bytes --]
== Series Details ==
Series: drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
URL : https://patchwork.freedesktop.org/series/82351/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9093 -> Patchwork_18617
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/index.html
Known issues
------------
Here are the changes found in Patchwork_18617 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-icl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- {fi-tgl-dsi}: [DMESG-WARN][3] ([i915#1982] / [k.org#205379]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/fi-tgl-dsi/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/fi-tgl-dsi/igt@i915_module_load@reload.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@vgem_basic@unload:
- fi-skl-guc: [DMESG-WARN][7] ([i915#2203]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/fi-skl-guc/igt@vgem_basic@unload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/fi-skl-guc/igt@vgem_basic@unload.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [DMESG-FAIL][9] ([i915#2203]) -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][11] ([i915#62] / [i915#95]) -> [DMESG-FAIL][12] ([i915#62])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) +5 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@vgem_basic@unload:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#62] / [i915#92])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/fi-kbl-x1275/igt@vgem_basic@unload.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/fi-kbl-x1275/igt@vgem_basic@unload.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (45 -> 38)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bsw-kefka fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9093 -> Patchwork_18617
CI-20190529: 20190529
CI_DRM_9093: 827ebff930c6340ed1c1c274909717525951c496 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5798: 430bad5a53c08125fbd48978ed6a66f61a33a40b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18617: f1ada30987fd65e158d57983299cc772f8af8a7a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f1ada30987fd drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/index.html
[-- Attachment #1.2: Type: text/html, Size: 6626 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
2020-10-02 23:16 [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications José Roberto de Souza
2020-10-02 23:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-10-03 1:26 ` Patchwork
2020-10-05 18:55 ` Souza, Jose
2020-10-05 19:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications (rev2) Patchwork
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Patchwork @ 2020-10-03 1:26 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 17160 bytes --]
== Series Details ==
Series: drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
URL : https://patchwork.freedesktop.org/series/82351/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9093_full -> Patchwork_18617_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18617_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18617_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18617_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-skl: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl6/igt@gem_userptr_blits@unsync-unmap-cycles.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl2/igt@gem_userptr_blits@unsync-unmap-cycles.html
* igt@kms_cursor_edge_walk@pipe-c-64x64-right-edge:
- shard-hsw: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-hsw4/igt@kms_cursor_edge_walk@pipe-c-64x64-right-edge.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-hsw2/igt@kms_cursor_edge_walk@pipe-c-64x64-right-edge.html
* igt@kms_cursor_legacy@all-pipes-forked-bo:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-tglb6/igt@kms_cursor_legacy@all-pipes-forked-bo.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-tglb7/igt@kms_cursor_legacy@all-pipes-forked-bo.html
* igt@kms_psr2_su@frontbuffer:
- shard-tglb: [PASS][7] -> [FAIL][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-tglb7/igt@kms_psr2_su@frontbuffer.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-tglb8/igt@kms_psr2_su@frontbuffer.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_async_flips@test-time-stamp}:
- shard-tglb: [PASS][9] -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-tglb5/igt@kms_async_flips@test-time-stamp.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-tglb8/igt@kms_async_flips@test-time-stamp.html
Known issues
------------
Here are the changes found in Patchwork_18617_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_create@madvise:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#118] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-glk1/igt@gem_exec_create@madvise.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-glk6/igt@gem_exec_create@madvise.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [PASS][13] -> [FAIL][14] ([i915#1860])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-hsw7/igt@i915_pm_rc6_residency@rc6-idle.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-hsw6/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#300])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-tglb: [PASS][17] -> [FAIL][18] ([i915#2346]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-kbl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-kbl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#1635] / [i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-apl7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-apl2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled.html
* igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1:
- shard-skl: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +9 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl8/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl8/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#79])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl3/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl5/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([i915#180]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip_tiling@flip-changes-tiling:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#699])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl10/igt@kms_flip_tiling@flip-changes-tiling.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl3/igt@kms_flip_tiling@flip-changes-tiling.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#49]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-tglb: [PASS][33] -> [DMESG-WARN][34] ([i915#1982]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-tglb1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-tglb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#1188])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-iclb: [PASS][37] -> [INCOMPLETE][38] ([i915#1185] / [i915#250])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-iclb2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#108145] / [i915#265]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html
#### Possible fixes ####
* igt@gem_exec_reloc@basic-cpu-gtt-active:
- shard-skl: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl8/igt@gem_exec_reloc@basic-cpu-gtt-active.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl8/igt@gem_exec_reloc@basic-cpu-gtt-active.html
* igt@gem_exec_reloc@basic-many-active@vecs0:
- shard-glk: [FAIL][45] ([i915#2389]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-glk2/igt@gem_exec_reloc@basic-many-active@vecs0.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-glk5/igt@gem_exec_reloc@basic-many-active@vecs0.html
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-kbl: [FAIL][47] ([i915#2521]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-kbl1/igt@kms_async_flips@async-flip-with-page-flip-events.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-kbl7/igt@kms_async_flips@async-flip-with-page-flip-events.html
* igt@kms_big_fb@linear-8bpp-rotate-0:
- shard-apl: [DMESG-WARN][49] ([i915#1635] / [i915#1982]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-apl8/igt@kms_big_fb@linear-8bpp-rotate-0.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-apl8/igt@kms_big_fb@linear-8bpp-rotate-0.html
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [FAIL][51] ([i915#2122]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl2/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl7/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_flip_tiling@flip-changes-tiling-yf:
- shard-kbl: [DMESG-WARN][53] ([i915#1982]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-kbl1/igt@kms_flip_tiling@flip-changes-tiling-yf.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-kbl7/igt@kms_flip_tiling@flip-changes-tiling-yf.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render:
- shard-tglb: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-tglb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-tglb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][57] ([fdo#108145] / [i915#265]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-glk: [FAIL][61] ([i915#31]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-glk1/igt@kms_setmode@basic.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-glk6/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][63] ([i915#180]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-kbl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-kbl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [FAIL][65] ([i915#1515]) -> [WARN][66] ([i915#1515])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [DMESG-FAIL][67] ([i915#1982]) -> [DMESG-WARN][68] ([i915#1982])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-skl: [INCOMPLETE][69] ([i915#198]) -> [DMESG-WARN][70] ([i915#1982])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@runner@aborted:
- shard-skl: [FAIL][71] ([i915#1436]) -> [FAIL][72] ([i915#1611] / [i915#2029])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9093/shard-skl7/igt@runner@aborted.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/shard-skl3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1515]: https://gitlab.freedesktop.org/drm/intel/issues/1515
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1860]: https://gitlab.freedesktop.org/drm/intel/issues/1860
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 10)
------------------------------
Missing (1): pig-glk-j5005
Build changes
-------------
* Linux: CI_DRM_9093 -> Patchwork_18617
CI-20190529: 20190529
CI_DRM_9093: 827ebff930c6340ed1c1c274909717525951c496 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5798: 430bad5a53c08125fbd48978ed6a66f61a33a40b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18617: f1ada30987fd65e158d57983299cc772f8af8a7a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/index.html
[-- Attachment #1.2: Type: text/html, Size: 19763 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
2020-10-03 1:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-10-05 18:55 ` Souza, Jose
0 siblings, 0 replies; 13+ messages in thread
From: Souza, Jose @ 2020-10-05 18:55 UTC (permalink / raw)
To: intel-gfx
On Sat, 2020-10-03 at 01:26 +0000, Patchwork wrote:
> Patch Details
> Series: drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
> URL: https://patchwork.freedesktop.org/series/82351/
> State: failure
> Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18617/index.html
> CI Bug Log - changes from CI_DRM_9093_full -> Patchwork_18617_full
> Summary
> FAILURE
>
> Serious unknown changes coming with Patchwork_18617_full absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_18617_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> Possible new issues
> Here are the unknown changes that may have been introduced in Patchwork_18617_full:
>
> IGT changes
> Possible regressions
> igt@gem_userptr_blits@unsync-unmap-cycles:
>
> shard-skl: PASS -> TIMEOUT
> igt@kms_cursor_edge_walk@pipe-c-64x64-right-edge:
>
> shard-hsw: PASS -> INCOMPLETE
The two above don't are not related as this change only affects TGL.
> igt@kms_cursor_legacy@all-pipes-forked-bo:
>
> shard-tglb: PASS -> INCOMPLETE
Something went pretty wrong in this test executing by the logs but don't look related.
> igt@kms_psr2_su@frontbuffer:
>
> shard-tglb: PASS -> FAIL +1 similar issue
This failure is expected with this change.
> Suppressed
> The following results come from untrusted machines, tests, or statuses.
> They do not affect the overall result.
>
> {igt@kms_async_flips@test-time-stamp}:
> shard-tglb: PASS -> FAIL
> Known issues
> Here are the changes found in Patchwork_18617_full that come from known issues:
>
> IGT changes
> Issues hit
> igt@gem_exec_create@madvise:
>
> shard-glk: PASS -> DMESG-WARN (i915#118 / i915#95)
> igt@i915_pm_rc6_residency@rc6-idle:
>
> shard-hsw: PASS -> FAIL (i915#1860)
> igt@kms_cursor_crc@pipe-b-cursor-suspend:
>
> shard-skl: PASS -> INCOMPLETE (i915#300)
> igt@kms_cursor_legacy@flip-vs-cursor-atomic:
>
> shard-tglb: PASS -> FAIL (i915#2346) +3 similar issues
> igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
>
> shard-kbl: PASS -> DMESG-WARN (i915#1982)
> igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
>
> shard-apl: PASS -> DMESG-WARN (i915#1635 / i915#1982)
> igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1:
>
> shard-skl: PASS -> DMESG-WARN (i915#1982) +9 similar issues
> igt@kms_flip@flip-vs-expired-vblank@c-edp1:
>
> shard-skl: PASS -> FAIL (i915#79)
> igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
>
> shard-kbl: PASS -> DMESG-WARN (i915#180) +3 similar issues
> igt@kms_flip_tiling@flip-changes-tiling:
>
> shard-skl: PASS -> FAIL (i915#699)
> igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-cpu:
>
> shard-skl: PASS -> FAIL (i915#49) +1 similar issue
> igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt:
>
> shard-tglb: PASS -> DMESG-WARN (i915#1982) +1 similar issue
> igt@kms_hdr@bpc-switch-dpms:
>
> shard-skl: PASS -> FAIL (i915#1188)
> igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
>
> shard-iclb: PASS -> INCOMPLETE (i915#1185 / i915#250)
> igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>
> shard-skl: PASS -> FAIL (fdo#108145 / i915#265) +1 similar issue
> igt@kms_psr@psr2_sprite_mmap_gtt:
>
> shard-iclb: PASS -> SKIP (fdo#109441)
> Possible fixes
> igt@gem_exec_reloc@basic-cpu-gtt-active:
>
> shard-skl: DMESG-WARN (i915#1982) -> PASS +3 similar issues
> igt@gem_exec_reloc@basic-many-active@vecs0:
>
> shard-glk: FAIL (i915#2389) -> PASS
> {igt@kms_async_flips@async-flip-with-page-flip-events}:
>
> shard-kbl: FAIL (i915#2521) -> PASS
> igt@kms_big_fb@linear-8bpp-rotate-0:
>
> shard-apl: DMESG-WARN (i915#1635 / i915#1982) -> PASS
> igt@kms_flip@plain-flip-fb-recreate@b-edp1:
>
> shard-skl: FAIL (i915#2122) -> PASS
> igt@kms_flip_tiling@flip-changes-tiling-yf:
>
> shard-kbl: DMESG-WARN (i915#1982) -> PASS
> igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render:
>
> shard-tglb: DMESG-WARN (i915#1982) -> PASS
> igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
>
> shard-skl: FAIL (fdo#108145 / i915#265) -> PASS
> igt@kms_psr@psr2_cursor_mmap_cpu:
>
> shard-iclb: SKIP (fdo#109441) -> PASS +1 similar issue
> igt@kms_setmode@basic:
>
> shard-glk: FAIL (i915#31) -> PASS
> igt@kms_vblank@pipe-b-ts-continuation-suspend:
>
> shard-kbl: DMESG-WARN (i915#180) -> PASS
> Warnings
> igt@i915_pm_rc6_residency@rc6-idle:
>
> shard-iclb: FAIL (i915#1515) -> WARN (i915#1515)
> igt@kms_cursor_legacy@flip-vs-cursor-atomic:
>
> shard-skl: DMESG-FAIL (i915#1982) -> DMESG-WARN (i915#1982)
> igt@kms_vblank@pipe-a-ts-continuation-suspend:
>
> shard-skl: INCOMPLETE (i915#198) -> DMESG-WARN (i915#1982)
> igt@runner@aborted:
>
> shard-skl: FAIL (i915#1436) -> FAIL (i915#1611 / i915#2029)
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> Participating hosts (11 -> 10)
> Missing (1): pig-glk-j5005
>
> Build changes
> Linux: CI_DRM_9093 -> Patchwork_18617
> CI-20190529: 20190529
> CI_DRM_9093: 827ebff930c6340ed1c1c274909717525951c496 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5798: 430bad5a53c08125fbd48978ed6a66f61a33a40b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_18617: f1ada30987fd65e158d57983299cc772f8af8a7a @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications (rev2)
2020-10-02 23:16 [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications José Roberto de Souza
2020-10-02 23:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-03 1:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-10-05 19:54 ` Patchwork
2020-10-05 21:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2020-10-05 19:54 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5070 bytes --]
== Series Details ==
Series: drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications (rev2)
URL : https://patchwork.freedesktop.org/series/82351/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9097 -> Patchwork_18625
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/index.html
Known issues
------------
Here are the changes found in Patchwork_18625 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- {fi-tgl-dsi}: [DMESG-WARN][5] ([i915#1982] / [k.org#205379]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/fi-tgl-dsi/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/fi-tgl-dsi/igt@i915_module_load@reload.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
* igt@kms_force_connector_basic@force-connector-state:
- {fi-tgl-dsi}: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/fi-tgl-dsi/igt@kms_force_connector_basic@force-connector-state.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/fi-tgl-dsi/igt@kms_force_connector_basic@force-connector-state.html
* igt@vgem_basic@unload:
- fi-skl-guc: [DMESG-WARN][11] ([i915#2203]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/fi-skl-guc/igt@vgem_basic@unload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/fi-skl-guc/igt@vgem_basic@unload.html
#### Warnings ####
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@prime_vgem@basic-fence-flip:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#62] / [i915#92]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (44 -> 38)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9097 -> Patchwork_18625
CI-20190529: 20190529
CI_DRM_9097: 5f854df6a9500c0888864bb0be25995ccb696e41 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5800: 982ca4122fd4f04ad3dfa80c6246f190b36e0c72 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18625: 68870e5d103dec6a4a8c09849a771dee2dbd4ecb @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
68870e5d103d drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/index.html
[-- Attachment #1.2: Type: text/html, Size: 6524 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications (rev2)
2020-10-02 23:16 [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications José Roberto de Souza
` (2 preceding siblings ...)
2020-10-05 19:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications (rev2) Patchwork
@ 2020-10-05 21:48 ` Patchwork
2020-10-23 21:31 ` Souza, Jose
2020-10-12 18:12 ` [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications Mun, Gwan-gyeong
2020-10-22 12:43 ` Mun, Gwan-gyeong
5 siblings, 1 reply; 13+ messages in thread
From: Patchwork @ 2020-10-05 21:48 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 13726 bytes --]
== Series Details ==
Series: drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications (rev2)
URL : https://patchwork.freedesktop.org/series/82351/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9097_full -> Patchwork_18625_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18625_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18625_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18625_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_legacy@all-pipes-forked-move:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-tglb8/igt@kms_cursor_legacy@all-pipes-forked-move.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-tglb8/igt@kms_cursor_legacy@all-pipes-forked-move.html
* igt@kms_psr2_su@frontbuffer:
- shard-tglb: [PASS][3] -> [FAIL][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-tglb2/igt@kms_psr2_su@frontbuffer.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-tglb7/igt@kms_psr2_su@frontbuffer.html
Known issues
------------
Here are the changes found in Patchwork_18625_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-hsw: [PASS][5] -> [FAIL][6] ([i915#2389])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-hsw6/igt@gem_exec_reloc@basic-many-active@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-hsw4/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-hsw: [PASS][7] -> [WARN][8] ([i915#1519])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-hsw2/igt@i915_pm_rc6_residency@rc6-fence.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-hsw1/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +5 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_edge_walk@pipe-c-128x128-right-edge:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-glk5/igt@kms_cursor_edge_walk@pipe-c-128x128-right-edge.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-glk4/igt@kms_cursor_edge_walk@pipe-c-128x128-right-edge.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2346]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@pipe-c-torture-bo:
- shard-tglb: [PASS][15] -> [DMESG-WARN][16] ([i915#128])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-tglb5/igt@kms_cursor_legacy@pipe-c-torture-bo.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-tglb8/igt@kms_cursor_legacy@pipe-c-torture-bo.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#1188])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:
- shard-skl: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +9 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-skl3/igt@kms_plane@plane-panning-bottom-right-pipe-b-planes.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-skl5/igt@kms_plane@plane-panning-bottom-right-pipe-b-planes.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: [PASS][21] -> [INCOMPLETE][22] ([i915#648])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-skl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-skl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#108145] / [i915#265]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html
#### Possible fixes ####
* igt@gem_exec_reloc@basic-many-active@bcs0:
- shard-glk: [FAIL][27] ([i915#2389]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-glk4/igt@gem_exec_reloc@basic-many-active@bcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-glk3/igt@gem_exec_reloc@basic-many-active@bcs0.html
* igt@gem_mmap_gtt@medium-copy-xy:
- shard-iclb: [DMESG-WARN][29] ([i915#1982]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-iclb2/igt@gem_mmap_gtt@medium-copy-xy.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-iclb4/igt@gem_mmap_gtt@medium-copy-xy.html
* igt@gem_mmap_offset@blt-coherency:
- shard-glk: [FAIL][31] ([i915#2328]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-glk5/igt@gem_mmap_offset@blt-coherency.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-glk4/igt@gem_mmap_offset@blt-coherency.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-skl: [TIMEOUT][33] ([i915#2424]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-skl10/igt@gem_userptr_blits@sync-unmap-cycles.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-skl8/igt@gem_userptr_blits@sync-unmap-cycles.html
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-kbl: [FAIL][35] ([i915#2521]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-kbl2/igt@kms_async_flips@async-flip-with-page-flip-events.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-kbl2/igt@kms_async_flips@async-flip-with-page-flip-events.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels@edp-1-pipe-a:
- shard-skl: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38] +4 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-skl2/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels@edp-1-pipe-a.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-skl7/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels@edp-1-pipe-a.html
* igt@kms_flip@flip-vs-blocking-wf-vblank@b-edp1:
- shard-tglb: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40] +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-tglb6/igt@kms_flip@flip-vs-blocking-wf-vblank@b-edp1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-tglb3/igt@kms_flip@flip-vs-blocking-wf-vblank@b-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [FAIL][41] ([i915#2122]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][43] ([i915#180]) -> [PASS][44] +6 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-kbl: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [INCOMPLETE][47] ([i915#198]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-skl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-skl5/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][49] ([fdo#108145] / [i915#265]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][51] ([fdo#109441]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][53] ([i915#1635] / [i915#31]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-apl7/igt@kms_setmode@basic.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-apl4/igt@kms_setmode@basic.html
* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-glk: [FAIL][55] ([i915#1755]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/shard-glk4/igt@sysfs_timeslice_duration@timeout@vecs0.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/shard-glk3/igt@sysfs_timeslice_duration@timeout@vecs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2328]: https://gitlab.freedesktop.org/drm/intel/issues/2328
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
Participating hosts (11 -> 12)
------------------------------
Additional (1): pig-snb-2600
Build changes
-------------
* Linux: CI_DRM_9097 -> Patchwork_18625
CI-20190529: 20190529
CI_DRM_9097: 5f854df6a9500c0888864bb0be25995ccb696e41 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5800: 982ca4122fd4f04ad3dfa80c6246f190b36e0c72 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18625: 68870e5d103dec6a4a8c09849a771dee2dbd4ecb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/index.html
[-- Attachment #1.2: Type: text/html, Size: 15715 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
2020-10-02 23:16 [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications José Roberto de Souza
` (3 preceding siblings ...)
2020-10-05 21:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-10-12 18:12 ` Mun, Gwan-gyeong
2020-10-12 18:15 ` Souza, Jose
2020-10-22 12:43 ` Mun, Gwan-gyeong
5 siblings, 1 reply; 13+ messages in thread
From: Mun, Gwan-gyeong @ 2020-10-12 18:12 UTC (permalink / raw)
To: intel-gfx, Souza, Jose
After applying this patch, the psr screen glitch issue is still seen.
On Fri, 2020-10-02 at 16:16 -0700, José Roberto de Souza wrote:
> Writes to CURSURFLIVE in TGL are causing IOMMU errors and visual
> glitches that are often reproduced when executing CPU intensive
> workloads while a eDP 4K panel is attached.
>
> Manually exiting PSR causes the frontbuffer to be updated without
> glitches and the IOMMU errors are also gone but this comes at the
> cost
> of less time with PSR active.
>
> So using this workaround until this issue is root caused and a better
> fix is found.
>
> The current code is already ready to enable PSR after this exit if
> there is not other frontbuffer modifications.
>
> Adding a new if block in psr_force_hw_tracking_exit() instead of
> reuse
> the else/gen8- block because the plan is to revert this workaround
> as soon as a better solution is found.
>
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 8a9d0bdde1bf..8630121dbbbe 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1152,7 +1152,21 @@ void intel_psr_disable(struct intel_dp
> *intel_dp,
>
> static void psr_force_hw_tracking_exit(struct drm_i915_private
> *dev_priv)
> {
> - if (INTEL_GEN(dev_priv) >= 9)
> + if (IS_TIGERLAKE(dev_priv))
> + /*
> + * Writes to CURSURFLIVE in TGL are causing IOMMU
> errors and
> + * visual glitches that are often reproduced when
> executing
> + * CPU intensive workloads while a eDP 4K panel is
> attached.
> + *
> + * Manually exiting PSR causes the frontbuffer to be
> updated
> + * without glitches and the IOMMU errors are also gone
> but
> + * this comes at the cost of less time with PSR active.
> + *
> + * So using this workaround until this issue is root
> caused
> + * and a better fix is found.
> + */
> + intel_psr_exit(dev_priv);
> + else if (INTEL_GEN(dev_priv) >= 9)
> /*
> * Display WA #0884: skl+
> * This documented WA for bxt can be safely applied
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
2020-10-12 18:12 ` [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications Mun, Gwan-gyeong
@ 2020-10-12 18:15 ` Souza, Jose
2020-10-12 19:04 ` Mun, Gwan-gyeong
0 siblings, 1 reply; 13+ messages in thread
From: Souza, Jose @ 2020-10-12 18:15 UTC (permalink / raw)
To: Mun, Gwan-gyeong, intel-gfx
On Mon, 2020-10-12 at 19:12 +0100, Mun, Gwan-gyeong wrote:
> After applying this patch, the psr screen glitch issue is still seen.
Same IOMMU errors too? In my end it is fixed.
Can you also give a try without the DMC firmware and without this changes?
> On Fri, 2020-10-02 at 16:16 -0700, José Roberto de Souza wrote:
> > Writes to CURSURFLIVE in TGL are causing IOMMU errors and visual
> > glitches that are often reproduced when executing CPU intensive
> > workloads while a eDP 4K panel is attached.
> >
> > Manually exiting PSR causes the frontbuffer to be updated without
> > glitches and the IOMMU errors are also gone but this comes at the
> > cost
> > of less time with PSR active.
> >
> > So using this workaround until this issue is root caused and a better
> > fix is found.
> >
> > The current code is already ready to enable PSR after this exit if
> > there is not other frontbuffer modifications.
> >
> > Adding a new if block in psr_force_hw_tracking_exit() instead of
> > reuse
> > the else/gen8- block because the plan is to revert this workaround
> > as soon as a better solution is found.
> >
> > Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_psr.c | 16 +++++++++++++++-
> > 1 file changed, 15 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 8a9d0bdde1bf..8630121dbbbe 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1152,7 +1152,21 @@ void intel_psr_disable(struct intel_dp
> > *intel_dp,
> >
> >
> >
> >
> > static void psr_force_hw_tracking_exit(struct drm_i915_private
> > *dev_priv)
> > {
> > - if (INTEL_GEN(dev_priv) >= 9)
> > + if (IS_TIGERLAKE(dev_priv))
> > + /*
> > + * Writes to CURSURFLIVE in TGL are causing IOMMU
> > errors and
> > + * visual glitches that are often reproduced when
> > executing
> > + * CPU intensive workloads while a eDP 4K panel is
> > attached.
> > + *
> > + * Manually exiting PSR causes the frontbuffer to be
> > updated
> > + * without glitches and the IOMMU errors are also gone
> > but
> > + * this comes at the cost of less time with PSR active.
> > + *
> > + * So using this workaround until this issue is root
> > caused
> > + * and a better fix is found.
> > + */
> > + intel_psr_exit(dev_priv);
> > + else if (INTEL_GEN(dev_priv) >= 9)
> > /*
> > * Display WA #0884: skl+
> > * This documented WA for bxt can be safely applied
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
2020-10-12 18:15 ` Souza, Jose
@ 2020-10-12 19:04 ` Mun, Gwan-gyeong
0 siblings, 0 replies; 13+ messages in thread
From: Mun, Gwan-gyeong @ 2020-10-12 19:04 UTC (permalink / raw)
To: intel-gfx, Souza, Jose
On Mon, 2020-10-12 at 11:15 -0700, Souza, Jose wrote:
> On Mon, 2020-10-12 at 19:12 +0100, Mun, Gwan-gyeong wrote:
> > After applying this patch, the psr screen glitch issue is still
> > seen.
>
> Same IOMMU errors too? In my end it is fixed.
> Can you also give a try without the DMC firmware and without this
> changes?
>
- Result with DMC firmware (tgl_dmc_ver2_08.bin, the latest drm-tip
requires this version) showes PSR screen glitch issue.
- Result without DMC firmware does not show PSR screen glitch issue.
>
> > On Fri, 2020-10-02 at 16:16 -0700, José Roberto de Souza wrote:
> > > Writes to CURSURFLIVE in TGL are causing IOMMU errors and visual
> > > glitches that are often reproduced when executing CPU intensive
> > > workloads while a eDP 4K panel is attached.
> > >
> > > Manually exiting PSR causes the frontbuffer to be updated without
> > > glitches and the IOMMU errors are also gone but this comes at the
> > > cost
> > > of less time with PSR active.
> > >
> > > So using this workaround until this issue is root caused and a
> > > better
> > > fix is found.
> > >
> > > The current code is already ready to enable PSR after this exit
> > > if
> > > there is not other frontbuffer modifications.
> > >
> > > Adding a new if block in psr_force_hw_tracking_exit() instead of
> > > reuse
> > > the else/gen8- block because the plan is to revert this
> > > workaround
> > > as soon as a better solution is found.
> > >
> > > Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_psr.c | 16 +++++++++++++++-
> > > 1 file changed, 15 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > > b/drivers/gpu/drm/i915/display/intel_psr.c
> > > index 8a9d0bdde1bf..8630121dbbbe 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > > @@ -1152,7 +1152,21 @@ void intel_psr_disable(struct intel_dp
> > > *intel_dp,
> > >
> > >
> > >
> > >
> > > static void psr_force_hw_tracking_exit(struct drm_i915_private
> > > *dev_priv)
> > > {
> > > - if (INTEL_GEN(dev_priv) >= 9)
> > > + if (IS_TIGERLAKE(dev_priv))
> > > + /*
> > > + * Writes to CURSURFLIVE in TGL are causing IOMMU
> > > errors and
> > > + * visual glitches that are often reproduced when
> > > executing
> > > + * CPU intensive workloads while a eDP 4K panel is
> > > attached.
> > > + *
> > > + * Manually exiting PSR causes the frontbuffer to be
> > > updated
> > > + * without glitches and the IOMMU errors are also gone
> > > but
> > > + * this comes at the cost of less time with PSR active.
> > > + *
> > > + * So using this workaround until this issue is root
> > > caused
> > > + * and a better fix is found.
> > > + */
> > > + intel_psr_exit(dev_priv);
> > > + else if (INTEL_GEN(dev_priv) >= 9)
> > > /*
> > > * Display WA #0884: skl+
> > > * This documented WA for bxt can be safely applied
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
2020-10-02 23:16 [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications José Roberto de Souza
` (4 preceding siblings ...)
2020-10-12 18:12 ` [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications Mun, Gwan-gyeong
@ 2020-10-22 12:43 ` Mun, Gwan-gyeong
2020-10-22 12:48 ` Mun, Gwan-gyeong
5 siblings, 1 reply; 13+ messages in thread
From: Mun, Gwan-gyeong @ 2020-10-22 12:43 UTC (permalink / raw)
To: intel-gfx, Souza, Jose
1. While testing the problematic scenario, it has not always shown the
IOMMU DAMR related below errors on the drm-tip.
(sometimes the error messages raised, but some times it has not
happened on the same kernel and scenario.
DMAR: DRHD: handling fault status reg 2
DMAR: [DMA Read] Request device [00:02.0] PASID 0xffffffff fault addr
0xfc001000 [fault reason 06] PTE Read access is not set
DMAR: DRHD: handling fault status reg 3
DMAR: [DMA Read] Request device [00:02.0] PASID 0xffffffff fault addr
0xfc000000 [fault reason 06] PTE Read access is not set
2 After applying this patch the screen glitch issues have been
remarkably alleviated.
- Eventhough there infrequently showed the screen glitch issues.
- But I agree to apply this patch as a workaround by adding the
explanation below.
3. The dc state and PSR enable/disable scenarios has been changed by
this patch.
(1)Before applying patch
enable psr
-> (front buffer updates)
-> intel_psr_flush
^ -> psr_force_hw_tracking_exit()
| : write CURSURFLIVE
| |
| (front buffer updates) |
+--------------------------+
PSR enabled -------------------------------------- -->
( DC state controlled by DMC firmware)
(2) After applying patch
enable psr
^ -> (front buffer updates)
| -> intel_psr_flush
| -> psr_force_hw_tracking_exit()
| : call intel_psr_exit()
| -> disable psr
| |
| |
+-----------------------------------------+
PSR enabled ---------------------------> PSR disabled
^ |
| |
+------------------------------------------+
( DC state controlled by DMC firmware)
the repeating of enabling and disabling of PSR by the rapid screen
updates prevents entering of low power dc states.
Infereing from this scenario, it indirectly touches DC state and it
alleviates the issue.
On Fri, 2020-10-02 at 16:16 -0700, José Roberto de Souza wrote:
> Writes to CURSURFLIVE in TGL are causing IOMMU errors and visual
> glitches that are often reproduced when executing CPU intensive
> workloads while a eDP 4K panel is attached.
>
> Manually exiting PSR causes the frontbuffer to be updated without
> glitches and the IOMMU errors are also gone but this comes at the
> cost
> of less time with PSR active.
>
> So using this workaround until this issue is root caused and a better
> fix is found.
>
> The current code is already ready to enable PSR after this exit if
> there is not other frontbuffer modifications.
>
> Adding a new if block in psr_force_hw_tracking_exit() instead of
> reuse
> the else/gen8- block because the plan is to revert this workaround
> as soon as a better solution is found.
>
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 8a9d0bdde1bf..8630121dbbbe 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1152,7 +1152,21 @@ void intel_psr_disable(struct intel_dp
> *intel_dp,
>
> static void psr_force_hw_tracking_exit(struct drm_i915_private
> *dev_priv)
> {
> - if (INTEL_GEN(dev_priv) >= 9)
> + if (IS_TIGERLAKE(dev_priv))
> + /*
> + * Writes to CURSURFLIVE in TGL are causing IOMMU
> errors and
> + * visual glitches that are often reproduced when
> executing
> + * CPU intensive workloads while a eDP 4K panel is
> attached.
> + *
> + * Manually exiting PSR causes the frontbuffer to be
> updated
> + * without glitches and the IOMMU errors are also gone
> but
> + * this comes at the cost of less time with PSR active.
> + *
> + * So using this workaround until this issue is root
> caused
> + * and a better fix is found.
> + */
> + intel_psr_exit(dev_priv);
> + else if (INTEL_GEN(dev_priv) >= 9)
> /*
> * Display WA #0884: skl+
> * This documented WA for bxt can be safely applied
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
2020-10-22 12:43 ` Mun, Gwan-gyeong
@ 2020-10-22 12:48 ` Mun, Gwan-gyeong
2020-10-23 21:27 ` Souza, Jose
0 siblings, 1 reply; 13+ messages in thread
From: Mun, Gwan-gyeong @ 2020-10-22 12:48 UTC (permalink / raw)
To: intel-gfx, Souza, Jose
On Thu, 2020-10-22 at 12:43 +0000, Mun, Gwan-gyeong wrote:
> 1. While testing the problematic scenario, it has not always shown
> the
> IOMMU DAMR related below errors on the drm-tip.
> (sometimes the error messages raised, but some times it has not
> happened on the same kernel and scenario.
>
> DMAR: DRHD: handling fault status reg 2
> DMAR: [DMA Read] Request device [00:02.0] PASID 0xffffffff fault addr
> 0xfc001000 [fault reason 06] PTE Read access is not set
> DMAR: DRHD: handling fault status reg 3
> DMAR: [DMA Read] Request device [00:02.0] PASID 0xffffffff fault addr
> 0xfc000000 [fault reason 06] PTE Read access is not set
>
> 2 After applying this patch the screen glitch issues have been
> remarkably alleviated.
> - Eventhough there infrequently showed the screen glitch issues.
> - But I agree to apply this patch as a workaround by adding the
> explanation below.
>
> 3. The dc state and PSR enable/disable scenarios has been changed by
> this patch.
>
> (1)Before applying patch
> enable psr
> -> (front buffer updates)
> -> intel_psr_flush
> ^ -> psr_force_hw_tracking_exit()
> | : write CURSURFLIVE
> | |
> | (front buffer updates) |
> +--------------------------+
>
> PSR enabled -------------------------------------- -->
> ( DC state controlled by DMC firmware)
>
>
> (2) After applying patch
> enable psr
> ^ -> (front buffer updates)
> | -> intel_psr_flush
> | -> psr_force_hw_tracking_exit()
> | : call intel_psr_exit()
> | -> disable psr
> | |
> | |
> +-----------------------------------------+
>
> PSR enabled ---------------------------> PSR disabled
> ^ |
> | |
> +------------------------------------------+
> ( DC state controlled by DMC firmware)
>
> the repeating of enabling and disabling of PSR by the rapid screen
> updates prevents entering of low power dc states.
> Infereing from this scenario, it indirectly touches DC state and it
> alleviates the issue.
>
with the previous comments,
Tested-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
>
> On Fri, 2020-10-02 at 16:16 -0700, José Roberto de Souza wrote:
> > Writes to CURSURFLIVE in TGL are causing IOMMU errors and visual
> > glitches that are often reproduced when executing CPU intensive
> > workloads while a eDP 4K panel is attached.
> >
> > Manually exiting PSR causes the frontbuffer to be updated without
> > glitches and the IOMMU errors are also gone but this comes at the
> > cost
> > of less time with PSR active.
> >
> > So using this workaround until this issue is root caused and a
> > better
> > fix is found.
> >
> > The current code is already ready to enable PSR after this exit if
> > there is not other frontbuffer modifications.
> >
> > Adding a new if block in psr_force_hw_tracking_exit() instead of
> > reuse
> > the else/gen8- block because the plan is to revert this workaround
> > as soon as a better solution is found.
> >
> > Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_psr.c | 16 +++++++++++++++-
> > 1 file changed, 15 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 8a9d0bdde1bf..8630121dbbbe 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1152,7 +1152,21 @@ void intel_psr_disable(struct intel_dp
> > *intel_dp,
> >
> > static void psr_force_hw_tracking_exit(struct drm_i915_private
> > *dev_priv)
> > {
> > - if (INTEL_GEN(dev_priv) >= 9)
> > + if (IS_TIGERLAKE(dev_priv))
> > + /*
> > + * Writes to CURSURFLIVE in TGL are causing IOMMU
> > errors and
> > + * visual glitches that are often reproduced when
> > executing
> > + * CPU intensive workloads while a eDP 4K panel is
> > attached.
> > + *
> > + * Manually exiting PSR causes the frontbuffer to be
> > updated
> > + * without glitches and the IOMMU errors are also gone
> > but
> > + * this comes at the cost of less time with PSR active.
> > + *
> > + * So using this workaround until this issue is root
> > caused
> > + * and a better fix is found.
> > + */
> > + intel_psr_exit(dev_priv);
> > + else if (INTEL_GEN(dev_priv) >= 9)
> > /*
> > * Display WA #0884: skl+
> > * This documented WA for bxt can be safely applied
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications
2020-10-22 12:48 ` Mun, Gwan-gyeong
@ 2020-10-23 21:27 ` Souza, Jose
0 siblings, 0 replies; 13+ messages in thread
From: Souza, Jose @ 2020-10-23 21:27 UTC (permalink / raw)
To: Mun, Gwan-gyeong, intel-gfx
On Thu, 2020-10-22 at 13:48 +0100, Mun, Gwan-gyeong wrote:
> On Thu, 2020-10-22 at 12:43 +0000, Mun, Gwan-gyeong wrote:
> > 1. While testing the problematic scenario, it has not always shown
> > the
> > IOMMU DAMR related below errors on the drm-tip.
> > (sometimes the error messages raised, but some times it has not
> > happened on the same kernel and scenario.
> >
> >
> >
> >
> > DMAR: DRHD: handling fault status reg 2
> > DMAR: [DMA Read] Request device [00:02.0] PASID 0xffffffff fault addr
> > 0xfc001000 [fault reason 06] PTE Read access is not set
> > DMAR: DRHD: handling fault status reg 3
> > DMAR: [DMA Read] Request device [00:02.0] PASID 0xffffffff fault addr
> > 0xfc000000 [fault reason 06] PTE Read access is not set
> >
> > 2 After applying this patch the screen glitch issues have been
> > remarkably alleviated.
> > - Eventhough there infrequently showed the screen glitch issues.
> > - But I agree to apply this patch as a workaround by adding the
> > explanation below.
> >
> >
> >
> >
> > 3. The dc state and PSR enable/disable scenarios has been changed by
> > this patch.
> >
> >
> >
> >
> > (1)Before applying patch
> > enable psr
> > -> (front buffer updates)
> > -> intel_psr_flush
> > ^ -> psr_force_hw_tracking_exit()
> > | : write CURSURFLIVE
> > | |
> > | (front buffer updates) |
> > +--------------------------+
> >
> > PSR enabled -------------------------------------- -->
> > ( DC state controlled by DMC firmware)
This scenario also causes the display to go out of DC5 too as it needs to wakeup send the PSR1 full update or the PSR2 selective update.
But I agree that doing a PSR exit will cause PSR to not be active for a few frames less than the CURSURFLIVE write.
But we already have this scenario for platforms older than gen9, so all this comments are not necessary.
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > (2) After applying patch
> > enable psr
> > ^ -> (front buffer updates)
> > | -> intel_psr_flush
> > | -> psr_force_hw_tracking_exit()
> > | : call intel_psr_exit()
> > | -> disable psr
> > | |
> > | |
> > +-----------------------------------------+
> >
> > PSR enabled ---------------------------> PSR disabled
> > ^ |
> > | |
> > +------------------------------------------+
> > ( DC state controlled by DMC firmware)
> >
> > the repeating of enabling and disabling of PSR by the rapid screen
> > updates prevents entering of low power dc states.
> > Infereing from this scenario, it indirectly touches DC state and it
> > alleviates the issue.
> >
> with the previous comments,
> Tested-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Thanks going to push this and send the IGT side changes.
> >
> > On Fri, 2020-10-02 at 16:16 -0700, José Roberto de Souza wrote:
> > > Writes to CURSURFLIVE in TGL are causing IOMMU errors and visual
> > > glitches that are often reproduced when executing CPU intensive
> > > workloads while a eDP 4K panel is attached.
> > >
> > > Manually exiting PSR causes the frontbuffer to be updated without
> > > glitches and the IOMMU errors are also gone but this comes at the
> > > cost
> > > of less time with PSR active.
> > >
> > > So using this workaround until this issue is root caused and a
> > > better
> > > fix is found.
> > >
> > > The current code is already ready to enable PSR after this exit if
> > > there is not other frontbuffer modifications.
> > >
> > > Adding a new if block in psr_force_hw_tracking_exit() instead of
> > > reuse
> > > the else/gen8- block because the plan is to revert this workaround
> > > as soon as a better solution is found.
> > >
> > > Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_psr.c | 16 +++++++++++++++-
> > > 1 file changed, 15 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > > b/drivers/gpu/drm/i915/display/intel_psr.c
> > > index 8a9d0bdde1bf..8630121dbbbe 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > > @@ -1152,7 +1152,21 @@ void intel_psr_disable(struct intel_dp
> > > *intel_dp,
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > static void psr_force_hw_tracking_exit(struct drm_i915_private
> > > *dev_priv)
> > > {
> > > - if (INTEL_GEN(dev_priv) >= 9)
> > > + if (IS_TIGERLAKE(dev_priv))
> > > + /*
> > > + * Writes to CURSURFLIVE in TGL are causing IOMMU
> > > errors and
> > > + * visual glitches that are often reproduced when
> > > executing
> > > + * CPU intensive workloads while a eDP 4K panel is
> > > attached.
> > > + *
> > > + * Manually exiting PSR causes the frontbuffer to be
> > > updated
> > > + * without glitches and the IOMMU errors are also gone
> > > but
> > > + * this comes at the cost of less time with PSR active.
> > > + *
> > > + * So using this workaround until this issue is root
> > > caused
> > > + * and a better fix is found.
> > > + */
> > > + intel_psr_exit(dev_priv);
> > > + else if (INTEL_GEN(dev_priv) >= 9)
> > > /*
> > > * Display WA #0884: skl+
> > > * This documented WA for bxt can be safely applied
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications (rev2)
2020-10-05 21:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-10-23 21:31 ` Souza, Jose
0 siblings, 0 replies; 13+ messages in thread
From: Souza, Jose @ 2020-10-23 21:31 UTC (permalink / raw)
To: intel-gfx
On Mon, 2020-10-05 at 21:48 +0000, Patchwork wrote:
> Patch Details
> Series: drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications (rev2) URL: https://patchwork.freedesktop.org/series/82351/ State:
> failure Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18625/index.html
> CI Bug Log - changes from CI_DRM_9097_full -> Patchwork_18625_fullSummaryFAILURE
> Serious unknown changes coming with Patchwork_18625_full absolutely need to be
> verified manually.
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_18625_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
> Possible new issuesHere are the unknown changes that may have been introduced in Patchwork_18625_full:
> IGT changesPossible regressions * igt@kms_cursor_legacy@all-pipes-forked-move:shard-tglb: PASS -> INCOMPLETE
The failure above it not related.
> * igt@kms_psr2_su@frontbuffer:shard-tglb: PASS -> FAIL +1 similar issue
The failure above is expected by this patch, will follow up with the IGT change to skip this test in TGL.
Patch pushed to dinq, thanks for the review GG.
> Known issuesHere are the changes found in Patchwork_18625_full that come from known issues:
> IGT changesIssues hit * igt@gem_exec_reloc@basic-many-active@rcs0:shard-hsw: PASS -> FAIL (i915#2389)
> * igt@i915_pm_rc6_residency@rc6-fence:shard-hsw: PASS -> WARN (i915#1519)
> * igt@kms_cursor_crc@pipe-a-cursor-suspend:shard-kbl: PASS -> DMESG-WARN (i915#180) +5 similar issues
> * igt@kms_cursor_edge_walk@pipe-c-128x128-right-edge:shard-glk: PASS -> DMESG-WARN (i915#1982)
> * igt@kms_cursor_legacy@flip-vs-cursor-atomic:shard-tglb: PASS -> FAIL (i915#2346) +3 similar issues
> * igt@kms_cursor_legacy@pipe-c-torture-bo:shard-tglb: PASS -> DMESG-WARN (i915#128)
> * igt@kms_hdr@bpc-switch-dpms:shard-skl: PASS -> FAIL (i915#1188)
> * igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:shard-skl: PASS -> DMESG-WARN (i915#1982) +9 similar issues
> * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:shard-skl: PASS -> INCOMPLETE (i915#648)
> * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:shard-skl: PASS -> FAIL (fdo#108145 / i915#265) +1 similar issue
> * igt@kms_psr@psr2_sprite_plane_move:shard-iclb: PASS -> SKIP (fdo#109441) +2 similar issues
> Possible fixes * igt@gem_exec_reloc@basic-many-active@bcs0:shard-glk: FAIL (i915#2389) -> PASS
> * igt@gem_mmap_gtt@medium-copy-xy:shard-iclb: DMESG-WARN (i915#1982) -> PASS
> * igt@gem_mmap_offset@blt-coherency:shard-glk: FAIL (i915#2328) -> PASS
> * igt@gem_userptr_blits@sync-unmap-cycles:shard-skl: TIMEOUT (i915#2424) -> PASS
> * {igt@kms_async_flips@async-flip-with-page-flip-events}:shard-kbl: FAIL (i915#2521) -> PASS
> * igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels@edp-1-pipe-a:shard-skl: DMESG-WARN (i915#1982) -> PASS +4 similar
> issues
> * igt@kms_flip@flip-vs-blocking-wf-vblank@b-edp1:shard-tglb: DMESG-WARN (i915#1982) -> PASS +3 similar issues
> * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:shard-skl: FAIL (i915#2122) -> PASS +1 similar issue
> * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:shard-kbl: DMESG-WARN (i915#180) -> PASS +6 similar issues
> * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:shard-kbl: DMESG-WARN (i915#1982) -> PASS
> * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:shard-skl: INCOMPLETE (i915#198) -> PASS +1 similar issue
> * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:shard-skl: FAIL (fdo#108145 / i915#265) -> PASS
> * igt@kms_psr@psr2_cursor_render:shard-iclb: SKIP (fdo#109441) -> PASS +1 similar issue
> * igt@kms_setmode@basic:shard-apl: FAIL (i915#1635 / i915#31) -> PASS
> * igt@sysfs_timeslice_duration@timeout@vecs0:shard-glk: FAIL (i915#1755) -> PASS
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
> Participating hosts (11 -> 12)Additional (1): pig-snb-2600
> Build changes * Linux: CI_DRM_9097 -> Patchwork_18625
> CI-20190529: 20190529
> CI_DRM_9097: 5f854df6a9500c0888864bb0be25995ccb696e41 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5800: 982ca4122fd4f04ad3dfa80c6246f190b36e0c72 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_18625: 68870e5d103dec6a4a8c09849a771dee2dbd4ecb @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-10-23 21:31 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 23:16 [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications José Roberto de Souza
2020-10-02 23:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-03 1:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-05 18:55 ` Souza, Jose
2020-10-05 19:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications (rev2) Patchwork
2020-10-05 21:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-23 21:31 ` Souza, Jose
2020-10-12 18:12 ` [Intel-gfx] [PATCH] drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications Mun, Gwan-gyeong
2020-10-12 18:15 ` Souza, Jose
2020-10-12 19:04 ` Mun, Gwan-gyeong
2020-10-22 12:43 ` Mun, Gwan-gyeong
2020-10-22 12:48 ` Mun, Gwan-gyeong
2020-10-23 21:27 ` Souza, Jose
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.