All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: dwc3: host: Set the dma_ops for xhci device
@ 2016-06-03 11:50 Baolin Wang
  2016-06-03 12:45 ` kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: Baolin Wang @ 2016-06-03 11:50 UTC (permalink / raw)
  To: balbi, gregkh; +Cc: broonie, linux-usb, linux-kernel, baolin.wang

It will be failed when xhci device set the dma mask, if the xhci device
dma_ops is dummy. Thus set the xhci device dma_ops from the parent device.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
 drivers/usb/dwc3/host.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index c679f63..7ce55c9 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -32,6 +32,9 @@ int dwc3_host_init(struct dwc3 *dwc)
 		return -ENOMEM;
 	}
 
+	if (get_dma_ops(&xhci->dev) == get_dma_ops(NULL))
+		xhci->dev.archdata.dma_ops = get_dma_ops(dwc->dev);
+
 	dma_set_coherent_mask(&xhci->dev, dwc->dev->coherent_dma_mask);
 
 	xhci->dev.parent	= dwc->dev;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: dwc3: host: Set the dma_ops for xhci device
  2016-06-03 11:50 [PATCH] usb: dwc3: host: Set the dma_ops for xhci device Baolin Wang
@ 2016-06-03 12:45 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2016-06-03 12:45 UTC (permalink / raw)
  To: Baolin Wang
  Cc: kbuild-all, balbi, gregkh, broonie, linux-usb, linux-kernel, baolin.wang

[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]

Hi,

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.7-rc1 next-20160603]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Baolin-Wang/usb-dwc3-host-Set-the-dma_ops-for-xhci-device/20160603-195855
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: i386-randconfig-i1-201622 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/usb/dwc3/host.c: In function 'dwc3_host_init':
>> drivers/usb/dwc3/host.c:36:21: error: 'struct dev_archdata' has no member named 'dma_ops'
      xhci->dev.archdata.dma_ops = get_dma_ops(dwc->dev);
                        ^

vim +36 drivers/usb/dwc3/host.c

    30		if (!xhci) {
    31			dev_err(dwc->dev, "couldn't allocate xHCI device\n");
    32			return -ENOMEM;
    33		}
    34	
    35		if (get_dma_ops(&xhci->dev) == get_dma_ops(NULL))
  > 36			xhci->dev.archdata.dma_ops = get_dma_ops(dwc->dev);
    37	
    38		dma_set_coherent_mask(&xhci->dev, dwc->dev->coherent_dma_mask);
    39	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 23709 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-03 12:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-03 11:50 [PATCH] usb: dwc3: host: Set the dma_ops for xhci device Baolin Wang
2016-06-03 12:45 ` kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.