[PATCH 1/1] cpufreq: s5pv210: Fix section mismatch warning

[PATCH 1/1] cpufreq: s5pv210: Fix section mismatch warning

[Sachin Kamat]

struct s5pv210_driver is registered in probe function which
does not have __init annotation. However s5pv210_driver contains
the pointer to s5pv210_cpu_init() which is annotated with __init
which causes the following section mismatch warning:
WARNING: drivers/cpufreq/built-in.o(.data+0xc3c): Section mismatch in reference from the variable s5pv210_driver to the function .init.text:s5pv210_cpu_init()

Fixed by removing the annotation for s5pv210_cpu_init.

Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
---
 drivers/cpufreq/s5pv210-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index 9a68225..3f9791f 100644
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -501,7 +501,7 @@ static int check_mem_type(void __iomem *dmc_reg)
 	return val >> 8;
 }
 
-static int __init s5pv210_cpu_init(struct cpufreq_policy *policy)
+static int s5pv210_cpu_init(struct cpufreq_policy *policy)
 {
 	unsigned long mem_type;
 	int ret;
-- 
1.8.1.2

Re: [PATCH 1/1] cpufreq: s5pv210: Fix section mismatch warning

[Viresh Kumar]

On 1 August 2014 16:44, Sachin Kamat <sachin.kamat@samsung.com> wrote:
> struct s5pv210_driver is registered in probe function which
> does not have __init annotation. However s5pv210_driver contains
> the pointer to s5pv210_cpu_init() which is annotated with __init
> which causes the following section mismatch warning:
> WARNING: drivers/cpufreq/built-in.o(.data+0xc3c): Section mismatch in reference from the variable s5pv210_driver to the function .init.text:s5pv210_cpu_init()
>
> Fixed by removing the annotation for s5pv210_cpu_init.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
>  drivers/cpufreq/s5pv210-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
> index 9a68225..3f9791f 100644
> --- a/drivers/cpufreq/s5pv210-cpufreq.c
> +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> @@ -501,7 +501,7 @@ static int check_mem_type(void __iomem *dmc_reg)
>         return val >> 8;
>  }
>
> -static int __init s5pv210_cpu_init(struct cpufreq_policy *policy)
> +static int s5pv210_cpu_init(struct cpufreq_policy *policy)
>  {
>         unsigned long mem_type;
>         int ret;


Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

RE: [PATCH 1/1] cpufreq: s5pv210: Fix section mismatch warning

[Kukjin Kim]

Viresh Kumar wrote:
> 
> On 1 August 2014 16:44, Sachin Kamat <sachin.kamat@samsung.com> wrote:
> > struct s5pv210_driver is registered in probe function which
> > does not have __init annotation. However s5pv210_driver contains
> > the pointer to s5pv210_cpu_init() which is annotated with __init
> > which causes the following section mismatch warning:
> > WARNING: drivers/cpufreq/built-in.o(.data+0xc3c): Section mismatch in reference from the variable
> s5pv210_driver to the function .init.text:s5pv210_cpu_init()
> >
> > Fixed by removing the annotation for s5pv210_cpu_init.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> > ---
> >  drivers/cpufreq/s5pv210-cpufreq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
> > index 9a68225..3f9791f 100644
> > --- a/drivers/cpufreq/s5pv210-cpufreq.c
> > +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> > @@ -501,7 +501,7 @@ static int check_mem_type(void __iomem *dmc_reg)
> >         return val >> 8;
> >  }
> >
> > -static int __init s5pv210_cpu_init(struct cpufreq_policy *policy)
> > +static int s5pv210_cpu_init(struct cpufreq_policy *policy)
> >  {
> >         unsigned long mem_type;
> >         int ret;
> 
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

OK, I will take this into non-critical-fixes.

Thanks,
Kukjin