Re: [MPTCP] [PATCH 0/16] mptcp: fix checkpatch issues

Re: [MPTCP] [PATCH 0/16] mptcp: fix checkpatch issues

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 2811 bytes --]

Hi Florian,

On 15/06/2019 22:16, Matthieu Baerts wrote:
> Hi Florian,
> 
> On 15/06/2019 21:40, Florian Westphal wrote:
>> Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
>>> These patches simply fix code style reported by checkpatch.pl without
>>> modifying the behaviour of the code.
>>
>> Thanks for doing this, aside from one nit this looks good, feel free
>> to squash as needed.
> 
> Thank you very much for the review!
> 
> I just sent a v2 of the problematic patch. If there is no issue, I will
> squash all of that on Monday!

Thank you again for the review.

I applied the different changes:
- 16a3730b4df2: fix (patch 1) in t/mptcp-Add-MPTCP-socket-stubs
- 96f5a5257e4a: fix (patch 2) in t/mptcp-Handle-MPTCP-TCP-options
- 2cb651944bde: fix (patch 3) in
t/mptcp-Associate-MPTCP-context-with-TCP-socket
- 5dfb458242a4: fix (patch 4) in
t/mptcp-Handle-MP_CAPABLE-options-for-outgoing-connections
- a423084d56c3: - conflict in t/mptcp-add-mptcp_poll
- 340db29a1aca: fix (patch 5) in
t/mptcp-Create-SUBFLOW-socket-for-incoming-connections
- c12ea15b2707: fix (patch 6) in t/mptcp-Add-key-generation-and-token-tree
- 9b073c7163b7: - conflict in t/mptcp-Add-shutdown-socket-operation
- 7235c504b4ce: fix (patch 7) in
t/tcp-Prevent-coalesce-collapse-when-skb-has-MPTCP-extensions
- cc12478c4b12: - conflict in
t/mptcp-Write-MPTCP-DSS-headers-to-outgoing-data-packets
- 233967ed7653: fix (patch 8) in
t/mptcp-Write-MPTCP-DSS-headers-to-outgoing-data-packets
- f2b0032688bd: - conflict in t/mptcp-Implement-MPTCP-receive-path
- 42c068f65a35: fix (patch 9) in t/mptcp-Implement-MPTCP-receive-path
- 46613a7cc813: - conflict in
t/mptcp-Make-connection_list-a-real-list-of-subflows
- b11740209653: fix (patch 10) in
t/mptcp-Make-connection_list-a-real-list-of-subflows
- 08354673fb0f: fix (patch 11) in t/mptcp-add-and-use-mptcp_subflow_hold
- 35db7a5ba485: fix (patch 12) in t/mptcp-add-basic-kselftest-program
- 62e0982a571d: - conflict in
t/mptcp-selftests-switch-to-netns-veth-based-tests
- 69e267369baa: fix (patch 13) in
t/mptcp-selftests-switch-to-netns-veth-based-tests
- a7c01cc82aab: - conflict in
t/mptcp-accept-don-t-leak-mptcp-socket-structure
- 36c1ab20989b: - conflict in
t/mptcp-switch-sublist-to-mptcp-socket-lock-protection
- 7b27fbce2bbd: fix (patch 14) in t/mptcp-Add-path-manager-interface
- ee3a970a11bc: fix (patch 15) in t/mptcp-Add-ADD_ADDR-handling
- 533717289f01: fix (patch 16) in
t/mptcp-Add-handling-of-incoming-MP_JOIN-requests
- 24848c5a886d..a083a2836977: result

With the extra patch I just sent, tests are OK!

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

Re: [MPTCP] [PATCH 0/16] mptcp: fix checkpatch issues

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

Hi Florian,

On 15/06/2019 21:40, Florian Westphal wrote:
> Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
>> These patches simply fix code style reported by checkpatch.pl without
>> modifying the behaviour of the code.
> 
> Thanks for doing this, aside from one nit this looks good, feel free
> to squash as needed.

Thank you very much for the review!

I just sent a v2 of the problematic patch. If there is no issue, I will
squash all of that on Monday!

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

Re: [MPTCP] [PATCH 0/16] mptcp: fix checkpatch issues

[Florian Westphal]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> These patches simply fix code style reported by checkpatch.pl without
> modifying the behaviour of the code.

Thanks for doing this, aside from one nit this looks good, feel free
to squash as needed.

[MPTCP] [PATCH 0/16] mptcp: fix checkpatch issues

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 2132 bytes --]

These patches simply fix code style reported by checkpatch.pl without
modifying the behaviour of the code.

Here are a few points that might be interesting to expose / debate:

- Some warnings have *not* been fixed on purpose:
  - edition in "old" files (in.h, etc.) keeping the same code convension
  - the MAINTAINERS file has not been updated, we will do that later
  - line over 80 characters in shell scripts
  - missing commit description in:
    - mptcp: Add shutdown() socket operation
    - mptcp: Add setsockopt()/getsockopt() socket operations
  - one BUG_ON is in protocol.c, we might want to remove it
- Even if a few lines have been added and removed, I guess we should not
  add a signed-off with my name in all modified topics.

Matthieu Baerts (16):
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues
  mptcp: fix checkpatch issues

 .topmsg                                       |  9 +++++----
 include/net/mptcp.h                           | 10 +++++-----
 net/mptcp/crypto.c                            |  3 +--
 net/mptcp/options.c                           | 17 +++++++++--------
 net/mptcp/pm.c                                |  2 +-
 net/mptcp/protocol.c                          | 33 ++++++++++++++-----------
 net/mptcp/protocol.h                          | 15 ++++++++-------
 net/mptcp/subflow.c                           | 18 +++++++-----------
 net/mptcp/token.c                             | 29 ++++++++++++++---------------
 .../selftests/net/mptcp/mptcp_connect.c       | 86 ++++++++++++++++++++++----------------
 .../selftests/net/mptcp/mptcp_connect.sh      |  1 +
 11 files changed, 119 insertions(+), 104 deletions(-)

-- 
2.20.1