All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>, linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Allison Randal <allison@lohutok.net>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Patrice Chotard <patrice.chotard@st.com>,
	Shah Nehal-Bakulchandra <Nehal-bakulchandra.Shah@amd.com>,
	Tang Bin <tangbin@cmss.chinamobile.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1] i2c: img-scb: remove duplicate dev_err()
Date: Tue, 14 Apr 2020 17:48:41 +0200	[thread overview]
Message-ID: <08564c03-3bbd-5518-1a9d-a40b8ca09f48@web.de> (raw)

> it will print an error message by itself when platform_get_irq()
> goes wrong. so don't need dev_err() in here again.

I suggest to improve the change description.
Can you get any further inspiration by previous patches from
other contributors according to the presented transformation pattern?

Would you like to adjust any more source files in the mentioned
software area?

Regards,
Markus

             reply	other threads:[~2020-04-14 15:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 15:48 Markus Elfring [this message]
2020-04-15  2:54 ` [PATCH v1] i2c: img-scb: remove duplicate dev_err() Dejin Zheng
2020-04-15  5:47   ` Markus Elfring
2020-04-15 15:21     ` Dejin Zheng
2020-04-15 16:24       ` Markus Elfring
2020-04-16  9:46         ` Markus Elfring
2020-04-16  9:46           ` Markus Elfring
2020-04-16 15:34         ` Dejin Zheng
  -- strict thread matches above, loose matches on Subject: below --
2020-04-14 14:26 [PATCH v1] " Dejin Zheng
2020-04-14 14:38 ` Andy Shevchenko
2020-04-14 15:50   ` Dejin Zheng
2020-04-14 16:20     ` Andy Shevchenko
2020-04-14 16:42       ` Wolfram Sang
2020-04-14 16:46         ` Andy Shevchenko
2020-04-14 16:56           ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08564c03-3bbd-5518-1a9d-a40b8ca09f48@web.de \
    --to=markus.elfring@web.de \
    --cc=Nehal-bakulchandra.Shah@amd.com \
    --cc=allison@lohutok.net \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrice.chotard@st.com \
    --cc=tangbin@cmss.chinamobile.com \
    --cc=tglx@linutronix.de \
    --cc=zhengdejin5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.