From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>, linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Allison Randal <allison@lohutok.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Patrice Chotard <patrice.chotard@st.com>,
Shah Nehal-Bakulchandra <Nehal-bakulchandra.Shah@amd.com>,
Tang Bin <tangbin@cmss.chinamobile.com>,
Thomas Gleixner <tglx@linutronix.de>,
Wolfram Sang <wsa@the-dreams.de>,
Thor Thayer <thor.thayer@linux.intel.com>,
Robert Richter <rrichter@marvell.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Barry Song <baohua@kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: i2c: img-scb: remove duplicate dev_err()
Date: Thu, 16 Apr 2020 11:46:45 +0200 [thread overview]
Message-ID: <73cc5a7c-787c-b263-7679-0f1fa58a70f8@web.de> (raw)
In-Reply-To: <668fe4da-56f2-8abe-1113-fa180f307524@web.de>
>>> Would you like to take another look at corresponding change possibilities?
>>>
>> yes, I want to do it and thanks for your info.
How do you think about to improve the clarification around potentially
“odd fixes” (because of collateral evolution)?
I noticed your update suggestion “i2c: busses: convert to devm_platform_ioremap_resource”.
https://lore.kernel.org/linux-i2c/20200409135224.7426-1-zhengdejin5@gmail.com/
https://lore.kernel.org/patchwork/patch/1222122/
https://lkml.org/lkml/2020/4/9/431
It seems that you got encouraged to contribute changes according to another
transformation approach by a single patch for a directory hierarchy.
How likely is it that such adjustments touch source code places
where related error messages would be found for further software
development considerations?
Would you like to wait until the integration of this update succeeded?
Will it be interesting in the meantime to become more familiar with
applications around scripts for the semantic patch language?
Can the Coccinelle software make the discussed transformations more convenient
also for your needs?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>, linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Allison Randal <allison@lohutok.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Patrice Chotard <patrice.chotard@st.com>,
Shah Nehal-Bakulchandra <Nehal-bakulchandra.Shah@amd.com>,
Tang Bin <tangbin@cmss.chinamobile.com>,
Thomas Gleixner <tglx@linutronix.de>,
Wolfram Sang <wsa@the-dreams.de>,
Thor Thayer <thor.thayer@linux.intel.com>,
Robert Richter <rrichter@marvell.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Barry Song <baohua@kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: i2c: img-scb: remove duplicate dev_err()
Date: Thu, 16 Apr 2020 09:46:45 +0000 [thread overview]
Message-ID: <73cc5a7c-787c-b263-7679-0f1fa58a70f8@web.de> (raw)
In-Reply-To: <668fe4da-56f2-8abe-1113-fa180f307524@web.de>
>>> Would you like to take another look at corresponding change possibilities?
>>>
>> yes, I want to do it and thanks for your info.
How do you think about to improve the clarification around potentially
“odd fixes” (because of collateral evolution)?
I noticed your update suggestion “i2c: busses: convert to devm_platform_ioremap_resource”.
https://lore.kernel.org/linux-i2c/20200409135224.7426-1-zhengdejin5@gmail.com/
https://lore.kernel.org/patchwork/patch/1222122/
https://lkml.org/lkml/2020/4/9/431
It seems that you got encouraged to contribute changes according to another
transformation approach by a single patch for a directory hierarchy.
How likely is it that such adjustments touch source code places
where related error messages would be found for further software
development considerations?
Would you like to wait until the integration of this update succeeded?
Will it be interesting in the meantime to become more familiar with
applications around scripts for the semantic patch language?
Can the Coccinelle software make the discussed transformations more convenient
also for your needs?
Regards,
Markus
next prev parent reply other threads:[~2020-04-16 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 15:48 [PATCH v1] i2c: img-scb: remove duplicate dev_err() Markus Elfring
2020-04-15 2:54 ` Dejin Zheng
2020-04-15 5:47 ` Markus Elfring
2020-04-15 15:21 ` Dejin Zheng
2020-04-15 16:24 ` Markus Elfring
2020-04-16 9:46 ` Markus Elfring [this message]
2020-04-16 9:46 ` Markus Elfring
2020-04-16 15:34 ` Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73cc5a7c-787c-b263-7679-0f1fa58a70f8@web.de \
--to=markus.elfring@web.de \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=allison@lohutok.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baohua@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=patrice.chotard@st.com \
--cc=rrichter@marvell.com \
--cc=tangbin@cmss.chinamobile.com \
--cc=tglx@linutronix.de \
--cc=thor.thayer@linux.intel.com \
--cc=wsa@the-dreams.de \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.