* Re: [f2fs:dev-test 17/43] fs/f2fs/segment.c:2422:3: error: label 'out' used but not defined [not found] <201805030856.dxbO5HNd%fengguang.wu@intel.com> @ 2018-05-03 1:37 ` Chao Yu 2018-05-04 19:00 ` Jaegeuk Kim 0 siblings, 1 reply; 2+ messages in thread From: Chao Yu @ 2018-05-03 1:37 UTC (permalink / raw) To: kbuild test robot, Chao Yu, Jaegeuk Kim; +Cc: kbuild-all, linux-f2fs-devel On 2018/5/3 8:51, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test > head: feae4d20e07c14bd416da38bf34b5d18c034b9b5 > commit: 6c55253f427c44da1b7d49592144c13de0274a47 [17/43] f2fs: don't split checkpoint in fstrim > config: x86_64-randconfig-x013-201817 (attached as .config) > compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 > reproduce: > git checkout 6c55253f427c44da1b7d49592144c13de0274a47 > # save the attached .config to linux build tree > make ARCH=x86_64 > > All errors (new ones prefixed by >>): > > fs/f2fs/segment.c: In function 'f2fs_trim_fs': >>> fs/f2fs/segment.c:2422:3: error: label 'out' used but not defined > goto out; > ^~~~ I think there is a conflict when merging another patch "f2fs: correct return value of f2fs_trim_fs" in where we remove the 'out' label, Jaegeuk, could you help to fix it in git tree? Thanks, > > vim +/out +2422 fs/f2fs/segment.c > > 2381 > 2382 int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct fstrim_range *range) > 2383 { > 2384 __u64 start = F2FS_BYTES_TO_BLK(range->start); > 2385 __u64 end = start + F2FS_BYTES_TO_BLK(range->len) - 1; > 2386 unsigned int start_segno, end_segno; > 2387 block_t start_block, end_block; > 2388 struct cp_control cpc; > 2389 struct discard_policy dpolicy; > 2390 unsigned long long trimmed = 0; > 2391 int err = 0; > 2392 > 2393 if (start >= MAX_BLKADDR(sbi) || range->len < sbi->blocksize) > 2394 return -EINVAL; > 2395 > 2396 if (end <= MAIN_BLKADDR(sbi)) > 2397 return -EINVAL; > 2398 > 2399 if (is_sbi_flag_set(sbi, SBI_NEED_FSCK)) { > 2400 f2fs_msg(sbi->sb, KERN_WARNING, > 2401 "Found FS corruption, run fsck to fix."); > 2402 return -EIO; > 2403 } > 2404 > 2405 /* start/end segment number in main_area */ > 2406 start_segno = (start <= MAIN_BLKADDR(sbi)) ? 0 : GET_SEGNO(sbi, start); > 2407 end_segno = (end >= MAX_BLKADDR(sbi)) ? MAIN_SEGS(sbi) - 1 : > 2408 GET_SEGNO(sbi, end); > 2409 > 2410 cpc.reason = CP_DISCARD; > 2411 cpc.trim_minlen = max_t(__u64, 1, F2FS_BYTES_TO_BLK(range->minlen)); > 2412 cpc.trim_start = start_segno; > 2413 cpc.trim_end = end_segno; > 2414 > 2415 if (sbi->discard_blks == 0) > 2416 goto out; > 2417 > 2418 mutex_lock(&sbi->gc_mutex); > 2419 err = write_checkpoint(sbi, &cpc); > 2420 mutex_unlock(&sbi->gc_mutex); > 2421 if (err) >> 2422 goto out; > 2423 > 2424 start_block = START_BLOCK(sbi, start_segno); > 2425 end_block = START_BLOCK(sbi, end_segno + 1); > 2426 > 2427 init_discard_policy(&dpolicy, DPOLICY_FSTRIM, cpc.trim_minlen); > 2428 __issue_discard_cmd_range(sbi, &dpolicy, start_block, end_block); > 2429 trimmed = __wait_discard_cmd_range(sbi, &dpolicy, > 2430 start_block, end_block); > 2431 range->len = F2FS_BLK_TO_BYTES(trimmed); > 2432 return err; > 2433 } > 2434 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [f2fs:dev-test 17/43] fs/f2fs/segment.c:2422:3: error: label 'out' used but not defined 2018-05-03 1:37 ` [f2fs:dev-test 17/43] fs/f2fs/segment.c:2422:3: error: label 'out' used but not defined Chao Yu @ 2018-05-04 19:00 ` Jaegeuk Kim 0 siblings, 0 replies; 2+ messages in thread From: Jaegeuk Kim @ 2018-05-04 19:00 UTC (permalink / raw) To: Chao Yu; +Cc: linux-f2fs-devel, kbuild test robot, kbuild-all On 05/03, Chao Yu wrote: > On 2018/5/3 8:51, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test > > head: feae4d20e07c14bd416da38bf34b5d18c034b9b5 > > commit: 6c55253f427c44da1b7d49592144c13de0274a47 [17/43] f2fs: don't split checkpoint in fstrim > > config: x86_64-randconfig-x013-201817 (attached as .config) > > compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 > > reproduce: > > git checkout 6c55253f427c44da1b7d49592144c13de0274a47 > > # save the attached .config to linux build tree > > make ARCH=x86_64 > > > > All errors (new ones prefixed by >>): > > > > fs/f2fs/segment.c: In function 'f2fs_trim_fs': > >>> fs/f2fs/segment.c:2422:3: error: label 'out' used but not defined > > goto out; > > ^~~~ > > I think there is a conflict when merging another patch "f2fs: correct return > value of f2fs_trim_fs" in where we remove the 'out' label, Jaegeuk, could you > help to fix it in git tree? I think I did. Thanks, > > Thanks, > > > > > vim +/out +2422 fs/f2fs/segment.c > > > > 2381 > > 2382 int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct fstrim_range *range) > > 2383 { > > 2384 __u64 start = F2FS_BYTES_TO_BLK(range->start); > > 2385 __u64 end = start + F2FS_BYTES_TO_BLK(range->len) - 1; > > 2386 unsigned int start_segno, end_segno; > > 2387 block_t start_block, end_block; > > 2388 struct cp_control cpc; > > 2389 struct discard_policy dpolicy; > > 2390 unsigned long long trimmed = 0; > > 2391 int err = 0; > > 2392 > > 2393 if (start >= MAX_BLKADDR(sbi) || range->len < sbi->blocksize) > > 2394 return -EINVAL; > > 2395 > > 2396 if (end <= MAIN_BLKADDR(sbi)) > > 2397 return -EINVAL; > > 2398 > > 2399 if (is_sbi_flag_set(sbi, SBI_NEED_FSCK)) { > > 2400 f2fs_msg(sbi->sb, KERN_WARNING, > > 2401 "Found FS corruption, run fsck to fix."); > > 2402 return -EIO; > > 2403 } > > 2404 > > 2405 /* start/end segment number in main_area */ > > 2406 start_segno = (start <= MAIN_BLKADDR(sbi)) ? 0 : GET_SEGNO(sbi, start); > > 2407 end_segno = (end >= MAX_BLKADDR(sbi)) ? MAIN_SEGS(sbi) - 1 : > > 2408 GET_SEGNO(sbi, end); > > 2409 > > 2410 cpc.reason = CP_DISCARD; > > 2411 cpc.trim_minlen = max_t(__u64, 1, F2FS_BYTES_TO_BLK(range->minlen)); > > 2412 cpc.trim_start = start_segno; > > 2413 cpc.trim_end = end_segno; > > 2414 > > 2415 if (sbi->discard_blks == 0) > > 2416 goto out; > > 2417 > > 2418 mutex_lock(&sbi->gc_mutex); > > 2419 err = write_checkpoint(sbi, &cpc); > > 2420 mutex_unlock(&sbi->gc_mutex); > > 2421 if (err) > >> 2422 goto out; > > 2423 > > 2424 start_block = START_BLOCK(sbi, start_segno); > > 2425 end_block = START_BLOCK(sbi, end_segno + 1); > > 2426 > > 2427 init_discard_policy(&dpolicy, DPOLICY_FSTRIM, cpc.trim_minlen); > > 2428 __issue_discard_cmd_range(sbi, &dpolicy, start_block, end_block); > > 2429 trimmed = __wait_discard_cmd_range(sbi, &dpolicy, > > 2430 start_block, end_block); > > 2431 range->len = F2FS_BLK_TO_BYTES(trimmed); > > 2432 return err; > > 2433 } > > 2434 > > > > --- > > 0-DAY kernel test infrastructure Open Source Technology Center > > https://lists.01.org/pipermail/kbuild-all Intel Corporation > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-04 19:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201805030856.dxbO5HNd%fengguang.wu@intel.com>
2018-05-03 1:37 ` [f2fs:dev-test 17/43] fs/f2fs/segment.c:2422:3: error: label 'out' used but not defined Chao Yu
2018-05-04 19:00 ` Jaegeuk Kim
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.