All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Tao Ren <rentao.bupt@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
	Jean Delvare <jdelvare@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	"David S . Miller" <davem@davemloft.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org, openbmc@lists.ozlabs.org, taoren@fb.com,
	mikechoi@fb.com
Subject: Re: XDP maintainer match (Was  [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring)
Date: Thu, 19 Nov 2020 09:09:53 -0800	[thread overview]
Message-ID: <088057533a9feb330964bdab0b1b8d2f69b7a22c.camel@perches.com> (raw)
In-Reply-To: <20201119173535.1474743d@carbon>

On Thu, 2020-11-19 at 17:35 +0100, Jesper Dangaard Brouer wrote:
> On Thu, 19 Nov 2020 07:46:34 -0800 Jakub Kicinski <kuba@kernel.org> wrote:

> I think it is a good idea to change the keyword (K:), but I'm not sure
> this catch what we want, maybe it does.  The pattern match are meant to
> catch drivers containing XDP related bits.
> 
> Previously Joe Perches <joe@perches.com> suggested this pattern match,
> which I don't fully understand... could you explain Joe?
> 
>   (?:\b|_)xdp(?:\b|_)

This regex matches only:

	xdp
	xdp_<anything>
	<anything>_xdp_<anything>
	<anything>_xdp

> For the filename (N:) regex match, I'm considering if we should remove
> it and list more files explicitly.  I think normal glob * pattern
> works, which should be sufficient.

Lists are generally more specific than regex globs.



WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
	Jakub Kicinski <kuba@kernel.org>
Cc: linux-hwmon@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Jean Delvare <jdelvare@suse.com>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jonathan Corbet <corbet@lwn.net>,
	netdev@vger.kernel.org, openbmc@lists.ozlabs.org,
	linux-doc@vger.kernel.org,
	John Fastabend <john.fastabend@gmail.com>,
	Alexei Starovoitov <ast@kernel.org>,
	linux-kernel@vger.kernel.org, taoren@fb.com,
	Tao Ren <rentao.bupt@gmail.com>,
	bpf@vger.kernel.org, mikechoi@fb.com,
	"David S . Miller" <davem@davemloft.net>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: XDP maintainer match (Was  [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring)
Date: Thu, 19 Nov 2020 09:09:53 -0800	[thread overview]
Message-ID: <088057533a9feb330964bdab0b1b8d2f69b7a22c.camel@perches.com> (raw)
In-Reply-To: <20201119173535.1474743d@carbon>

On Thu, 2020-11-19 at 17:35 +0100, Jesper Dangaard Brouer wrote:
> On Thu, 19 Nov 2020 07:46:34 -0800 Jakub Kicinski <kuba@kernel.org> wrote:

> I think it is a good idea to change the keyword (K:), but I'm not sure
> this catch what we want, maybe it does.  The pattern match are meant to
> catch drivers containing XDP related bits.
> 
> Previously Joe Perches <joe@perches.com> suggested this pattern match,
> which I don't fully understand... could you explain Joe?
> 
>   (?:\b|_)xdp(?:\b|_)

This regex matches only:

	xdp
	xdp_<anything>
	<anything>_xdp_<anything>
	<anything>_xdp

> For the filename (N:) regex match, I'm considering if we should remove
> it and list more files explicitly.  I think normal glob * pattern
> works, which should be sufficient.

Lists are generally more specific than regex globs.



  reply	other threads:[~2020-11-19 17:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18 23:09 [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring rentao.bupt
2020-11-18 23:09 ` [PATCH v2 1/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring driver rentao.bupt
2020-11-18 23:09 ` [PATCH v2 2/2] docs: hwmon: Document max127 driver rentao.bupt
2020-11-18 23:27 ` [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring Andrew Lunn
2020-11-18 23:27   ` Andrew Lunn
2020-11-18 23:42   ` Tao Ren
2020-11-18 23:42     ` Tao Ren
2020-11-19  1:01     ` Guenter Roeck
2020-11-19  1:01       ` Guenter Roeck
2020-11-19  1:26       ` Guenter Roeck
2020-11-19  1:26         ` Guenter Roeck
2020-11-19  7:22         ` Tao Ren
2020-11-19  7:22           ` Tao Ren
2020-11-19 15:46         ` Jakub Kicinski
2020-11-19 15:46           ` Jakub Kicinski
2020-11-19 16:35           ` XDP maintainer match (Was [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring) Jesper Dangaard Brouer
2020-11-19 16:35             ` Jesper Dangaard Brouer
2020-11-19 17:09             ` Joe Perches [this message]
2020-11-19 17:09               ` Joe Perches
2020-11-19 17:59               ` Jakub Kicinski
2020-11-19 17:59                 ` Jakub Kicinski
2020-11-19 20:41                 ` Jesper Dangaard Brouer
2020-11-19 20:41                   ` Jesper Dangaard Brouer
2020-11-19 16:36           ` [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring Alexei Starovoitov
2020-11-19 16:36             ` Alexei Starovoitov
2020-11-19  1:28     ` Andrew Lunn
2020-11-19  1:28       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=088057533a9feb330964bdab0b1b8d2f69b7a22c.camel@perches.com \
    --to=joe@perches.com \
    --cc=andrew@lunn.ch \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=jdelvare@suse.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mikechoi@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=rentao.bupt@gmail.com \
    --cc=taoren@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.