All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrice Chotard <patrice.chotard@st.com>
To: Peter Griffin <peter.griffin@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <kernel@stlinux.com>,
	<mchehab@kernel.org>
Cc: <lee.jones@linaro.org>, <linux-media@vger.kernel.org>
Subject: Re: [PATCH] [media] c8sectpfe: Remove clk_disable_unprepare hacks
Date: Fri, 21 Oct 2016 14:23:46 +0200	[thread overview]
Message-ID: <08965415-3573-c588-25c8-ae48fde9470f@st.com> (raw)
In-Reply-To: <1477040132-31442-1-git-send-email-peter.griffin@linaro.org>

On 10/21/2016 10:55 AM, Peter Griffin wrote:
> Now that CLK_PROC_STFE is defined as a critical clock in
> DT, we can remove the commented clk_disable_unprepare from
> the c8sectpfe driver. This means we now have balanced
> clk*enable/disable calls in the driver, but on STiH407
> family the clock in reality will never actually be disabled.
> 
> This is due to a HW bug where once the IP has been configured
> and the SLIM core is running, disabling the clock causes a
> unrecoverable bus lockup.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index 30c148b..79d793b 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -888,8 +888,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
>  	return 0;
>  
>  err_clk_disable:
> -	/* TODO uncomment when upstream has taken a reference on this clk */
> -	/*clk_disable_unprepare(fei->c8sectpfeclk);*/
> +	clk_disable_unprepare(fei->c8sectpfeclk);
>  	return ret;
>  }
>  
> @@ -924,11 +923,8 @@ static int c8sectpfe_remove(struct platform_device *pdev)
>  	if (readl(fei->io + SYS_OTHER_CLKEN))
>  		writel(0, fei->io + SYS_OTHER_CLKEN);
>  
> -	/* TODO uncomment when upstream has taken a reference on this clk */
> -	/*
>  	if (fei->c8sectpfeclk)
>  		clk_disable_unprepare(fei->c8sectpfeclk);
> -	*/
>  
>  	return 0;
>  }
> 

Acked-by: Patrice Chotard <patrice.chotard@st.com>

WARNING: multiple messages have this Message-ID (diff)
From: patrice.chotard@st.com (Patrice Chotard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [media] c8sectpfe: Remove clk_disable_unprepare hacks
Date: Fri, 21 Oct 2016 14:23:46 +0200	[thread overview]
Message-ID: <08965415-3573-c588-25c8-ae48fde9470f@st.com> (raw)
In-Reply-To: <1477040132-31442-1-git-send-email-peter.griffin@linaro.org>

On 10/21/2016 10:55 AM, Peter Griffin wrote:
> Now that CLK_PROC_STFE is defined as a critical clock in
> DT, we can remove the commented clk_disable_unprepare from
> the c8sectpfe driver. This means we now have balanced
> clk*enable/disable calls in the driver, but on STiH407
> family the clock in reality will never actually be disabled.
> 
> This is due to a HW bug where once the IP has been configured
> and the SLIM core is running, disabling the clock causes a
> unrecoverable bus lockup.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index 30c148b..79d793b 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -888,8 +888,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
>  	return 0;
>  
>  err_clk_disable:
> -	/* TODO uncomment when upstream has taken a reference on this clk */
> -	/*clk_disable_unprepare(fei->c8sectpfeclk);*/
> +	clk_disable_unprepare(fei->c8sectpfeclk);
>  	return ret;
>  }
>  
> @@ -924,11 +923,8 @@ static int c8sectpfe_remove(struct platform_device *pdev)
>  	if (readl(fei->io + SYS_OTHER_CLKEN))
>  		writel(0, fei->io + SYS_OTHER_CLKEN);
>  
> -	/* TODO uncomment when upstream has taken a reference on this clk */
> -	/*
>  	if (fei->c8sectpfeclk)
>  		clk_disable_unprepare(fei->c8sectpfeclk);
> -	*/
>  
>  	return 0;
>  }
> 

Acked-by: Patrice Chotard <patrice.chotard@st.com>

  reply	other threads:[~2016-10-21 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  8:55 [PATCH] [media] c8sectpfe: Remove clk_disable_unprepare hacks Peter Griffin
2016-10-21  8:55 ` Peter Griffin
2016-10-21 12:23 ` Patrice Chotard [this message]
2016-10-21 12:23   ` Patrice Chotard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08965415-3573-c588-25c8-ae48fde9470f@st.com \
    --to=patrice.chotard@st.com \
    --cc=kernel@stlinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=peter.griffin@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.