* Re: [Qemu-devel] [PATCH] mttcg: Move tb lock asserts under DEBUG_LOCKING
[not found] <20161115054135.12195-1-bobby.prani@gmail.com>
@ 2016-11-15 7:48 ` Richard Henderson
2016-11-15 15:10 ` Pranith Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Richard Henderson @ 2016-11-15 7:48 UTC (permalink / raw)
To: Pranith Kumar, Paolo Bonzini, Peter Crosthwaite, open list:Overall
On 11/15/2016 06:41 AM, Pranith Kumar wrote:
> Move the asserts in tb_lock/unlock() to DEBUG_LOCKING to avoid the
> assert checking overhead in normal builds.
I know DEBUG_LOCKING already exists in translate-all.c, but I think both this
and the old ought to be using CONFIG_DEBUG_TCG, so that it is regularly enabled.
At which point you might as well use tcg_debug_assert instead of these wrappers
around g_assert.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] mttcg: Move tb lock asserts under DEBUG_LOCKING
2016-11-15 7:48 ` [Qemu-devel] [PATCH] mttcg: Move tb lock asserts under DEBUG_LOCKING Richard Henderson
@ 2016-11-15 15:10 ` Pranith Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Pranith Kumar @ 2016-11-15 15:10 UTC (permalink / raw)
To: Richard Henderson; +Cc: Paolo Bonzini, Peter Crosthwaite, open list:Overall
On Tue, Nov 15, 2016 at 2:48 AM, Richard Henderson <rth@twiddle.net> wrote:
> On 11/15/2016 06:41 AM, Pranith Kumar wrote:
>>
>> Move the asserts in tb_lock/unlock() to DEBUG_LOCKING to avoid the
>> assert checking overhead in normal builds.
>
>
> I know DEBUG_LOCKING already exists in translate-all.c, but I think both
> this and the old ought to be using CONFIG_DEBUG_TCG, so that it is regularly
> enabled.
>
> At which point you might as well use tcg_debug_assert instead of these
> wrappers around g_assert.
>
Yes, that sounds more reasonable. I will work up a patch.
Thanks,
--
Pranith
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-15 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20161115054135.12195-1-bobby.prani@gmail.com>
2016-11-15 7:48 ` [Qemu-devel] [PATCH] mttcg: Move tb lock asserts under DEBUG_LOCKING Richard Henderson
2016-11-15 15:10 ` Pranith Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.