* [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m
@ 2018-04-14 14:27 Michael Tokarev
2018-04-16 2:50 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2018-04-16 9:26 ` [Qemu-devel] " Peter Maydell
0 siblings, 2 replies; 4+ messages in thread
From: Michael Tokarev @ 2018-04-14 14:27 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael Tokarev, qemu-trivial
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 727ef118f3..8644c2e918 100644
--- a/Makefile
+++ b/Makefile
@@ -856,7 +856,7 @@ ifneq ($(BLOBS),)
$(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$x "$(DESTDIR)$(qemu_datadir)"; \
done
endif
-ifeq ($(CONFIG_GTK),m)
+ifneq ($(filter $(CONFIG_GTK),y m),)
$(MAKE) -C po $@
endif
$(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/keymaps"
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m
2018-04-14 14:27 [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m Michael Tokarev
@ 2018-04-16 2:50 ` Philippe Mathieu-Daudé
2018-04-16 9:26 ` [Qemu-devel] " Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-04-16 2:50 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel; +Cc: qemu-trivial
Hi Michael,
On 04/14/2018 11:27 AM, Michael Tokarev wrote:
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 727ef118f3..8644c2e918 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -856,7 +856,7 @@ ifneq ($(BLOBS),)
> $(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$x "$(DESTDIR)$(qemu_datadir)"; \
> done
> endif
> -ifeq ($(CONFIG_GTK),m)
> +ifneq ($(filter $(CONFIG_GTK),y m),)
Or simply:
ifdef CONFIG_GTK
> $(MAKE) -C po $@
> endif
> $(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/keymaps"
>
Regards,
Phil.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m
2018-04-14 14:27 [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m Michael Tokarev
2018-04-16 2:50 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
@ 2018-04-16 9:26 ` Peter Maydell
2018-04-16 9:37 ` Michael Tokarev
1 sibling, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2018-04-16 9:26 UTC (permalink / raw)
To: Michael Tokarev; +Cc: QEMU Developers, QEMU Trivial
On 14 April 2018 at 15:27, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 727ef118f3..8644c2e918 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -856,7 +856,7 @@ ifneq ($(BLOBS),)
> $(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$x "$(DESTDIR)$(qemu_datadir)"; \
> done
> endif
> -ifeq ($(CONFIG_GTK),m)
> +ifneq ($(filter $(CONFIG_GTK),y m),)
> $(MAKE) -C po $@
> endif
> $(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/keymaps"
> --
> 2.11.0
"trivial" and "for 2.12" don't make much sense together at this point in
the release cycle. Is this important enough to go into rc4, or not?
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m
2018-04-16 9:26 ` [Qemu-devel] " Peter Maydell
@ 2018-04-16 9:37 ` Michael Tokarev
0 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2018-04-16 9:37 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers, QEMU Trivial
16.04.2018 12:26, Peter Maydell wrote:
> On 14 April 2018 at 15:27, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> -ifeq ($(CONFIG_GTK),m)
>> +ifneq ($(filter $(CONFIG_GTK),y m),)
>> $(MAKE) -C po $@
>> endif
> "trivial" and "for 2.12" don't make much sense together at this point in
> the release cycle. Is this important enough to go into rc4, or not?
Well, without this, gtk translations wont be installed. Not a huge issue,
especially for the languages where qemu lacks translations, but I still
think it is important enough to go to 2.12, or else it'll be a regression.
I've just sent another, simpler version of the same thing.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-16 9:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-14 14:27 [Qemu-devel] [PATCH trivial for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m Michael Tokarev
2018-04-16 2:50 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2018-04-16 9:26 ` [Qemu-devel] " Peter Maydell
2018-04-16 9:37 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.