All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Wim Van Sebroeck <wim@iguana.be>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data
Date: Tue, 14 Mar 2017 06:47:26 -0700	[thread overview]
Message-ID: <08e02fbe-a059-fae9-ad08-ccd32a9602a7@roeck-us.net> (raw)
In-Reply-To: <CAJKOXPeoHVECsyT+Jy4D3bCwed2gsiKq3akMcDGNKTvrVbcEUg@mail.gmail.com>

On 03/14/2017 06:20 AM, Krzysztof Kozlowski wrote:
> On Tue, Mar 14, 2017 at 3:17 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
>>
>> Hi,
>>
>> On Monday, March 13, 2017 09:07:25 PM Krzysztof Kozlowski wrote:
>>> Simplify the flow in helper function for getting the driver data by
>>> using of_device_get_match_data() and only one if() branch.
>>>
>>> The code should be equivalent.
>>
>> While you are at it could you remove s3c2410_get_wdt_drv_data()
>> helper?  It is used only once during probe and is marked inline
>> anyway..
>
> Thanks for feedback!
> The existence of this helper is purely from code readability (thus
> inline does not matter). The probe is big so splitting some small
> self-contained part helps. Not much but a little...
>

Agreed. I don't see value in removing this helper.

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data
Date: Tue, 14 Mar 2017 06:47:26 -0700	[thread overview]
Message-ID: <08e02fbe-a059-fae9-ad08-ccd32a9602a7@roeck-us.net> (raw)
In-Reply-To: <CAJKOXPeoHVECsyT+Jy4D3bCwed2gsiKq3akMcDGNKTvrVbcEUg@mail.gmail.com>

On 03/14/2017 06:20 AM, Krzysztof Kozlowski wrote:
> On Tue, Mar 14, 2017 at 3:17 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
>>
>> Hi,
>>
>> On Monday, March 13, 2017 09:07:25 PM Krzysztof Kozlowski wrote:
>>> Simplify the flow in helper function for getting the driver data by
>>> using of_device_get_match_data() and only one if() branch.
>>>
>>> The code should be equivalent.
>>
>> While you are at it could you remove s3c2410_get_wdt_drv_data()
>> helper?  It is used only once during probe and is marked inline
>> anyway..
>
> Thanks for feedback!
> The existence of this helper is purely from code readability (thus
> inline does not matter). The probe is big so splitting some small
> self-contained part helps. Not much but a little...
>

Agreed. I don't see value in removing this helper.

Guenter

  reply	other threads:[~2017-03-14 13:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 19:07 [PATCH v3 0/3] watchdog: s3c2410: Minor cleanups Krzysztof Kozlowski
2017-03-13 19:07 ` Krzysztof Kozlowski
2017-03-13 19:07 ` Krzysztof Kozlowski
2017-03-13 19:07 ` [PATCH v3 1/3] watchdog: s3c2410: Constify local structures Krzysztof Kozlowski
2017-03-13 19:07   ` Krzysztof Kozlowski
     [not found]   ` <CGME20170314131158epcas5p3ca1212cc3ce89b0666cafc3aaa87fb78@epcas5p3.samsung.com>
2017-03-14 13:11     ` Bartlomiej Zolnierkiewicz
2017-03-14 13:11       ` Bartlomiej Zolnierkiewicz
2017-03-14 13:11       ` Bartlomiej Zolnierkiewicz
2017-03-14 13:47   ` Guenter Roeck
2017-03-14 13:47     ` Guenter Roeck
2017-03-14 13:47     ` Guenter Roeck
2017-03-13 19:07 ` [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data Krzysztof Kozlowski
2017-03-13 19:07   ` Krzysztof Kozlowski
2017-03-13 19:07   ` Krzysztof Kozlowski
     [not found]   ` <CGME20170314131709epcas5p4e150e0df2a04a3369edf61b2075e2e8f@epcas5p4.samsung.com>
2017-03-14 13:17     ` Bartlomiej Zolnierkiewicz
2017-03-14 13:17       ` Bartlomiej Zolnierkiewicz
2017-03-14 13:17       ` Bartlomiej Zolnierkiewicz
2017-03-14 13:20       ` Krzysztof Kozlowski
2017-03-14 13:20         ` Krzysztof Kozlowski
2017-03-14 13:47         ` Guenter Roeck [this message]
2017-03-14 13:47           ` Guenter Roeck
2017-03-14 13:48   ` Guenter Roeck
2017-03-14 13:48     ` Guenter Roeck
2017-03-13 19:07 ` [PATCH v3 3/3] watchdog: s3c2410: Minor code cleanup Krzysztof Kozlowski
2017-03-13 19:07   ` Krzysztof Kozlowski
     [not found]   ` <CGME20170314132022epcas1p26da7dbe4da6d77ebfc1a8e045ee370de@epcas1p2.samsung.com>
2017-03-14 13:20     ` Bartlomiej Zolnierkiewicz
2017-03-14 13:20       ` Bartlomiej Zolnierkiewicz
2017-03-14 13:49   ` Guenter Roeck
2017-03-14 13:49     ` Guenter Roeck
2017-03-14 13:49     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08e02fbe-a059-fae9-ad08-ccd32a9602a7@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=b.zolnierkie@samsung.com \
    --cc=javier@osg.samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.