* [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only
@ 2021-03-05 15:24 Rafał Miłecki
2021-03-05 16:53 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rafał Miłecki @ 2021-03-05 15:24 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul
Cc: linux-phy, Álvaro Fernández Rojas, Simon Arlott,
Florian Fainelli, bcm-kernel-feedback-list,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
phy-brcm-usb has some conditional init code required on selected brcmstb
devices. Execution of that code depends on family / product detected by
brcmstb soc code.
For ARCH_BCM4908 brcmstb soc code always return 0 values as ids. Don't
bother selecting & compiling that redundant driver.
Depends-on: 149ae80b1d50 ("soc: bcm: brcmstb: add stubs for getting platform IDs")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/phy/broadcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
index 09256339bd04..fd92b73b7109 100644
--- a/drivers/phy/broadcom/Kconfig
+++ b/drivers/phy/broadcom/Kconfig
@@ -94,7 +94,7 @@ config PHY_BRCM_USB
depends on ARCH_BCM4908 || ARCH_BRCMSTB || COMPILE_TEST
depends on OF
select GENERIC_PHY
- select SOC_BRCMSTB
+ select SOC_BRCMSTB if ARCH_BRCMSTB
default ARCH_BCM4908
default ARCH_BRCMSTB
help
--
2.26.2
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only
2021-03-05 15:24 [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only Rafał Miłecki
@ 2021-03-05 16:53 ` Florian Fainelli
2021-03-05 17:15 ` Rafał Miłecki
2021-03-15 10:28 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-03-05 16:53 UTC (permalink / raw)
To: Rafał Miłecki, Kishon Vijay Abraham I, Vinod Koul
Cc: linux-phy, Álvaro Fernández Rojas, Simon Arlott,
bcm-kernel-feedback-list, Rafał Miłecki
On 3/5/2021 07:24, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> phy-brcm-usb has some conditional init code required on selected brcmstb
> devices. Execution of that code depends on family / product detected by
> brcmstb soc code.
>
> For ARCH_BCM4908 brcmstb soc code always return 0 values as ids. Don't
> bother selecting & compiling that redundant driver.
>
> Depends-on: 149ae80b1d50 ("soc: bcm: brcmstb: add stubs for getting platform IDs")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only
2021-03-05 15:24 [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only Rafał Miłecki
2021-03-05 16:53 ` Florian Fainelli
@ 2021-03-05 17:15 ` Rafał Miłecki
2021-03-15 10:28 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Rafał Miłecki @ 2021-03-05 17:15 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul
Cc: linux-phy, Álvaro Fernández Rojas, Simon Arlott,
Florian Fainelli, bcm-kernel-feedback-list,
Rafał Miłecki
Sending reply-to-all after subscribing to the linux-phy@ ML.
On 05.03.2021 16:24, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> phy-brcm-usb has some conditional init code required on selected brcmstb
> devices. Execution of that code depends on family / product detected by
> brcmstb soc code.
>
> For ARCH_BCM4908 brcmstb soc code always return 0 values as ids. Don't
> bother selecting & compiling that redundant driver.
>
> Depends-on: 149ae80b1d50 ("soc: bcm: brcmstb: add stubs for getting platform IDs")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> drivers/phy/broadcom/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
> index 09256339bd04..fd92b73b7109 100644
> --- a/drivers/phy/broadcom/Kconfig
> +++ b/drivers/phy/broadcom/Kconfig
> @@ -94,7 +94,7 @@ config PHY_BRCM_USB
> depends on ARCH_BCM4908 || ARCH_BRCMSTB || COMPILE_TEST
> depends on OF
> select GENERIC_PHY
> - select SOC_BRCMSTB
> + select SOC_BRCMSTB if ARCH_BRCMSTB
> default ARCH_BCM4908
> default ARCH_BRCMSTB
> help
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only
2021-03-05 15:24 [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only Rafał Miłecki
2021-03-05 16:53 ` Florian Fainelli
2021-03-05 17:15 ` Rafał Miłecki
@ 2021-03-15 10:28 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-03-15 10:28 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Kishon Vijay Abraham I, linux-phy,
Álvaro Fernández Rojas, Simon Arlott, Florian Fainelli,
bcm-kernel-feedback-list, Rafał Miłecki
On 05-03-21, 16:24, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> phy-brcm-usb has some conditional init code required on selected brcmstb
> devices. Execution of that code depends on family / product detected by
> brcmstb soc code.
>
> For ARCH_BCM4908 brcmstb soc code always return 0 values as ids. Don't
> bother selecting & compiling that redundant driver.
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-15 10:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 15:24 [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only Rafał Miłecki
2021-03-05 16:53 ` Florian Fainelli
2021-03-05 17:15 ` Rafał Miłecki
2021-03-15 10:28 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.