* [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name
@ 2021-02-09 15:57 Thomas Huth
2021-02-09 16:55 ` David Hildenbrand
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2021-02-09 15:57 UTC (permalink / raw)
To: kvm, Janosch Frank; +Cc: linux-s390, David Hildenbrand, Cornelia Huck
sizeof(somepointer) results in the size of the pointer, i.e. 8 on a
64-bit system, so the
memcmp(data->ext_names[0], vm_name_ext, sizeof(vm_name_ext))
only compared the first 8 characters of the VM name here. Switch
to a proper array to get the sizeof() right.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
s390x/stsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/s390x/stsi.c b/s390x/stsi.c
index 4109b8d..87d4804 100644
--- a/s390x/stsi.c
+++ b/s390x/stsi.c
@@ -106,7 +106,7 @@ static void test_3_2_2(void)
0x00, 0x03 };
/* EBCDIC for "KVM/" */
const uint8_t cpi_kvm[] = { 0xd2, 0xe5, 0xd4, 0x61 };
- const char *vm_name_ext = "kvm-unit-test";
+ const char vm_name_ext[] = "kvm-unit-test";
struct stsi_322 *data = (void *)pagebuf;
report_prefix_push("3.2.2");
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name
2021-02-09 15:57 [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name Thomas Huth
@ 2021-02-09 16:55 ` David Hildenbrand
2021-02-10 7:55 ` Janosch Frank
2021-02-10 11:05 ` Cornelia Huck
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2021-02-09 16:55 UTC (permalink / raw)
To: Thomas Huth, kvm, Janosch Frank; +Cc: linux-s390, Cornelia Huck
On 09.02.21 16:57, Thomas Huth wrote:
> sizeof(somepointer) results in the size of the pointer, i.e. 8 on a
> 64-bit system, so the
>
> memcmp(data->ext_names[0], vm_name_ext, sizeof(vm_name_ext))
>
> only compared the first 8 characters of the VM name here. Switch
> to a proper array to get the sizeof() right.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> s390x/stsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/s390x/stsi.c b/s390x/stsi.c
> index 4109b8d..87d4804 100644
> --- a/s390x/stsi.c
> +++ b/s390x/stsi.c
> @@ -106,7 +106,7 @@ static void test_3_2_2(void)
> 0x00, 0x03 };
> /* EBCDIC for "KVM/" */
> const uint8_t cpi_kvm[] = { 0xd2, 0xe5, 0xd4, 0x61 };
> - const char *vm_name_ext = "kvm-unit-test";
> + const char vm_name_ext[] = "kvm-unit-test";
> struct stsi_322 *data = (void *)pagebuf;
>
> report_prefix_push("3.2.2");
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name
2021-02-09 15:57 [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name Thomas Huth
2021-02-09 16:55 ` David Hildenbrand
@ 2021-02-10 7:55 ` Janosch Frank
2021-02-10 11:05 ` Cornelia Huck
2 siblings, 0 replies; 4+ messages in thread
From: Janosch Frank @ 2021-02-10 7:55 UTC (permalink / raw)
To: Thomas Huth, kvm; +Cc: linux-s390, David Hildenbrand, Cornelia Huck
On 2/9/21 4:57 PM, Thomas Huth wrote:
> sizeof(somepointer) results in the size of the pointer, i.e. 8 on a
> 64-bit system, so the
>
> memcmp(data->ext_names[0], vm_name_ext, sizeof(vm_name_ext))
>
> only compared the first 8 characters of the VM name here. Switch
> to a proper array to get the sizeof() right.
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> s390x/stsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/s390x/stsi.c b/s390x/stsi.c
> index 4109b8d..87d4804 100644
> --- a/s390x/stsi.c
> +++ b/s390x/stsi.c
> @@ -106,7 +106,7 @@ static void test_3_2_2(void)
> 0x00, 0x03 };
> /* EBCDIC for "KVM/" */
> const uint8_t cpi_kvm[] = { 0xd2, 0xe5, 0xd4, 0x61 };
> - const char *vm_name_ext = "kvm-unit-test";
> + const char vm_name_ext[] = "kvm-unit-test";
> struct stsi_322 *data = (void *)pagebuf;
>
> report_prefix_push("3.2.2");
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name
2021-02-09 15:57 [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name Thomas Huth
2021-02-09 16:55 ` David Hildenbrand
2021-02-10 7:55 ` Janosch Frank
@ 2021-02-10 11:05 ` Cornelia Huck
2 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2021-02-10 11:05 UTC (permalink / raw)
To: Thomas Huth; +Cc: kvm, Janosch Frank, linux-s390, David Hildenbrand
On Tue, 9 Feb 2021 16:57:05 +0100
Thomas Huth <thuth@redhat.com> wrote:
> sizeof(somepointer) results in the size of the pointer, i.e. 8 on a
> 64-bit system, so the
>
> memcmp(data->ext_names[0], vm_name_ext, sizeof(vm_name_ext))
>
> only compared the first 8 characters of the VM name here. Switch
> to a proper array to get the sizeof() right.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> s390x/stsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-10 11:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 15:57 [kvm-unit-tests PATCH] Fix the length in the stsi check for the VM name Thomas Huth
2021-02-09 16:55 ` David Hildenbrand
2021-02-10 7:55 ` Janosch Frank
2021-02-10 11:05 ` Cornelia Huck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.