* [PATCH] makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect
@ 2014-10-14 6:45 Harshula Jayasuriya
2014-10-17 1:02 ` Atsushi Kumagai
0 siblings, 1 reply; 5+ messages in thread
From: Harshula Jayasuriya @ 2014-10-14 6:45 UTC (permalink / raw)
To: Masaki Tachibana, Minoru Usui, Daisuke Nishimura,
Atsushi Kumagai, kexec-ml
Hi,
The makedumpfile man page contains a table explaining the usage of -d.
The "cache without private" column implies that -d 4 would exclude "cache
without private" pages. However, a -d 4 should only exclude "cache with
private".
makedumpfile.h:
------------------------------------------------------------
#define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
without Private Pages */
------------------------------------------------------------
makedumpfile.8:
------------------------------------------------------------
| |cache |cache | |
dump | zero |without|with | user | free
level | page |private|private| data | page
-------+------+-------+-------+------+------
0 | | | | |
1 | X | | | |
2 | | X | | |
3 | X | X | | |
4 | | X | X | |
5 | X | X | X | |
6 | | X | X | |
7 | X | X | X | |
8 | | | | X |
------------------------------------------------------------
Signed-off-by: Harshula Jayasuriya <harshula@redhat.com>
---
makedumpfile.8 | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/makedumpfile.8 b/makedumpfile.8
index 9cb12c0..382c6ee 100644
--- a/makedumpfile.8
+++ b/makedumpfile.8
@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
1 | X | | | |
2 | | X | | |
3 | X | X | | |
- 4 | | X | X | |
- 5 | X | X | X | |
+ 4 | | | X | |
+ 5 | X | | X | |
6 | | X | X | |
7 | X | X | X | |
8 | | | | X |
9 | X | | | X |
10 | | X | | X |
11 | X | X | | X |
- 12 | | X | X | X |
- 13 | X | X | X | X |
+ 12 | | | X | X |
+ 13 | X | | X | X |
14 | | X | X | X |
15 | X | X | X | X |
16 | | | | | X
17 | X | | | | X
18 | | X | | | X
19 | X | X | | | X
- 20 | | X | X | | X
- 21 | X | X | X | | X
+ 20 | | | X | | X
+ 21 | X | | X | | X
22 | | X | X | | X
23 | X | X | X | | X
24 | | | | X | X
25 | X | | | X | X
26 | | X | | X | X
27 | X | X | | X | X
- 28 | | X | X | X | X
- 29 | X | X | X | X | X
+ 28 | | | X | X | X
+ 29 | X | | X | X | X
30 | | X | X | X | X
31 | X | X | X | X | X
--
1.9.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect
2014-10-14 6:45 [PATCH] makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect Harshula Jayasuriya
@ 2014-10-17 1:02 ` Atsushi Kumagai
2014-10-17 1:49 ` Harshula Jayasuriya
0 siblings, 1 reply; 5+ messages in thread
From: Atsushi Kumagai @ 2014-10-17 1:02 UTC (permalink / raw)
To: harshula; +Cc: Minoru Usui, Masaki Tachibana, Daisuke Nishimura, kexec
Hello,
>Hi,
>
>The makedumpfile man page contains a table explaining the usage of -d.
>The "cache without private" column implies that -d 4 would exclude "cache
>without private" pages. However, a -d 4 should only exclude "cache with
>private".
"cache with private" includes "cache without private" because the latter
doesn't mean leaving private cache pages, just mean excluding cache pages
except private pages. Meanwhile, "cache with private" means excluding both
cache pages (private and non-private). So "with private" meets "without private"
in this feature, they aren't exclusive.
This style is for diskdump compatibility, but now I suspect it may be
bit confusing.
I don't want to change the behavior of the page filtering, but I guess
changing the column names might be meaningful.
I'm curious to know what everyone thought of the two columns. This can
be a good opportunity to make the manual easier to understand.
Thanks,
Atsushi Kumagai
>makedumpfile.h:
>------------------------------------------------------------
> #define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
> without Private Pages */
>------------------------------------------------------------
>
>makedumpfile.8:
>------------------------------------------------------------
> | |cache |cache | |
> dump | zero |without|with | user | free
> level | page |private|private| data | page
> -------+------+-------+-------+------+------
> 0 | | | | |
> 1 | X | | | |
> 2 | | X | | |
> 3 | X | X | | |
> 4 | | X | X | |
> 5 | X | X | X | |
> 6 | | X | X | |
> 7 | X | X | X | |
> 8 | | | | X |
>------------------------------------------------------------
>
>Signed-off-by: Harshula Jayasuriya <harshula@redhat.com>
>---
> makedumpfile.8 | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/makedumpfile.8 b/makedumpfile.8
>index 9cb12c0..382c6ee 100644
>--- a/makedumpfile.8
>+++ b/makedumpfile.8
>@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
> 1 | X | | | |
> 2 | | X | | |
> 3 | X | X | | |
>- 4 | | X | X | |
>- 5 | X | X | X | |
>+ 4 | | | X | |
>+ 5 | X | | X | |
> 6 | | X | X | |
> 7 | X | X | X | |
> 8 | | | | X |
> 9 | X | | | X |
> 10 | | X | | X |
> 11 | X | X | | X |
>- 12 | | X | X | X |
>- 13 | X | X | X | X |
>+ 12 | | | X | X |
>+ 13 | X | | X | X |
> 14 | | X | X | X |
> 15 | X | X | X | X |
> 16 | | | | | X
> 17 | X | | | | X
> 18 | | X | | | X
> 19 | X | X | | | X
>- 20 | | X | X | | X
>- 21 | X | X | X | | X
>+ 20 | | | X | | X
>+ 21 | X | | X | | X
> 22 | | X | X | | X
> 23 | X | X | X | | X
> 24 | | | | X | X
> 25 | X | | | X | X
> 26 | | X | | X | X
> 27 | X | X | | X | X
>- 28 | | X | X | X | X
>- 29 | X | X | X | X | X
>+ 28 | | | X | X | X
>+ 29 | X | | X | X | X
> 30 | | X | X | X | X
> 31 | X | X | X | X | X
>
>--
>1.9.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect
2014-10-17 1:02 ` Atsushi Kumagai
@ 2014-10-17 1:49 ` Harshula Jayasuriya
2014-10-17 7:37 ` Atsushi Kumagai
0 siblings, 1 reply; 5+ messages in thread
From: Harshula Jayasuriya @ 2014-10-17 1:49 UTC (permalink / raw)
To: Atsushi Kumagai; +Cc: Minoru Usui, Masaki Tachibana, Daisuke Nishimura, kexec
Hi,
On Fri, 2014-10-17 at 01:02 +0000, Atsushi Kumagai wrote:
> Hello,
>
> >Hi,
> >
> >The makedumpfile man page contains a table explaining the usage of -d.
> >The "cache without private" column implies that -d 4 would exclude "cache
> >without private" pages. However, a -d 4 should only exclude "cache with
> >private".
>
> "cache with private" includes "cache without private" because the latter
> doesn't mean leaving private cache pages, just mean excluding cache pages
> except private pages. Meanwhile, "cache with private" means excluding both
> cache pages (private and non-private). So "with private" meets "without private"
> in this feature, they aren't exclusive.
> This style is for diskdump compatibility, but now I suspect it may be
> bit confusing.
Ahhh I see! ;-)
> I don't want to change the behavior of the page filtering, but I guess
> changing the column names might be meaningful.
Would the following help?
a) s/cache without private/non-private cache/
b) s/cache with private/all cache/
cya,
#
> I'm curious to know what everyone thought of the two columns. This can
> be a good opportunity to make the manual easier to understand.
>
>
> Thanks,
> Atsushi Kumagai
>
> >makedumpfile.h:
> >------------------------------------------------------------
> > #define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
> > without Private Pages */
> >------------------------------------------------------------
> >
> >makedumpfile.8:
> >------------------------------------------------------------
> > | |cache |cache | |
> > dump | zero |without|with | user | free
> > level | page |private|private| data | page
> > -------+------+-------+-------+------+------
> > 0 | | | | |
> > 1 | X | | | |
> > 2 | | X | | |
> > 3 | X | X | | |
> > 4 | | X | X | |
> > 5 | X | X | X | |
> > 6 | | X | X | |
> > 7 | X | X | X | |
> > 8 | | | | X |
> >------------------------------------------------------------
> >
> >Signed-off-by: Harshula Jayasuriya <harshula@redhat.com>
> >---
> > makedumpfile.8 | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> >diff --git a/makedumpfile.8 b/makedumpfile.8
> >index 9cb12c0..382c6ee 100644
> >--- a/makedumpfile.8
> >+++ b/makedumpfile.8
> >@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
> > 1 | X | | | |
> > 2 | | X | | |
> > 3 | X | X | | |
> >- 4 | | X | X | |
> >- 5 | X | X | X | |
> >+ 4 | | | X | |
> >+ 5 | X | | X | |
> > 6 | | X | X | |
> > 7 | X | X | X | |
> > 8 | | | | X |
> > 9 | X | | | X |
> > 10 | | X | | X |
> > 11 | X | X | | X |
> >- 12 | | X | X | X |
> >- 13 | X | X | X | X |
> >+ 12 | | | X | X |
> >+ 13 | X | | X | X |
> > 14 | | X | X | X |
> > 15 | X | X | X | X |
> > 16 | | | | | X
> > 17 | X | | | | X
> > 18 | | X | | | X
> > 19 | X | X | | | X
> >- 20 | | X | X | | X
> >- 21 | X | X | X | | X
> >+ 20 | | | X | | X
> >+ 21 | X | | X | | X
> > 22 | | X | X | | X
> > 23 | X | X | X | | X
> > 24 | | | | X | X
> > 25 | X | | | X | X
> > 26 | | X | | X | X
> > 27 | X | X | | X | X
> >- 28 | | X | X | X | X
> >- 29 | X | X | X | X | X
> >+ 28 | | | X | X | X
> >+ 29 | X | | X | X | X
> > 30 | | X | X | X | X
> > 31 | X | X | X | X | X
> >
> >--
> >1.9.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect
2014-10-17 1:49 ` Harshula Jayasuriya
@ 2014-10-17 7:37 ` Atsushi Kumagai
2014-10-24 2:45 ` Harshula Jayasuriya
0 siblings, 1 reply; 5+ messages in thread
From: Atsushi Kumagai @ 2014-10-17 7:37 UTC (permalink / raw)
To: harshula; +Cc: Minoru Usui, Masaki Tachibana, Daisuke Nishimura, kexec
>Hi,
>
>On Fri, 2014-10-17 at 01:02 +0000, Atsushi Kumagai wrote:
>> Hello,
>>
>> >Hi,
>> >
>> >The makedumpfile man page contains a table explaining the usage of -d.
>> >The "cache without private" column implies that -d 4 would exclude "cache
>> >without private" pages. However, a -d 4 should only exclude "cache with
>> >private".
>>
>> "cache with private" includes "cache without private" because the latter
>> doesn't mean leaving private cache pages, just mean excluding cache pages
>> except private pages. Meanwhile, "cache with private" means excluding both
>> cache pages (private and non-private). So "with private" meets "without private"
>> in this feature, they aren't exclusive.
>> This style is for diskdump compatibility, but now I suspect it may be
>> bit confusing.
>
>Ahhh I see! ;-)
>
>> I don't want to change the behavior of the page filtering, but I guess
>> changing the column names might be meaningful.
>
>Would the following help?
>
>a) s/cache without private/non-private cache/
>
>b) s/cache with private/all cache/
Thanks for your suggestion, but now I think each column should
be exclusive to make the rule consistent. Actually, other columns
(zero page, user data, free page) are exclusive.
So let's name the two like below:
a) non-private cache
b) private cache
| |non- | | |
dump | zero |private|private| user | free
level | page |cache |cache | data | page
-------+------+-------+-------+------+------
...
4 | | X | X | |
5 | X | X | X | |
then marking the both columns for level 4 will be natural.
I'll post a patch later if there is no objection.
Thanks,
Atsushi Kumagai
>cya,
>#
>
>> I'm curious to know what everyone thought of the two columns. This can
>> be a good opportunity to make the manual easier to understand.
>>
>>
>> Thanks,
>> Atsushi Kumagai
>>
>> >makedumpfile.h:
>> >------------------------------------------------------------
>> > #define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
>> > without Private Pages */
>> >------------------------------------------------------------
>> >
>> >makedumpfile.8:
>> >------------------------------------------------------------
>> > | |cache |cache | |
>> > dump | zero |without|with | user | free
>> > level | page |private|private| data | page
>> > -------+------+-------+-------+------+------
>> > 0 | | | | |
>> > 1 | X | | | |
>> > 2 | | X | | |
>> > 3 | X | X | | |
>> > 4 | | X | X | |
>> > 5 | X | X | X | |
>> > 6 | | X | X | |
>> > 7 | X | X | X | |
>> > 8 | | | | X |
>> >------------------------------------------------------------
>> >
>> >Signed-off-by: Harshula Jayasuriya <harshula@redhat.com>
>> >---
>> > makedumpfile.8 | 16 ++++++++--------
>> > 1 file changed, 8 insertions(+), 8 deletions(-)
>> >
>> >diff --git a/makedumpfile.8 b/makedumpfile.8
>> >index 9cb12c0..382c6ee 100644
>> >--- a/makedumpfile.8
>> >+++ b/makedumpfile.8
>> >@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
>> > 1 | X | | | |
>> > 2 | | X | | |
>> > 3 | X | X | | |
>> >- 4 | | X | X | |
>> >- 5 | X | X | X | |
>> >+ 4 | | | X | |
>> >+ 5 | X | | X | |
>> > 6 | | X | X | |
>> > 7 | X | X | X | |
>> > 8 | | | | X |
>> > 9 | X | | | X |
>> > 10 | | X | | X |
>> > 11 | X | X | | X |
>> >- 12 | | X | X | X |
>> >- 13 | X | X | X | X |
>> >+ 12 | | | X | X |
>> >+ 13 | X | | X | X |
>> > 14 | | X | X | X |
>> > 15 | X | X | X | X |
>> > 16 | | | | | X
>> > 17 | X | | | | X
>> > 18 | | X | | | X
>> > 19 | X | X | | | X
>> >- 20 | | X | X | | X
>> >- 21 | X | X | X | | X
>> >+ 20 | | | X | | X
>> >+ 21 | X | | X | | X
>> > 22 | | X | X | | X
>> > 23 | X | X | X | | X
>> > 24 | | | | X | X
>> > 25 | X | | | X | X
>> > 26 | | X | | X | X
>> > 27 | X | X | | X | X
>> >- 28 | | X | X | X | X
>> >- 29 | X | X | X | X | X
>> >+ 28 | | | X | X | X
>> >+ 29 | X | | X | X | X
>> > 30 | | X | X | X | X
>> > 31 | X | X | X | X | X
>> >
>> >--
>> >1.9.3
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect
2014-10-17 7:37 ` Atsushi Kumagai
@ 2014-10-24 2:45 ` Harshula Jayasuriya
0 siblings, 0 replies; 5+ messages in thread
From: Harshula Jayasuriya @ 2014-10-24 2:45 UTC (permalink / raw)
To: Atsushi Kumagai; +Cc: Minoru Usui, Masaki Tachibana, Daisuke Nishimura, kexec
On Fri, 2014-10-17 at 07:37 +0000, Atsushi Kumagai wrote:
> >Hi,
> >
> >On Fri, 2014-10-17 at 01:02 +0000, Atsushi Kumagai wrote:
> >> Hello,
> >>
> >> >Hi,
> >> >
> >> >The makedumpfile man page contains a table explaining the usage of -d.
> >> >The "cache without private" column implies that -d 4 would exclude "cache
> >> >without private" pages. However, a -d 4 should only exclude "cache with
> >> >private".
> >>
> >> "cache with private" includes "cache without private" because the latter
> >> doesn't mean leaving private cache pages, just mean excluding cache pages
> >> except private pages. Meanwhile, "cache with private" means excluding both
> >> cache pages (private and non-private). So "with private" meets "without private"
> >> in this feature, they aren't exclusive.
> >> This style is for diskdump compatibility, but now I suspect it may be
> >> bit confusing.
> >
> >Ahhh I see! ;-)
> >
> >> I don't want to change the behavior of the page filtering, but I guess
> >> changing the column names might be meaningful.
> >
> >Would the following help?
> >
> >a) s/cache without private/non-private cache/
> >
> >b) s/cache with private/all cache/
>
> Thanks for your suggestion, but now I think each column should
> be exclusive to make the rule consistent. Actually, other columns
> (zero page, user data, free page) are exclusive.
>
> So let's name the two like below:
>
> a) non-private cache
> b) private cache
>
> | |non- | | |
> dump | zero |private|private| user | free
> level | page |cache |cache | data | page
> -------+------+-------+-------+------+------
> ...
> 4 | | X | X | |
> 5 | X | X | X | |
>
> then marking the both columns for level 4 will be natural.
> I'll post a patch later if there is no objection.
Looks good to me!
cya,
#
> Thanks,
> Atsushi Kumagai
>
> >cya,
> >#
> >
> >> I'm curious to know what everyone thought of the two columns. This can
> >> be a good opportunity to make the manual easier to understand.
> >>
> >>
> >> Thanks,
> >> Atsushi Kumagai
> >>
> >> >makedumpfile.h:
> >> >------------------------------------------------------------
> >> > #define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
> >> > without Private Pages */
> >> >------------------------------------------------------------
> >> >
> >> >makedumpfile.8:
> >> >------------------------------------------------------------
> >> > | |cache |cache | |
> >> > dump | zero |without|with | user | free
> >> > level | page |private|private| data | page
> >> > -------+------+-------+-------+------+------
> >> > 0 | | | | |
> >> > 1 | X | | | |
> >> > 2 | | X | | |
> >> > 3 | X | X | | |
> >> > 4 | | X | X | |
> >> > 5 | X | X | X | |
> >> > 6 | | X | X | |
> >> > 7 | X | X | X | |
> >> > 8 | | | | X |
> >> >------------------------------------------------------------
> >> >
> >> >Signed-off-by: Harshula Jayasuriya <harshula@redhat.com>
> >> >---
> >> > makedumpfile.8 | 16 ++++++++--------
> >> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >> >
> >> >diff --git a/makedumpfile.8 b/makedumpfile.8
> >> >index 9cb12c0..382c6ee 100644
> >> >--- a/makedumpfile.8
> >> >+++ b/makedumpfile.8
> >> >@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
> >> > 1 | X | | | |
> >> > 2 | | X | | |
> >> > 3 | X | X | | |
> >> >- 4 | | X | X | |
> >> >- 5 | X | X | X | |
> >> >+ 4 | | | X | |
> >> >+ 5 | X | | X | |
> >> > 6 | | X | X | |
> >> > 7 | X | X | X | |
> >> > 8 | | | | X |
> >> > 9 | X | | | X |
> >> > 10 | | X | | X |
> >> > 11 | X | X | | X |
> >> >- 12 | | X | X | X |
> >> >- 13 | X | X | X | X |
> >> >+ 12 | | | X | X |
> >> >+ 13 | X | | X | X |
> >> > 14 | | X | X | X |
> >> > 15 | X | X | X | X |
> >> > 16 | | | | | X
> >> > 17 | X | | | | X
> >> > 18 | | X | | | X
> >> > 19 | X | X | | | X
> >> >- 20 | | X | X | | X
> >> >- 21 | X | X | X | | X
> >> >+ 20 | | | X | | X
> >> >+ 21 | X | | X | | X
> >> > 22 | | X | X | | X
> >> > 23 | X | X | X | | X
> >> > 24 | | | | X | X
> >> > 25 | X | | | X | X
> >> > 26 | | X | | X | X
> >> > 27 | X | X | | X | X
> >> >- 28 | | X | X | X | X
> >> >- 29 | X | X | X | X | X
> >> >+ 28 | | | X | X | X
> >> >+ 29 | X | | X | X | X
> >> > 30 | | X | X | X | X
> >> > 31 | X | X | X | X | X
> >> >
> >> >--
> >> >1.9.3
> >
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-24 8:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-14 6:45 [PATCH] makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect Harshula Jayasuriya
2014-10-17 1:02 ` Atsushi Kumagai
2014-10-17 1:49 ` Harshula Jayasuriya
2014-10-17 7:37 ` Atsushi Kumagai
2014-10-24 2:45 ` Harshula Jayasuriya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.