[PATCH] Allow --dump-dmesg for Xen vmcores

[PATCH] Allow --dump-dmesg for Xen vmcores

[Petr Tesarik]

If a Xen dump is detected, makedumpfile checks that the target format is
ELF. The real reason is that compressed formats are not possible with Xen.

But there's a third way initial_xen() can be called: with --dump-dmesg.
This variant works in fact, so it's enough to extend the check so that
it covers this case.

Signed-off-by: Petr Tesarik <ptesarik@suse.cz>
---
 makedumpfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/makedumpfile.c b/makedumpfile.c
index 0bd8b55..ea29239 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -7660,7 +7660,7 @@ initial_xen(void)
 	MSG("Xen is not supported on powerpc.\n");
 	return FALSE;
 #else
-	if(!info->flag_elf_dumpfile) {
+	if(!info->flag_elf_dumpfile && !info->flag_dmesg) {
 		MSG("Specify '-E' option for Xen.\n");
 		MSG("Commandline parameter is invalid.\n");
 		MSG("Try `makedumpfile --help' for more information.\n");
-- 
1.8.4.5

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

RE: [PATCH] Allow --dump-dmesg for Xen vmcores

[Atsushi Kumagai]

Hello Petr,

>If a Xen dump is detected, makedumpfile checks that the target format is
>ELF. The real reason is that compressed formats are not possible with Xen.
>
>But there's a third way initial_xen() can be called: with --dump-dmesg.
>This variant works in fact, so it's enough to extend the check so that
>it covers this case.
>
>Signed-off-by: Petr Tesarik <ptesarik@suse.cz>

Good fix, I'll merge this patch into v1.5.6.


Thanks
Atsushi Kumagai

>---
> makedumpfile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/makedumpfile.c b/makedumpfile.c
>index 0bd8b55..ea29239 100644
>--- a/makedumpfile.c
>+++ b/makedumpfile.c
>@@ -7660,7 +7660,7 @@ initial_xen(void)
> 	MSG("Xen is not supported on powerpc.\n");
> 	return FALSE;
> #else
>-	if(!info->flag_elf_dumpfile) {
>+	if(!info->flag_elf_dumpfile && !info->flag_dmesg) {
> 		MSG("Specify '-E' option for Xen.\n");
> 		MSG("Commandline parameter is invalid.\n");
> 		MSG("Try `makedumpfile --help' for more information.\n");
>--
>1.8.4.5
>
>_______________________________________________
>kexec mailing list
>kexec@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec