From: Christophe Leroy <christophe.leroy@csgroup.eu> To: Geert Uytterhoeven <geert@linux-m68k.org>, Alex Deucher <alexdeucher@gmail.com> Cc: "Alex Deucher" <alexander.deucher@amd.com>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, LKML <linux-kernel@vger.kernel.org>, "amd-gfx list" <amd-gfx@lists.freedesktop.org>, "Christian König" <christian.koenig@amd.com> Subject: Re: Build regressions/improvements in v5.12-rc1 Date: Fri, 5 Mar 2021 12:16:34 +0100 [thread overview] Message-ID: <09155bb0-4403-bcde-239f-eae4067953ca@csgroup.eu> (raw) In-Reply-To: <CAMuHMdVFstnce-WKmj=4h3ZdtSThJNOLz_f1ervcZxE6hg=KsA@mail.gmail.com> Le 02/03/2021 à 21:01, Geert Uytterhoeven a écrit : > Hi Alex, > > On Tue, Mar 2, 2021 at 8:30 PM Alex Deucher <alexdeucher@gmail.com> wrote: >> On Mon, Mar 1, 2021 at 9:21 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: >>> On Mon, 1 Mar 2021, Geert Uytterhoeven wrote: >>>> Below is the list of build error/warning regressions/improvements in >>>> v5.12-rc1[1] compared to v5.11[2]. >>>> >>>> Summarized: >>>> - build errors: +2/-0 >>> >>>> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8/ (all 192 configs) >>>> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/f40ddce88593482919761f74910f42f4b84c004b/ (all 192 configs) >>>> >>>> >>>> *** ERRORS *** >>>> >>>> 2 error regressions: >>>> + /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c: error: implicit declaration of function 'disable_kernel_vsx' [-Werror=implicit-function-declaration]: => 674:2 >>>> + /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c: error: implicit declaration of function 'enable_kernel_vsx' [-Werror=implicit-function-declaration]: => 638:2 >>> >>> powerpc-gcc4.9/ppc64_book3e_allmodconfig >>> >>> This was fixed in v5.11-rc1, but reappeared in v5.12-rc1? >> >> Do you know what fixed in for 5.11? I guess for PPC64 we depend on CONFIG_VSX? > > Looking at the kisskb build logs for v5.11*, it seems compilation never > got to drivers/gpu/drm/ due to internal compiler errors that weren't caught > by my scripts. So the errors listed above were not really fixed. > As far as I can see, the problem has been there for any config without CONFIG_VSX from the beginning ie since https://github.com/linuxppc/linux/commit/16a9dea110a6 The following should fix it up: diff --git a/arch/powerpc/include/asm/switch_to.h b/arch/powerpc/include/asm/switch_to.h index fdab93428372..9d1fbd8be1c7 100644 --- a/arch/powerpc/include/asm/switch_to.h +++ b/arch/powerpc/include/asm/switch_to.h @@ -71,6 +71,16 @@ static inline void disable_kernel_vsx(void) { msr_check_and_clear(MSR_FP|MSR_VEC|MSR_VSX); } +#else +static inline void enable_kernel_vsx(void) +{ + BUILD_BUG(); +} + +static inline void disable_kernel_vsx(void) +{ + BUILD_BUG(); +} #endif #ifdef CONFIG_SPE --- Christophe Christophe
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu> To: Geert Uytterhoeven <geert@linux-m68k.org>, Alex Deucher <alexdeucher@gmail.com> Cc: "Alex Deucher" <alexander.deucher@amd.com>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, LKML <linux-kernel@vger.kernel.org>, "amd-gfx list" <amd-gfx@lists.freedesktop.org>, "Christian König" <christian.koenig@amd.com> Subject: Re: Build regressions/improvements in v5.12-rc1 Date: Fri, 5 Mar 2021 12:16:34 +0100 [thread overview] Message-ID: <09155bb0-4403-bcde-239f-eae4067953ca@csgroup.eu> (raw) In-Reply-To: <CAMuHMdVFstnce-WKmj=4h3ZdtSThJNOLz_f1ervcZxE6hg=KsA@mail.gmail.com> Le 02/03/2021 à 21:01, Geert Uytterhoeven a écrit : > Hi Alex, > > On Tue, Mar 2, 2021 at 8:30 PM Alex Deucher <alexdeucher@gmail.com> wrote: >> On Mon, Mar 1, 2021 at 9:21 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: >>> On Mon, 1 Mar 2021, Geert Uytterhoeven wrote: >>>> Below is the list of build error/warning regressions/improvements in >>>> v5.12-rc1[1] compared to v5.11[2]. >>>> >>>> Summarized: >>>> - build errors: +2/-0 >>> >>>> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8/ (all 192 configs) >>>> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/f40ddce88593482919761f74910f42f4b84c004b/ (all 192 configs) >>>> >>>> >>>> *** ERRORS *** >>>> >>>> 2 error regressions: >>>> + /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c: error: implicit declaration of function 'disable_kernel_vsx' [-Werror=implicit-function-declaration]: => 674:2 >>>> + /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c: error: implicit declaration of function 'enable_kernel_vsx' [-Werror=implicit-function-declaration]: => 638:2 >>> >>> powerpc-gcc4.9/ppc64_book3e_allmodconfig >>> >>> This was fixed in v5.11-rc1, but reappeared in v5.12-rc1? >> >> Do you know what fixed in for 5.11? I guess for PPC64 we depend on CONFIG_VSX? > > Looking at the kisskb build logs for v5.11*, it seems compilation never > got to drivers/gpu/drm/ due to internal compiler errors that weren't caught > by my scripts. So the errors listed above were not really fixed. > As far as I can see, the problem has been there for any config without CONFIG_VSX from the beginning ie since https://github.com/linuxppc/linux/commit/16a9dea110a6 The following should fix it up: diff --git a/arch/powerpc/include/asm/switch_to.h b/arch/powerpc/include/asm/switch_to.h index fdab93428372..9d1fbd8be1c7 100644 --- a/arch/powerpc/include/asm/switch_to.h +++ b/arch/powerpc/include/asm/switch_to.h @@ -71,6 +71,16 @@ static inline void disable_kernel_vsx(void) { msr_check_and_clear(MSR_FP|MSR_VEC|MSR_VSX); } +#else +static inline void enable_kernel_vsx(void) +{ + BUILD_BUG(); +} + +static inline void disable_kernel_vsx(void) +{ + BUILD_BUG(); +} #endif #ifdef CONFIG_SPE --- Christophe Christophe _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-03-05 11:17 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-01 10:43 Build regressions/improvements in v5.12-rc1 Geert Uytterhoeven 2021-03-01 12:44 ` Geert Uytterhoeven 2021-03-01 12:44 ` Geert Uytterhoeven 2021-03-01 12:44 ` Geert Uytterhoeven 2021-03-02 19:30 ` Alex Deucher 2021-03-02 19:30 ` Alex Deucher 2021-03-02 19:30 ` Alex Deucher 2021-03-02 20:01 ` Geert Uytterhoeven 2021-03-02 20:01 ` Geert Uytterhoeven 2021-03-02 20:01 ` Geert Uytterhoeven 2021-03-05 11:16 ` Christophe Leroy [this message] 2021-03-05 11:16 ` Christophe Leroy 2021-03-03 22:35 ` Bhaskar Chowdhury
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=09155bb0-4403-bcde-239f-eae4067953ca@csgroup.eu \ --to=christophe.leroy@csgroup.eu \ --cc=alexander.deucher@amd.com \ --cc=alexdeucher@gmail.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=geert@linux-m68k.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.