* [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID
@ 2022-04-12 11:32 Andy Shevchenko
2022-04-13 15:38 ` Florian Fainelli
2022-04-13 16:43 ` Christoph Hellwig
0 siblings, 2 replies; 8+ messages in thread
From: Andy Shevchenko @ 2022-04-12 11:32 UTC (permalink / raw)
To: Allen Pais, linux-mips, linux-kernel
Cc: Rafał Miłecki, Christoph Hellwig, Andrew Morton,
Andy Shevchenko
There is export_uuid() function which exports uuid_t to the u8 array.
Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3: rebased on the latest vanilla, added Andrew since it has no move for 1y+
drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index a5bf4c3f6dc7..40e3183a3d11 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)
return -ENODEV;
/* Open session with Bnxt load Trusted App */
- memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
+ export_uuid(sess_arg.uuid, &bnxt_device->id.uuid);
sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
sess_arg.num_params = 0;
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2022-04-12 11:32 [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID Andy Shevchenko
@ 2022-04-13 15:38 ` Florian Fainelli
2022-04-13 16:51 ` Andy Shevchenko
2022-05-03 10:19 ` Andy Shevchenko
2022-04-13 16:43 ` Christoph Hellwig
1 sibling, 2 replies; 8+ messages in thread
From: Florian Fainelli @ 2022-04-13 15:38 UTC (permalink / raw)
To: Andy Shevchenko, Allen Pais, linux-mips, linux-kernel
Cc: Rafał Miłecki, Christoph Hellwig, Andrew Morton
On 4/12/2022 4:32 AM, Andy Shevchenko wrote:
> There is export_uuid() function which exports uuid_t to the u8 array.
> Use it instead of open coding variant.
>
> This allows to hide the uuid_t internals.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v3: rebased on the latest vanilla, added Andrew since it has no move for 1y+
I don't think this is going to be picked up unless we designate a entry
in the MAINTAINERS file, I don't mind taking this via the Broadcom ARM
SoCs pull request if this does not move.
> drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index a5bf4c3f6dc7..40e3183a3d11 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)
> return -ENODEV;
>
> /* Open session with Bnxt load Trusted App */
> - memcpy(sess_arg.uuid, bnxt_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
> + export_uuid(sess_arg.uuid, &bnxt_device->id.uuid);
> sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
> sess_arg.num_params = 0;
>
--
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2022-04-12 11:32 [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID Andy Shevchenko
2022-04-13 15:38 ` Florian Fainelli
@ 2022-04-13 16:43 ` Christoph Hellwig
2022-04-13 16:52 ` Andy Shevchenko
1 sibling, 1 reply; 8+ messages in thread
From: Christoph Hellwig @ 2022-04-13 16:43 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Allen Pais, linux-mips, linux-kernel, Rafał Miłecki,
Christoph Hellwig, Andrew Morton
On Tue, Apr 12, 2022 at 02:32:50PM +0300, Andy Shevchenko wrote:
> There is export_uuid() function which exports uuid_t to the u8 array.
> Use it instead of open coding variant.
>
> This allows to hide the uuid_t internals.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2022-04-13 15:38 ` Florian Fainelli
@ 2022-04-13 16:51 ` Andy Shevchenko
2022-05-03 10:19 ` Andy Shevchenko
1 sibling, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2022-04-13 16:51 UTC (permalink / raw)
To: Florian Fainelli
Cc: Allen Pais, linux-mips, linux-kernel, Rafał Miłecki,
Christoph Hellwig, Andrew Morton
On Wed, Apr 13, 2022 at 08:38:41AM -0700, Florian Fainelli wrote:
> On 4/12/2022 4:32 AM, Andy Shevchenko wrote:
...
> > v3: rebased on the latest vanilla, added Andrew since it has no move for 1y+
>
> I don't think this is going to be picked up unless we designate a entry in
> the MAINTAINERS file, I don't mind taking this via the Broadcom ARM SoCs
> pull request if this does not move.
Please do, seems above mentioned tree is the best choice for this driver.
Thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2022-04-13 16:43 ` Christoph Hellwig
@ 2022-04-13 16:52 ` Andy Shevchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2022-04-13 16:52 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Allen Pais, linux-mips, linux-kernel, Rafał Miłecki,
Andrew Morton
On Wed, Apr 13, 2022 at 06:43:19PM +0200, Christoph Hellwig wrote:
> On Tue, Apr 12, 2022 at 02:32:50PM +0300, Andy Shevchenko wrote:
...
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2022-04-13 15:38 ` Florian Fainelli
2022-04-13 16:51 ` Andy Shevchenko
@ 2022-05-03 10:19 ` Andy Shevchenko
2022-05-03 19:28 ` Florian Fainelli
1 sibling, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2022-05-03 10:19 UTC (permalink / raw)
To: Florian Fainelli
Cc: Allen Pais, linux-mips, linux-kernel, Rafał Miłecki,
Christoph Hellwig, Andrew Morton
On Wed, Apr 13, 2022 at 08:38:41AM -0700, Florian Fainelli wrote:
> On 4/12/2022 4:32 AM, Andy Shevchenko wrote:
> > There is export_uuid() function which exports uuid_t to the u8 array.
> > Use it instead of open coding variant.
> >
> > This allows to hide the uuid_t internals.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > v3: rebased on the latest vanilla, added Andrew since it has no move for 1y+
>
> I don't think this is going to be picked up unless we designate a entry in
> the MAINTAINERS file, I don't mind taking this via the Broadcom ARM SoCs
> pull request if this does not move.
I saw your patch has been picked up to up-to-date MAINTAINERS record.
Can this one now be picked up too?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2022-05-03 10:19 ` Andy Shevchenko
@ 2022-05-03 19:28 ` Florian Fainelli
2022-05-04 9:14 ` Andy Shevchenko
0 siblings, 1 reply; 8+ messages in thread
From: Florian Fainelli @ 2022-05-03 19:28 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Allen Pais, linux-mips, linux-kernel, Rafał Miłecki,
Christoph Hellwig, Andrew Morton
On 5/3/22 03:19, Andy Shevchenko wrote:
> On Wed, Apr 13, 2022 at 08:38:41AM -0700, Florian Fainelli wrote:
>> On 4/12/2022 4:32 AM, Andy Shevchenko wrote:
>>> There is export_uuid() function which exports uuid_t to the u8 array.
>>> Use it instead of open coding variant.
>>>
>>> This allows to hide the uuid_t internals.
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>> ---
>>> v3: rebased on the latest vanilla, added Andrew since it has no move for 1y+
>>
>> I don't think this is going to be picked up unless we designate a entry in
>> the MAINTAINERS file, I don't mind taking this via the Broadcom ARM SoCs
>> pull request if this does not move.
>
> I saw your patch has been picked up to up-to-date MAINTAINERS record.
> Can this one now be picked up too?
Please resubmit targeting David Miller's net-next tree since this is how
patches would be merged moving forward. Thanks!
--
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID
2022-05-03 19:28 ` Florian Fainelli
@ 2022-05-04 9:14 ` Andy Shevchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2022-05-04 9:14 UTC (permalink / raw)
To: Florian Fainelli
Cc: Allen Pais, linux-mips, linux-kernel, Rafał Miłecki,
Christoph Hellwig, Andrew Morton
On Tue, May 03, 2022 at 12:28:18PM -0700, Florian Fainelli wrote:
> On 5/3/22 03:19, Andy Shevchenko wrote:
> > On Wed, Apr 13, 2022 at 08:38:41AM -0700, Florian Fainelli wrote:
> > > On 4/12/2022 4:32 AM, Andy Shevchenko wrote:
> > > > There is export_uuid() function which exports uuid_t to the u8 array.
> > > > Use it instead of open coding variant.
> > > >
> > > > This allows to hide the uuid_t internals.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > ---
> > > > v3: rebased on the latest vanilla, added Andrew since it has no move for 1y+
> > >
> > > I don't think this is going to be picked up unless we designate a entry in
> > > the MAINTAINERS file, I don't mind taking this via the Broadcom ARM SoCs
> > > pull request if this does not move.
> >
> > I saw your patch has been picked up to up-to-date MAINTAINERS record.
> > Can this one now be picked up too?
>
> Please resubmit targeting David Miller's net-next tree since this is how
> patches would be merged moving forward. Thanks!
Done, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-04 9:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 11:32 [PATCH v3 1/1] firmware: tee_bnxt: Use UUID API for exporting the UUID Andy Shevchenko
2022-04-13 15:38 ` Florian Fainelli
2022-04-13 16:51 ` Andy Shevchenko
2022-05-03 10:19 ` Andy Shevchenko
2022-05-03 19:28 ` Florian Fainelli
2022-05-04 9:14 ` Andy Shevchenko
2022-04-13 16:43 ` Christoph Hellwig
2022-04-13 16:52 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.