All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] armv8: fsl-layerscape: fix warning if no hwconfig is defined
@ 2019-10-31  5:41 Pankaj Bansal
  2019-11-07 22:39 ` Michael Walle
  2019-11-11 15:25 ` Priyanka Jain
  0 siblings, 2 replies; 3+ messages in thread
From: Pankaj Bansal @ 2019-10-31  5:41 UTC (permalink / raw)
  To: u-boot

if no hwconfig variable is defined for a platform and we try to get the
subarg of hwconfig, we receive a warning:
WARNING: Calling __hwconfig without a buffer and before environment is ready

Therefore, if hwconfig is not found return without further processing.

Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
---

Notes:
    V2:
    - Add copyright year in file that has been updated

 arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
index 8fd6c751c6..b42beca6e1 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0+
 /*
- * Copyright 2017 NXP
+ * Copyright 2017, 2019 NXP
  * Copyright 2014-2015 Freescale Semiconductor, Inc.
  */
 
@@ -1072,6 +1072,8 @@ static void config_core_prefetch(void)
 
 	if (env_get_f("hwconfig", buffer, sizeof(buffer)) > 0)
 		buf = buffer;
+	else
+		return;
 
 	prefetch_arg = hwconfig_subarg_f("core_prefetch", "disable",
 					 &arglen, buf);
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] armv8: fsl-layerscape: fix warning if no hwconfig is defined
  2019-10-31  5:41 [U-Boot] [PATCH v2] armv8: fsl-layerscape: fix warning if no hwconfig is defined Pankaj Bansal
@ 2019-11-07 22:39 ` Michael Walle
  2019-11-11 15:25 ` Priyanka Jain
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Walle @ 2019-11-07 22:39 UTC (permalink / raw)
  To: u-boot

Am 2019-10-31 06:41, schrieb Pankaj Bansal:
> if no hwconfig variable is defined for a platform and we try to get the
> subarg of hwconfig, we receive a warning:
> WARNING: Calling __hwconfig without a buffer and before environment is 
> ready
> 
> Therefore, if hwconfig is not found return without further processing.
> 
> Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>

Tested-by: Michael Walle <michael@walle.cc>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] armv8: fsl-layerscape: fix warning if no hwconfig is defined
  2019-10-31  5:41 [U-Boot] [PATCH v2] armv8: fsl-layerscape: fix warning if no hwconfig is defined Pankaj Bansal
  2019-11-07 22:39 ` Michael Walle
@ 2019-11-11 15:25 ` Priyanka Jain
  1 sibling, 0 replies; 3+ messages in thread
From: Priyanka Jain @ 2019-11-11 15:25 UTC (permalink / raw)
  To: u-boot



>-----Original Message-----
>From: Pankaj Bansal <pankaj.bansal@nxp.com>
>Sent: Thursday, October 31, 2019 11:11 AM
>To: Priyanka Jain <priyanka.jain@nxp.com>
>Cc: u-boot at lists.denx.de; Pankaj Bansal <pankaj.bansal@nxp.com>
>Subject: [PATCH v2] armv8: fsl-layerscape: fix warning if no hwconfig is defined
>
>if no hwconfig variable is defined for a platform and we try to get the subarg
>of hwconfig, we receive a warning:
>WARNING: Calling __hwconfig without a buffer and before environment is
>ready
>
>Therefore, if hwconfig is not found return without further processing.
>
>Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
>---

Some updates done in subject, description and copyright year.
Applied to fsl-qoriq master, awaiting upstream.

Thanks
priyankajain
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-11 15:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31  5:41 [U-Boot] [PATCH v2] armv8: fsl-layerscape: fix warning if no hwconfig is defined Pankaj Bansal
2019-11-07 22:39 ` Michael Walle
2019-11-11 15:25 ` Priyanka Jain

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.