* [meta-oe][PATCH v2] samba: remove /var/lock and /var/run from package
@ 2013-07-08 5:37 Jonathan Liu
2013-07-08 5:53 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Liu @ 2013-07-08 5:37 UTC (permalink / raw)
To: openembedded-devel
The /var/lock and /var/run directories are already created by
base-files.
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
index a27a28c..255c0b4 100644
--- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
+++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
@@ -57,3 +57,9 @@ do_configure() {
do_compile () {
base_do_compile
}
+
+do_install_append() {
+ rmdir "${D}${localstatedir}/lock"
+ rmdir "${D}${localstatedir}/run"
+ rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
+}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [meta-oe][PATCH v2] samba: remove /var/lock and /var/run from package
2013-07-08 5:37 [meta-oe][PATCH v2] samba: remove /var/lock and /var/run from package Jonathan Liu
@ 2013-07-08 5:53 ` Khem Raj
2013-07-08 7:48 ` Jonathan Liu
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2013-07-08 5:53 UTC (permalink / raw)
To: openembedded-devel
On Jul 7, 2013, at 10:37 PM, Jonathan Liu <net147@gmail.com> wrote:
> The /var/lock and /var/run directories are already created by
> base-files.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> index a27a28c..255c0b4 100644
> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
> @@ -57,3 +57,9 @@ do_configure() {
> do_compile () {
> base_do_compile
> }
> +
> +do_install_append() {
> + rmdir "${D}${localstatedir}/lock"
> + rmdir "${D}${localstatedir}/run"
> + rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
what is this last rmdir doing ?
> +}
> --
> 1.8.3.2
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-oe][PATCH v2] samba: remove /var/lock and /var/run from package
2013-07-08 5:53 ` Khem Raj
@ 2013-07-08 7:48 ` Jonathan Liu
2013-07-08 13:52 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Liu @ 2013-07-08 7:48 UTC (permalink / raw)
To: openembedded-devel
On 8 July 2013 15:53, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Jul 7, 2013, at 10:37 PM, Jonathan Liu <net147@gmail.com> wrote:
>
>> The /var/lock and /var/run directories are already created by
>> base-files.
>>
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> ---
>> meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> index a27a28c..255c0b4 100644
>> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>> @@ -57,3 +57,9 @@ do_configure() {
>> do_compile () {
>> base_do_compile
>> }
>> +
>> +do_install_append() {
>> + rmdir "${D}${localstatedir}/lock"
>> + rmdir "${D}${localstatedir}/run"
>> + rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
>
> what is this last rmdir doing ?
It will remove the /var directory only if it is empty. In case there
is nothing else in /var it's useless to have an empty /var directory.
Regards,
Jonathan
>
>
>> +}
>> --
>> 1.8.3.2
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-oe][PATCH v2] samba: remove /var/lock and /var/run from package
2013-07-08 7:48 ` Jonathan Liu
@ 2013-07-08 13:52 ` Khem Raj
0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2013-07-08 13:52 UTC (permalink / raw)
To: openembedded-devel
On Monday, July 8, 2013, Jonathan Liu <net147@gmail.com> wrote:
> On 8 July 2013 15:53, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Jul 7, 2013, at 10:37 PM, Jonathan Liu <net147@gmail.com> wrote:
>>
>>> The /var/lock and /var/run directories are already created by
>>> base-files.
>>>
>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>> ---
>>> meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bbb/meta-oe/recipes-connectivity/samba/
samba_3.6.8.bb
>>> index a27a28c..255c0b4 100644
>>> --- a/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>>> +++ b/meta-oe/recipes-connectivity/samba/samba_3.6.8.bb
>>> @@ -57,3 +57,9 @@ do_configure() {
>>> do_compile () {
>>> base_do_compile
>>> }
>>> +
>>> +do_install_append() {
>>> + rmdir "${D}${localstatedir}/lock"
>>> + rmdir "${D}${localstatedir}/run"
>>> + rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
>>
>> what is this last rmdir doing ?
> It will remove the /var directory only if it is empty. In case there
> is nothing else in /var it's useless to have an empty /var directory.
>
Good. Mention it in commit message
> Regards,
> Jonathan
>
>>
>>
>>> +}
>>> --
>>> 1.8.3.2
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-08 13:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-08 5:37 [meta-oe][PATCH v2] samba: remove /var/lock and /var/run from package Jonathan Liu
2013-07-08 5:53 ` Khem Raj
2013-07-08 7:48 ` Jonathan Liu
2013-07-08 13:52 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.