* [PATCH] bindings: media: venus: Drop bogus maxItems for power-domain-names
@ 2021-10-27 12:45 Geert Uytterhoeven
2021-11-01 21:36 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-10-27 12:45 UTC (permalink / raw)
To: Dikshita Agarwal, Stanimir Varbanov, Andy Gross, Bjorn Andersson,
Mauro Carvalho Chehab, Rob Herring
Cc: linux-arm-msm, linux-media, devicetree, linux-kernel, Geert Uytterhoeven
make dt_binding_check:
Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml: ignoring, error in schema: properties: power-domain-names
warning: no schema found in file: Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
Fixes: e48b839b6699c226 ("media: dt-bindings: media: venus: Add sc7280 dt schema")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
index fa54c560e0bde3cb..e2874683b4d5faf3 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
@@ -30,7 +30,6 @@ properties:
power-domain-names:
minItems: 2
- maxItems: 3
items:
- const: venus
- const: vcodec0
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] bindings: media: venus: Drop bogus maxItems for power-domain-names
2021-10-27 12:45 [PATCH] bindings: media: venus: Drop bogus maxItems for power-domain-names Geert Uytterhoeven
@ 2021-11-01 21:36 ` Rob Herring
2021-11-02 8:42 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2021-11-01 21:36 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Dikshita Agarwal, Stanimir Varbanov, Andy Gross, Bjorn Andersson,
Mauro Carvalho Chehab, linux-arm-msm, linux-media, devicetree,
linux-kernel
On Wed, Oct 27, 2021 at 02:45:30PM +0200, Geert Uytterhoeven wrote:
> make dt_binding_check:
I'd say it's redundant rather than bogus.
>
> Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml: ignoring, error in schema: properties: power-domain-names
> warning: no schema found in file: Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
>
> Fixes: e48b839b6699c226 ("media: dt-bindings: media: venus: Add sc7280 dt schema")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 -
> 1 file changed, 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bindings: media: venus: Drop bogus maxItems for power-domain-names
2021-11-01 21:36 ` Rob Herring
@ 2021-11-02 8:42 ` Geert Uytterhoeven
2021-11-02 22:44 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-11-02 8:42 UTC (permalink / raw)
To: Rob Herring
Cc: Dikshita Agarwal, Stanimir Varbanov, Andy Gross, Bjorn Andersson,
Mauro Carvalho Chehab, linux-arm-msm, Linux Media Mailing List,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Rob,
On Mon, Nov 1, 2021 at 10:36 PM Rob Herring <robh@kernel.org> wrote:
> On Wed, Oct 27, 2021 at 02:45:30PM +0200, Geert Uytterhoeven wrote:
> > make dt_binding_check:
>
> I'd say it's redundant rather than bogus.
I wrote "bogus", as the "redundant" ones typically give:
hint: "maxItems" is not needed with an "items" list
And I didn't get that here?
> > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml: ignoring, error in schema: properties: power-domain-names
> > warning: no schema found in file: Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> >
> > Fixes: e48b839b6699c226 ("media: dt-bindings: media: venus: Add sc7280 dt schema")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 -
> > 1 file changed, 1 deletion(-)
>
> Acked-by: Rob Herring <robh@kernel.org>
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bindings: media: venus: Drop bogus maxItems for power-domain-names
2021-11-02 8:42 ` Geert Uytterhoeven
@ 2021-11-02 22:44 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-11-02 22:44 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Dikshita Agarwal, Stanimir Varbanov, Andy Gross, Bjorn Andersson,
Mauro Carvalho Chehab, linux-arm-msm, Linux Media Mailing List,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On Tue, Nov 2, 2021 at 3:42 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob,
>
> On Mon, Nov 1, 2021 at 10:36 PM Rob Herring <robh@kernel.org> wrote:
> > On Wed, Oct 27, 2021 at 02:45:30PM +0200, Geert Uytterhoeven wrote:
> > > make dt_binding_check:
> >
> > I'd say it's redundant rather than bogus.
>
> I wrote "bogus", as the "redundant" ones typically give:
>
> hint: "maxItems" is not needed with an "items" list
>
> And I didn't get that here?
Any schema file with an error shows up twice. First there's all the
specific errors with details. Then there's what you reference which is
all the schemas that we're skipping. If you set DT_SCHEMA_FILES now,
you should only see the second case for other schema files.
So it's probably better to reference the actual error:
Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml:
properties:power-domain-names: {'minItems': 2, 'maxItems': 3, 'items':
[{'const': 'venus'}, {'const': 'vcodec0'}, {'const': 'cx'}]} should
not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
> > > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml: ignoring, error in schema: properties: power-domain-names
> > > warning: no schema found in file: Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml
> > >
> > > Fixes: e48b839b6699c226 ("media: dt-bindings: media: venus: Add sc7280 dt schema")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 -
> > > 1 file changed, 1 deletion(-)
> >
> > Acked-by: Rob Herring <robh@kernel.org>
>
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-02 22:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 12:45 [PATCH] bindings: media: venus: Drop bogus maxItems for power-domain-names Geert Uytterhoeven
2021-11-01 21:36 ` Rob Herring
2021-11-02 8:42 ` Geert Uytterhoeven
2021-11-02 22:44 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.