From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: Stefan Weil <sw@weilnetz.de>, Thomas Huth <thuth@redhat.com>, Sunil Muthuswamy <sunilmut@microsoft.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org> Cc: "Fam Zheng" <fam@euphon.net>, "Peter Maydell" <peter.maydell@linaro.org>, "Daniel P . Berrangé" <berrange@redhat.com>, "Eduardo Habkost" <ehabkost@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "1879672@bugs.launchpad.net" <1879672@bugs.launchpad.net>, "Alex Bennée" <alex.bennee@linaro.org>, "Richard Henderson" <rth@twiddle.net> Subject: Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries Date: Tue, 4 Aug 2020 09:52:45 +0200 [thread overview] Message-ID: <098d9167-c76a-5dd9-ca17-e1f99e4f1f6b@redhat.com> (raw) In-Reply-To: <7cdc7066-0477-5f8b-9d22-12de97098cfc@weilnetz.de> On 8/4/20 9:42 AM, Stefan Weil wrote: > Am 04.08.20 um 09:23 schrieb Philippe Mathieu-Daudé: > >> On 8/4/20 8:55 AM, Stefan Weil wrote: >>> Am 04.08.20 um 08:43 schrieb Thomas Huth: >>> >>>> On 03/08/2020 22.25, Stefan Weil wrote: >>>>> We can add a CI pipeline on Microsoft infrastructure by using a GitHub >>>>> action. >>>> Sorry for being ignorant, but how does that solve the legal questions >>>> just because it is running on GitHub instead of a different CI? >>>> >>>> Thomas >>>> >>> Sorry, I though that would be clear by looking at the included shell script. >>> >>> The build does not use the Microsoft SDK. It gets the required header >>> files from Mingw-w64. They added them in git master. >> Oh, so we can do that with GitLab too now, we don't need to rely on the >> GitHub 'Actions' CI in particular, right? > > > That's right. The build script was written for Ubuntu, so depending on > the distribution used for GitLab CI it will need some modifications. If > GitLab already has a recent Mingw-w64, it might be sufficient to fix the > case of the header file names. Mingw-w64 uses winhvplatform.h while QEMU > expects WinHvPlatform.h and so on. I used symbolic links to add the > camel case filenames. > > >>> See >>> https://github.com/stweil/qemu/blob/master/.github/workflows/build.sh#L50 >>> for code details. >>> >>> It's still shameful that MS is forcing developers to waste time >>> rewriting API headers, just because the MS legal departments are not >>> able to understand the needs of Open Source development. >> There has be a big switch from Microsoft toward Open Source, I attended >> some of there talk at the Open Source Summit in 2018. Maybe we simply >> haven't contacted the right persons to make the changes...? > > > Maybe, but it is difficult to find the right person in a large company > like MS, and legal departments are often somehow special. Sunil seems quite active with the WHPX development, and the section is listed as "Supported [my Microsoft]" in MAINTAINERS. I'm confident we have someone else able to help use finding the right contacts in the company :) > > And yes, they learned that Open Source can help them for their business, > too. > > Stefan > > >
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <1879672@bugs.launchpad.net> To: qemu-devel@nongnu.org Subject: [Bug 1879672] Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries Date: Tue, 04 Aug 2020 07:52:45 -0000 [thread overview] Message-ID: <098d9167-c76a-5dd9-ca17-e1f99e4f1f6b@redhat.com> (raw) Message-ID: <20200804075245.DVXl7hGl77L0TDMxklTtcvgFVqV-51i6nek0fdGmT-4@z> (raw) In-Reply-To: 158996968484.21371.12685815665992748631.malonedeb@wampee.canonical.com On 8/4/20 9:42 AM, Stefan Weil wrote: > Am 04.08.20 um 09:23 schrieb Philippe Mathieu-Daudé: > >> On 8/4/20 8:55 AM, Stefan Weil wrote: >>> Am 04.08.20 um 08:43 schrieb Thomas Huth: >>> >>>> On 03/08/2020 22.25, Stefan Weil wrote: >>>>> We can add a CI pipeline on Microsoft infrastructure by using a GitHub >>>>> action. >>>> Sorry for being ignorant, but how does that solve the legal questions >>>> just because it is running on GitHub instead of a different CI? >>>> >>>> Thomas >>>> >>> Sorry, I though that would be clear by looking at the included shell script. >>> >>> The build does not use the Microsoft SDK. It gets the required header >>> files from Mingw-w64. They added them in git master. >> Oh, so we can do that with GitLab too now, we don't need to rely on the >> GitHub 'Actions' CI in particular, right? > > > That's right. The build script was written for Ubuntu, so depending on > the distribution used for GitLab CI it will need some modifications. If > GitLab already has a recent Mingw-w64, it might be sufficient to fix the > case of the header file names. Mingw-w64 uses winhvplatform.h while QEMU > expects WinHvPlatform.h and so on. I used symbolic links to add the > camel case filenames. > > >>> See >>> https://github.com/stweil/qemu/blob/master/.github/workflows/build.sh#L50 >>> for code details. >>> >>> It's still shameful that MS is forcing developers to waste time >>> rewriting API headers, just because the MS legal departments are not >>> able to understand the needs of Open Source development. >> There has be a big switch from Microsoft toward Open Source, I attended >> some of there talk at the Open Source Summit in 2018. Maybe we simply >> haven't contacted the right persons to make the changes...? > > > Maybe, but it is difficult to find the right person in a large company > like MS, and legal departments are often somehow special. Sunil seems quite active with the WHPX development, and the section is listed as "Supported [my Microsoft]" in MAINTAINERS. I'm confident we have someone else able to help use finding the right contacts in the company :) > > And yes, they learned that Open Source can help them for their business, > too. > > Stefan > > > -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879672 Title: QEMU installer with WHPX support Status in QEMU: Opinion Bug description: People often ask the community to add WHPX support to the QEMU installer for Windows, but it is impossible due to the license limitations of the WHPX SDK. The WinHvEmulation.h and WinHvPlatform.h header files needed are "All rights reserved". However these headers only contain struct definitions and integer constants, no functional code in macros or inline functions. See: https://www.mail-archive.com/qemu-devel@nongnu.org/msg645815.html It is questionable whether the headers alone can be considered copyrightable material. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1879672/+subscriptions
next prev parent reply other threads:[~2020-08-04 7:54 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-20 11:33 [PATCH v2 0/3] testing: Build WHPX enabled binaries Philippe Mathieu-Daudé 2019-09-20 11:33 ` [PATCH v2 1/3] target/i386: Fix broken build with WHPX enabled Philippe Mathieu-Daudé 2019-09-20 11:37 ` Paolo Bonzini 2019-09-20 11:33 ` [PATCH v2 2/3] tests/docker: Add fedora-win10sdk-cross image Philippe Mathieu-Daudé 2019-09-20 11:33 ` [PATCH v2 3/3] .shippable.yml: Build WHPX enabled binaries Philippe Mathieu-Daudé 2019-09-20 15:17 ` [PATCH v2 0/3] testing: " Philippe Mathieu-Daudé 2019-09-20 16:53 ` Justin Terry (VM) 2020-05-20 10:26 ` Philippe Mathieu-Daudé 2020-05-20 10:26 ` [Bug 1879672] " Philippe Mathieu-Daudé 2020-07-31 8:33 ` Philippe Mathieu-Daudé 2020-07-31 8:33 ` [Bug 1879672] " Philippe Mathieu-Daudé 2020-07-31 23:31 ` [EXTERNAL] " Sunil Muthuswamy 2020-08-03 10:51 ` Philippe Mathieu-Daudé 2020-08-03 10:51 ` [Bug 1879672] " Philippe Mathieu-Daudé 2020-08-03 11:28 ` Stefan Weil 2020-08-03 20:25 ` Stefan Weil 2020-08-04 6:43 ` Thomas Huth 2020-08-04 6:55 ` Stefan Weil 2020-08-04 7:23 ` Philippe Mathieu-Daudé 2020-08-04 7:23 ` [Bug 1879672] " Philippe Mathieu-Daudé 2020-08-04 7:42 ` Stefan Weil 2020-08-04 7:52 ` Philippe Mathieu-Daudé [this message] 2020-08-04 7:52 ` [Bug 1879672] " Philippe Mathieu-Daudé 2020-08-04 8:10 ` Thomas Huth 2020-08-04 9:23 ` Daniel P. Berrangé 2020-08-04 9:23 ` [Bug 1879672] " Daniel Berrange 2020-08-18 21:20 ` [EXTERNAL] " Sunil Muthuswamy 2020-08-19 3:36 ` Philippe Mathieu-Daudé 2020-08-19 3:36 ` [Bug 1879672] " Philippe Mathieu-Daudé 2019-09-21 6:34 ` no-reply -- strict thread matches above, loose matches on Subject: below -- 2020-05-20 10:14 [Bug 1879672] [NEW] QEMU installer with WHPX support Philippe Mathieu-Daudé 2020-05-20 10:25 ` [Bug 1879672] " Daniel Berrange 2020-05-20 12:30 ` Stefan Weil 2020-06-08 7:18 ` Philippe Mathieu-Daudé 2020-11-04 20:01 ` John Snow 2020-11-04 23:12 ` Philippe Mathieu-Daudé 2020-11-04 23:12 ` Philippe Mathieu-Daudé 2021-05-09 15:38 ` Philippe Mathieu-Daudé 2021-05-09 18:33 ` Stefan Weil 2021-05-27 7:45 ` Philippe Mathieu-Daudé 2020-02-18 20:38 [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform Sunil Muthuswamy 2020-02-18 20:51 ` Justin Terry (SF) 2020-02-19 8:31 ` Philippe Mathieu-Daudé 2020-02-19 15:50 ` [EXTERNAL] " Justin Terry (SF) 2020-02-21 7:54 ` Stefan Weil 2020-02-24 19:43 ` Sunil Muthuswamy 2020-05-20 10:29 ` Philippe Mathieu-Daudé 2020-05-20 10:29 ` [Bug 1879672] " Philippe Mathieu-Daudé 2020-05-19 21:59 ` Sunil Muthuswamy 2020-05-20 10:29 ` Philippe Mathieu-Daudé 2020-05-20 10:29 ` [Bug 1879672] " Philippe Mathieu-Daudé 2020-02-21 17:15 ` Paolo Bonzini 2019-11-07 19:48 [PATCH v2] WHPX: support for xcr0 Sunil Muthuswamy 2019-11-07 20:05 ` Stefan Weil 2019-11-07 22:52 ` Sunil Muthuswamy 2020-05-20 10:27 ` Philippe Mathieu-Daudé 2020-05-20 10:27 ` [Bug 1879672] " Philippe Mathieu-Daudé 2019-11-12 18:52 ` Sunil Muthuswamy 2019-11-13 14:56 ` Paolo Bonzini 2022-04-28 6:31 ` Paolo Bonzini 2019-09-19 10:59 [Qemu-devel] [PATCH 0/2] testing: Build WHPX enabled binaries Philippe Mathieu-Daudé 2019-09-19 10:59 ` [Qemu-devel] [PATCH 1/2] tests/docker: Add fedora-win10sdk-cross image Philippe Mathieu-Daudé 2019-09-19 11:28 ` Alex Bennée 2019-09-19 11:35 ` Philippe Mathieu-Daudé 2019-09-19 10:59 ` [Qemu-devel] [PATCH 2/2] .shippable.yml: Build WHPX enabled binaries Philippe Mathieu-Daudé 2019-09-19 11:02 ` Philippe Mathieu-Daudé 2019-09-19 11:09 ` [Qemu-devel] [PATCH 0/2] testing: " Thomas Huth 2019-09-19 11:21 ` Philippe Mathieu-Daudé 2019-09-19 11:18 ` Stefan Weil 2019-09-19 11:26 ` Philippe Mathieu-Daudé 2020-05-20 10:25 ` Philippe Mathieu-Daudé 2020-05-20 10:25 ` [Bug 1879672] " Philippe Mathieu-Daudé 2019-09-19 11:41 ` [Qemu-devel] " Daniel P. Berrangé 2019-09-19 11:54 ` Philippe Mathieu-Daudé 2019-09-19 13:25 ` Daniel P. Berrangé
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=098d9167-c76a-5dd9-ca17-e1f99e4f1f6b@redhat.com \ --to=philmd@redhat.com \ --cc=1879672@bugs.launchpad.net \ --cc=alex.bennee@linaro.org \ --cc=berrange@redhat.com \ --cc=ehabkost@redhat.com \ --cc=fam@euphon.net \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=sunilmut@microsoft.com \ --cc=sw@weilnetz.de \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.