All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tinghan Shen <tinghan.shen@mediatek.com>
To: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chun-Jie Chen <chun-jie.chen@mediatek.com>,
	"Weiyi Lu" <weiyi.lu@mediatek.com>
Cc: <iommu@lists.linux-foundation.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Fengquan Chen <fengquan.chen@mediatek.com>
Subject: Re: [PATCH v1 04/16] arm64: dts: mt8195: Disable watchdog external reset signal
Date: Wed, 6 Jul 2022 12:00:28 +0800	[thread overview]
Message-ID: <098f43e5033c42e9dd44d61d4a505f6870a7a8b0.camel@mediatek.com> (raw)
In-Reply-To: <e01fad71-0d7b-e0a8-7ee5-5a64792ed579@collabora.com>

On Mon, 2022-07-04 at 12:30 +0200, AngeloGioacchino Del Regno wrote:
> Il 04/07/22 12:00, Tinghan Shen ha scritto:
> > Disable external output reset signal in first round of watchdog reset
> > to reserve wdt reset reason for debugging watchdog issue.
> 
> If my understanding of the commit decription is right, then we can clarify
> that with something like: "[...] for debugging eventual watchdog issues".
> 
> Otherwise, if this implies that disable-extrst is needed to avoid losing
> the reset reason stored in the WDT, you could say something like:
> 
> "Disable external output reset signal in the first round of watchdog reset
> to avoid losing the reset reason stored in the watchdog registers"
> 
> After which:
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 

Ok, I'll update it in next version.

Thanks,
TingHan


WARNING: multiple messages have this Message-ID (diff)
From: Tinghan Shen via iommu <iommu@lists.linux-foundation.org>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chun-Jie Chen <chun-jie.chen@mediatek.com>,
	"Weiyi Lu" <weiyi.lu@mediatek.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	iommu@lists.linux-foundation.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Fengquan Chen <fengquan.chen@mediatek.com>
Subject: Re: [PATCH v1 04/16] arm64: dts: mt8195: Disable watchdog external reset signal
Date: Wed, 6 Jul 2022 12:00:28 +0800	[thread overview]
Message-ID: <098f43e5033c42e9dd44d61d4a505f6870a7a8b0.camel@mediatek.com> (raw)
In-Reply-To: <e01fad71-0d7b-e0a8-7ee5-5a64792ed579@collabora.com>

On Mon, 2022-07-04 at 12:30 +0200, AngeloGioacchino Del Regno wrote:
> Il 04/07/22 12:00, Tinghan Shen ha scritto:
> > Disable external output reset signal in first round of watchdog reset
> > to reserve wdt reset reason for debugging watchdog issue.
> 
> If my understanding of the commit decription is right, then we can clarify
> that with something like: "[...] for debugging eventual watchdog issues".
> 
> Otherwise, if this implies that disable-extrst is needed to avoid losing
> the reset reason stored in the WDT, you could say something like:
> 
> "Disable external output reset signal in the first round of watchdog reset
> to avoid losing the reset reason stored in the watchdog registers"
> 
> After which:
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 

Ok, I'll update it in next version.

Thanks,
TingHan

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Tinghan Shen <tinghan.shen@mediatek.com>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chun-Jie Chen <chun-jie.chen@mediatek.com>,
	"Weiyi Lu" <weiyi.lu@mediatek.com>
Cc: <iommu@lists.linux-foundation.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Fengquan Chen <fengquan.chen@mediatek.com>
Subject: Re: [PATCH v1 04/16] arm64: dts: mt8195: Disable watchdog external reset signal
Date: Wed, 6 Jul 2022 12:00:28 +0800	[thread overview]
Message-ID: <098f43e5033c42e9dd44d61d4a505f6870a7a8b0.camel@mediatek.com> (raw)
In-Reply-To: <e01fad71-0d7b-e0a8-7ee5-5a64792ed579@collabora.com>

On Mon, 2022-07-04 at 12:30 +0200, AngeloGioacchino Del Regno wrote:
> Il 04/07/22 12:00, Tinghan Shen ha scritto:
> > Disable external output reset signal in first round of watchdog reset
> > to reserve wdt reset reason for debugging watchdog issue.
> 
> If my understanding of the commit decription is right, then we can clarify
> that with something like: "[...] for debugging eventual watchdog issues".
> 
> Otherwise, if this implies that disable-extrst is needed to avoid losing
> the reset reason stored in the WDT, you could say something like:
> 
> "Disable external output reset signal in the first round of watchdog reset
> to avoid losing the reset reason stored in the watchdog registers"
> 
> After which:
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 

Ok, I'll update it in next version.

Thanks,
TingHan


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-06  4:00 UTC|newest]

Thread overview: 170+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 10:00 [PATCH v1 00/16] Add driver nodes for MT8195 SoC Tinghan Shen
2022-07-04 10:00 ` Tinghan Shen via iommu
2022-07-04 10:00 ` Tinghan Shen
2022-07-04 10:00 ` [PATCH v1 01/16] dt-bindings: iommu: mediatek: Increase max interrupt number Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-05 20:49   ` Rob Herring
2022-07-05 20:49     ` Rob Herring
2022-07-05 20:49     ` Rob Herring
2022-07-06  4:03     ` Tinghan Shen via iommu
2022-07-06  4:03       ` Tinghan Shen
2022-07-06  4:03       ` Tinghan Shen
2022-07-04 10:00 ` [PATCH v1 02/16] dt-bindings: memory: mediatek: Update condition for mt8195 smi node Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:25   ` AngeloGioacchino Del Regno
2022-07-04 10:25     ` AngeloGioacchino Del Regno
2022-07-04 10:25     ` AngeloGioacchino Del Regno
2022-07-06  3:59     ` Tinghan Shen
2022-07-06  3:59       ` Tinghan Shen
2022-07-06  3:59       ` Tinghan Shen via iommu
2022-07-04 12:36   ` Krzysztof Kozlowski
2022-07-04 12:36     ` Krzysztof Kozlowski
2022-07-04 12:36     ` Krzysztof Kozlowski
2022-07-06  4:01     ` Tinghan Shen
2022-07-06  4:01       ` Tinghan Shen
2022-07-06  4:01       ` Tinghan Shen via iommu
2022-07-06 13:48     ` Matthias Brugger
2022-07-06 13:48       ` Matthias Brugger
2022-07-06 13:48       ` Matthias Brugger
2022-07-06 14:38       ` Krzysztof Kozlowski
2022-07-06 14:38         ` Krzysztof Kozlowski
2022-07-06 14:38         ` Krzysztof Kozlowski
2022-07-07 13:02         ` Matthias Brugger
2022-07-07 13:02           ` Matthias Brugger
2022-07-04 10:00 ` [PATCH v1 03/16] dt-bindings: power: mediatek: Refine multiple level power domain nodes Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-05 20:57   ` Rob Herring
2022-07-05 20:57     ` Rob Herring
2022-07-05 20:57     ` Rob Herring
2022-07-06  6:19     ` Tinghan Shen
2022-07-06  6:19       ` Tinghan Shen
2022-07-06  6:19       ` Tinghan Shen via iommu
2022-07-12 19:21       ` Rob Herring
2022-07-12 19:21         ` Rob Herring
2022-07-14 12:22         ` Tinghan Shen
2022-07-14 12:22           ` Tinghan Shen
2022-07-04 10:00 ` [PATCH v1 04/16] arm64: dts: mt8195: Disable watchdog external reset signal Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:30   ` AngeloGioacchino Del Regno
2022-07-04 10:30     ` AngeloGioacchino Del Regno
2022-07-04 10:30     ` AngeloGioacchino Del Regno
2022-07-06  4:00     ` Tinghan Shen [this message]
2022-07-06  4:00       ` Tinghan Shen
2022-07-06  4:00       ` Tinghan Shen via iommu
2022-07-04 10:00 ` [PATCH v1 05/16] arm64: dts: mt8195: Disable I2C0 node Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:33   ` AngeloGioacchino Del Regno
2022-07-04 10:33     ` AngeloGioacchino Del Regno
2022-07-04 10:33     ` AngeloGioacchino Del Regno
2022-07-04 10:00 ` [PATCH v1 06/16] arm64: dts: mt8195: Add cpufreq node Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:41   ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:00 ` [PATCH v1 07/16] arm64: dts: mt8195: Add vdosys and vppsys clock nodes Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:41   ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:00 ` [PATCH v1 08/16] arm64: dts: mt8195: Add power domains controller Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:41   ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 12:38   ` Krzysztof Kozlowski
2022-07-04 12:38     ` Krzysztof Kozlowski
2022-07-04 12:38     ` Krzysztof Kozlowski
2022-07-06 12:00     ` Tinghan Shen
2022-07-06 12:00       ` Tinghan Shen
2022-07-06 12:00       ` Tinghan Shen via iommu
2022-07-06 15:18       ` Krzysztof Kozlowski
2022-07-06 15:18         ` Krzysztof Kozlowski
2022-07-06 15:18         ` Krzysztof Kozlowski
2022-07-12  8:17         ` AngeloGioacchino Del Regno
2022-07-12  8:17           ` AngeloGioacchino Del Regno
2022-07-12  8:37           ` Krzysztof Kozlowski
2022-07-12  8:37             ` Krzysztof Kozlowski
2022-07-12  8:53             ` AngeloGioacchino Del Regno
2022-07-12  8:53               ` AngeloGioacchino Del Regno
2022-07-12  9:03               ` Krzysztof Kozlowski
2022-07-12  9:03                 ` Krzysztof Kozlowski
2022-07-12 10:33                 ` AngeloGioacchino Del Regno
2022-07-12 10:33                   ` AngeloGioacchino Del Regno
2022-07-12 12:47                   ` Krzysztof Kozlowski
2022-07-12 12:47                     ` Krzysztof Kozlowski
2022-07-12 12:54                     ` AngeloGioacchino Del Regno
2022-07-12 12:54                       ` AngeloGioacchino Del Regno
2022-07-12 12:58                       ` Krzysztof Kozlowski
2022-07-12 12:58                         ` Krzysztof Kozlowski
2022-07-12 13:03                         ` AngeloGioacchino Del Regno
2022-07-12 13:03                           ` AngeloGioacchino Del Regno
2022-07-12 13:30                           ` Krzysztof Kozlowski
2022-07-12 13:30                             ` Krzysztof Kozlowski
2022-07-06 13:41     ` Matthias Brugger
2022-07-06 13:41       ` Matthias Brugger
2022-07-06 13:41       ` Matthias Brugger
2022-07-06 14:35       ` Krzysztof Kozlowski
2022-07-06 14:35         ` Krzysztof Kozlowski
2022-07-06 14:35         ` Krzysztof Kozlowski
2022-07-04 10:00 ` [PATCH v1 09/16] arm64: dts: mt8195: Add spmi node Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:41   ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:00 ` [PATCH v1 10/16] arm64: dts: mt8195: Add scp node Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:41   ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:00 ` [PATCH v1 11/16] arm64: dts: mt8195: Add audio related nodes Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:41   ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:00 ` [PATCH v1 12/16] arm64: dts: mt8195: Add adsp node and adsp mailbox nodes Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:00 ` [PATCH v1 13/16] arm64: dts: mt8195: Specify audio reset controller Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:40   ` AngeloGioacchino Del Regno
2022-07-04 10:40     ` AngeloGioacchino Del Regno
2022-07-04 10:40     ` AngeloGioacchino Del Regno
2022-07-04 10:00 ` [PATCH v1 14/16] arm64: dts: mt8195: Add iommu and smi nodes Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:40   ` AngeloGioacchino Del Regno
2022-07-04 10:40     ` AngeloGioacchino Del Regno
2022-07-04 10:40     ` AngeloGioacchino Del Regno
2022-07-04 10:00 ` [PATCH v1 15/16] arm64: dts: mt8195: Add gce node Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:41   ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:41     ` AngeloGioacchino Del Regno
2022-07-04 10:00 ` [PATCH v1 16/16] arm64: dts: mt8195: Add display node for vdosys0 Tinghan Shen
2022-07-04 10:00   ` Tinghan Shen via iommu
2022-07-04 10:00   ` Tinghan Shen
2022-07-04 10:44   ` AngeloGioacchino Del Regno
2022-07-04 10:44     ` AngeloGioacchino Del Regno
2022-07-04 10:44     ` AngeloGioacchino Del Regno
2022-07-06  4:01     ` Tinghan Shen via iommu
2022-07-06  4:01       ` Tinghan Shen
2022-07-06  4:01       ` Tinghan Shen
2022-07-04 12:39   ` Krzysztof Kozlowski
2022-07-04 12:39     ` Krzysztof Kozlowski
2022-07-04 12:39     ` Krzysztof Kozlowski
2022-07-06  4:02     ` Tinghan Shen via iommu
2022-07-06  4:02       ` Tinghan Shen
2022-07-06  4:02       ` Tinghan Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=098f43e5033c42e9dd44d61d4a505f6870a7a8b0.camel@mediatek.com \
    --to=tinghan.shen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chun-jie.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fengquan.chen@mediatek.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=weiyi.lu@mediatek.com \
    --cc=will@kernel.org \
    --cc=yong.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.