All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Linus Walleij <linus.walleij@linaro.org>,
	"Enrico Weigelt, metux IT consult" <info@metux.net>,
	Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	virtualization@lists.linux-foundation.org,
	linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] drivers: gpio: add virtio-gpio guest driver
Date: Wed, 16 Jun 2021 16:41:22 +0200	[thread overview]
Message-ID: <098f669f-b451-18e1-9aed-a71f400bd581@metux.net> (raw)
In-Reply-To: <CACRpkdbwLOOT6nuhpkT5x-AZVipsD2qG8Qu4xoiRotHQNknwzw@mail.gmail.com>

On 16.06.21 10:31, Linus Walleij wrote:
 > Hi Enrico,

 > So now there are two contesting patches for this and that creates a
 > social problem for us as maintainers. I am not too happy about that.

note that this is a polished up of a repost of my original driver
from last year.

 > Can we get the discussion down to actual technical points?

Sure. Perhaps you recall or discussions from late 2020. The missing
point there was (besides a few wording issues) the missing formal
specification process w/ virtio TC. (spec was already included in this
driver as well as the corresponding qemu patches).

My spec was not just meant for VM applications but also actual silicon
(as already mentioned, some folks of my client also implemented it in
FPGAs - don't ask me about details, they just mentioned it was quite
easy for them).

This is why it is so trimmed on things like fixed packet size,
unidirectional queues, mirroring packets w/ thus a few bits changed,
etc. In constrast, a more network-like approach might have been looking
nicer to traditional computer programmers, but much more complex to do
in pure logic and eat up *lots of* more gates (think of actual memory
management instead of hardwired latches, more complex decoding, etc).

Meanwhile it played out working nicely in several HIL installations

If I wanted to have a simple and CPU-only approach (just for VMs), I
would have just mounted some sysfs pieces via 9P :p

Several weeks ago, Viresh just wanted to continue the missing pieces
(which was: tex'ifying the spec and submitting to virtio TC), but then
unfortunately he invented something entirely different also put my name
on it.

Easy to imagine that I'm not amused at all.


--mtx

-- 
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

WARNING: multiple messages have this Message-ID (diff)
From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Linus Walleij <linus.walleij@linaro.org>,
	"Enrico Weigelt, metux IT consult" <info@metux.net>,
	Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	virtualization@lists.linux-foundation.org,
	linux-riscv <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] drivers: gpio: add virtio-gpio guest driver
Date: Wed, 16 Jun 2021 16:41:22 +0200	[thread overview]
Message-ID: <098f669f-b451-18e1-9aed-a71f400bd581@metux.net> (raw)
In-Reply-To: <CACRpkdbwLOOT6nuhpkT5x-AZVipsD2qG8Qu4xoiRotHQNknwzw@mail.gmail.com>

On 16.06.21 10:31, Linus Walleij wrote:
 > Hi Enrico,

 > So now there are two contesting patches for this and that creates a
 > social problem for us as maintainers. I am not too happy about that.

note that this is a polished up of a repost of my original driver
from last year.

 > Can we get the discussion down to actual technical points?

Sure. Perhaps you recall or discussions from late 2020. The missing
point there was (besides a few wording issues) the missing formal
specification process w/ virtio TC. (spec was already included in this
driver as well as the corresponding qemu patches).

My spec was not just meant for VM applications but also actual silicon
(as already mentioned, some folks of my client also implemented it in
FPGAs - don't ask me about details, they just mentioned it was quite
easy for them).

This is why it is so trimmed on things like fixed packet size,
unidirectional queues, mirroring packets w/ thus a few bits changed,
etc. In constrast, a more network-like approach might have been looking
nicer to traditional computer programmers, but much more complex to do
in pure logic and eat up *lots of* more gates (think of actual memory
management instead of hardwired latches, more complex decoding, etc).

Meanwhile it played out working nicely in several HIL installations

If I wanted to have a simple and CPU-only approach (just for VMs), I
would have just mounted some sysfs pieces via 9P :p

Several weeks ago, Viresh just wanted to continue the missing pieces
(which was: tex'ifying the spec and submitting to virtio TC), but then
unfortunately he invented something entirely different also put my name
on it.

Easy to imagine that I'm not amused at all.


--mtx

-- 
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2021-06-16 14:41 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 17:49 [PATCH] drivers: gpio: add virtio-gpio guest driver Enrico Weigelt, metux IT consult
2021-06-15 17:49 ` Enrico Weigelt, metux IT consult
2021-06-16  8:31 ` Linus Walleij
2021-06-16  8:31   ` Linus Walleij
2021-06-16  8:31   ` Linus Walleij
2021-06-16 11:49   ` Viresh Kumar
2021-06-16 11:49     ` Viresh Kumar
2021-06-16 11:49     ` Viresh Kumar
2021-06-16 15:04     ` Enrico Weigelt, metux IT consult
2021-06-16 15:04       ` Enrico Weigelt, metux IT consult
2021-06-17  3:59       ` Viresh Kumar
2021-06-17  3:59         ` Viresh Kumar
2021-06-17  3:59         ` Viresh Kumar
2021-06-17  9:54         ` Enrico Weigelt, metux IT consult
2021-06-17  9:54           ` Enrico Weigelt, metux IT consult
2021-06-17 11:47           ` Viresh Kumar
2021-06-17 11:47             ` Viresh Kumar
2021-06-17 11:47             ` Viresh Kumar
2021-06-16 14:41   ` Enrico Weigelt, metux IT consult [this message]
2021-06-16 14:41     ` Enrico Weigelt, metux IT consult
2021-06-16 18:47   ` banned on virtio list ? [Re: [PATCH] drivers: gpio: add virtio-gpio guest driver] Enrico Weigelt, metux IT consult
2021-06-16 18:47     ` [virtio-dev] " Enrico Weigelt, metux IT consult
2021-06-16 18:47     ` Enrico Weigelt, metux IT consult
2021-06-16 21:18     ` [virtio-dev] " Chet Ensign
2021-06-16 21:18       ` Chet Ensign
  -- strict thread matches above, loose matches on Subject: below --
2020-11-27 18:30 [PATCH] drivers: gpio: add virtio-gpio guest driver Enrico Weigelt, metux IT consult
2020-11-27 18:30 ` Enrico Weigelt, metux IT consult
2020-11-27 18:45 ` Randy Dunlap
2020-11-27 18:45   ` Randy Dunlap
2020-11-27 18:45   ` Randy Dunlap
2020-12-03 19:01   ` Enrico Weigelt, metux IT consult
2020-12-03 19:01     ` Enrico Weigelt, metux IT consult
2020-11-27 19:33 ` kernel test robot
2020-11-27 19:33   ` kernel test robot
2020-11-27 19:33   ` kernel test robot
2020-11-27 19:33   ` kernel test robot
2020-11-29 20:11 ` Michael S. Tsirkin
2020-11-29 20:11   ` Michael S. Tsirkin
2020-11-29 20:11   ` Michael S. Tsirkin
2020-11-29 22:10 ` Jonathan Neuschäfer
2020-11-29 22:10   ` Jonathan Neuschäfer
2020-11-29 22:10   ` Jonathan Neuschäfer
2020-12-03 19:12   ` Enrico Weigelt, metux IT consult
2020-12-03 19:12     ` Enrico Weigelt, metux IT consult
2020-12-02 14:15 ` Bartosz Golaszewski
2020-12-02 14:15   ` Bartosz Golaszewski
2020-12-03 19:00   ` Enrico Weigelt, metux IT consult
2020-12-03 19:00     ` Enrico Weigelt, metux IT consult
2020-12-03 22:35     ` Michael Walle
2020-12-03 22:35       ` Michael Walle
2020-12-04  8:28       ` Enrico Weigelt, metux IT consult
2020-12-04  8:28         ` Enrico Weigelt, metux IT consult
2020-12-04  9:06         ` Michael Walle
2020-12-04  9:06           ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=098f669f-b451-18e1-9aed-a71f400bd581@metux.net \
    --to=lkml@metux.net \
    --cc=anton@enomsg.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=ccross@android.com \
    --cc=corbet@lwn.net \
    --cc=info@metux.net \
    --cc=jasowang@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mst@redhat.com \
    --cc=tony.luck@intel.com \
    --cc=viresh.kumar@linaro.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.