[PATCH] MIPS: Use common outgoing-CPU-notification code

[PATCH] MIPS: Use common outgoing-CPU-notification code

[Marcin Nowakowski]

This commit removes the open-coded CPU-offline notification with new
common code.  In particular, this change avoids calling scheduler code
using RCU from an offline CPU that RCU is ignoring.

Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
---
 arch/mips/kernel/smp-cps.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c
index 6183ad8..51a18e9 100644
--- a/arch/mips/kernel/smp-cps.c
+++ b/arch/mips/kernel/smp-cps.c
@@ -404,7 +404,6 @@ static int cps_cpu_disable(void)
 	return 0;
 }
 
-static DECLARE_COMPLETION(cpu_death_chosen);
 static unsigned cpu_death_sibling;
 static enum {
 	CPU_DEATH_HALT,
@@ -440,7 +439,7 @@ void play_dead(void)
 	}
 
 	/* This CPU has chosen its way out */
-	complete(&cpu_death_chosen);
+	(void)cpu_report_death();
 
 	if (cpu_death == CPU_DEATH_HALT) {
 		vpe_id = cpu_vpe_id(&cpu_data[cpu]);
@@ -489,8 +488,7 @@ static void cps_cpu_die(unsigned int cpu)
 	int err;
 
 	/* Wait for the cpu to choose its way out */
-	if (!wait_for_completion_timeout(&cpu_death_chosen,
-					 msecs_to_jiffies(5000))) {
+	if (!cpu_wait_death(cpu, 5)) {
 		pr_err("CPU%u: didn't offline\n", cpu);
 		return;
 	}
-- 
2.7.4

[PATCH] MIPS: Use common outgoing-CPU-notification code

[Marcin Nowakowski]

This commit removes the open-coded CPU-offline notification with new
common code.  In particular, this change avoids calling scheduler code
using RCU from an offline CPU that RCU is ignoring.

Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
---
 arch/mips/kernel/smp-cps.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c
index 6183ad8..51a18e9 100644
--- a/arch/mips/kernel/smp-cps.c
+++ b/arch/mips/kernel/smp-cps.c
@@ -404,7 +404,6 @@ static int cps_cpu_disable(void)
 	return 0;
 }
 
-static DECLARE_COMPLETION(cpu_death_chosen);
 static unsigned cpu_death_sibling;
 static enum {
 	CPU_DEATH_HALT,
@@ -440,7 +439,7 @@ void play_dead(void)
 	}
 
 	/* This CPU has chosen its way out */
-	complete(&cpu_death_chosen);
+	(void)cpu_report_death();
 
 	if (cpu_death == CPU_DEATH_HALT) {
 		vpe_id = cpu_vpe_id(&cpu_data[cpu]);
@@ -489,8 +488,7 @@ static void cps_cpu_die(unsigned int cpu)
 	int err;
 
 	/* Wait for the cpu to choose its way out */
-	if (!wait_for_completion_timeout(&cpu_death_chosen,
-					 msecs_to_jiffies(5000))) {
+	if (!cpu_wait_death(cpu, 5)) {
 		pr_err("CPU%u: didn't offline\n", cpu);
 		return;
 	}
-- 
2.7.4

Re: [PATCH] MIPS: Use common outgoing-CPU-notification code

[Sergei Shtylyov]

Hello!

On 4/7/2017 1:12 PM, Marcin Nowakowski wrote:

> This commit removes the open-coded CPU-offline notification with new

    Replaces, perhaps?

> common code.  In particular, this change avoids calling scheduler code
> using RCU from an offline CPU that RCU is ignoring.
>
> Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
[...]

MBR, Sergei

Re: [PATCH] MIPS: Use common outgoing-CPU-notification code

[Marcin Nowakowski]

Hi,

On 07.04.2017 13:04, Sergei Shtylyov wrote:
> Hello!
>
> On 4/7/2017 1:12 PM, Marcin Nowakowski wrote:
>
>> This commit removes the open-coded CPU-offline notification with new
>
>    Replaces, perhaps?
>

Yeah, that will be better. I'll send an updated version.

thanks
Marcin

Re: [PATCH] MIPS: Use common outgoing-CPU-notification code

[Marcin Nowakowski]

Hi,

On 07.04.2017 13:04, Sergei Shtylyov wrote:
> Hello!
>
> On 4/7/2017 1:12 PM, Marcin Nowakowski wrote:
>
>> This commit removes the open-coded CPU-offline notification with new
>
>    Replaces, perhaps?
>

Yeah, that will be better. I'll send an updated version.

thanks
Marcin