All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: xen-front: remove unneeded switch fall-through
@ 2019-02-19  4:57 Li RongQing
  2019-02-19  6:56 ` Oleksandr Andrushchenko
  2019-02-19  6:56 ` Oleksandr Andrushchenko
  0 siblings, 2 replies; 3+ messages in thread
From: Li RongQing @ 2019-02-19  4:57 UTC (permalink / raw)
  To: alsa-devel, xen-devel, oleksandr_andrushchenko

This case block will be terminated by a break, so not need
a switch fall-through

Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 sound/xen/xen_snd_front.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
index a9e5c2cd7698..f12fb8eeaa27 100644
--- a/sound/xen/xen_snd_front.c
+++ b/sound/xen/xen_snd_front.c
@@ -250,7 +250,6 @@ static void sndback_changed(struct xenbus_device *xb_dev,
 	case XenbusStateReconfigured:
 		/* fall through */
 	case XenbusStateInitialised:
-		/* fall through */
 		break;
 
 	case XenbusStateInitialising:
-- 
2.16.2


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: xen-front: remove unneeded switch fall-through
  2019-02-19  4:57 [PATCH] ALSA: xen-front: remove unneeded switch fall-through Li RongQing
  2019-02-19  6:56 ` Oleksandr Andrushchenko
@ 2019-02-19  6:56 ` Oleksandr Andrushchenko
  1 sibling, 0 replies; 3+ messages in thread
From: Oleksandr Andrushchenko @ 2019-02-19  6:56 UTC (permalink / raw)
  To: Li RongQing, alsa-devel, xen-devel

On 2/19/19 6:57 AM, Li RongQing wrote:
> This case block will be terminated by a break, so not need
> a switch fall-through
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>   sound/xen/xen_snd_front.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
> index a9e5c2cd7698..f12fb8eeaa27 100644
> --- a/sound/xen/xen_snd_front.c
> +++ b/sound/xen/xen_snd_front.c
> @@ -250,7 +250,6 @@ static void sndback_changed(struct xenbus_device *xb_dev,
>   	case XenbusStateReconfigured:
>   		/* fall through */
>   	case XenbusStateInitialised:
> -		/* fall through */
>   		break;
>   
>   	case XenbusStateInitialising:
Thank you,
Oleksandr

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: xen-front: remove unneeded switch fall-through
  2019-02-19  4:57 [PATCH] ALSA: xen-front: remove unneeded switch fall-through Li RongQing
@ 2019-02-19  6:56 ` Oleksandr Andrushchenko
  2019-02-19  6:56 ` Oleksandr Andrushchenko
  1 sibling, 0 replies; 3+ messages in thread
From: Oleksandr Andrushchenko @ 2019-02-19  6:56 UTC (permalink / raw)
  To: Li RongQing, alsa-devel, xen-devel

On 2/19/19 6:57 AM, Li RongQing wrote:
> This case block will be terminated by a break, so not need
> a switch fall-through
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>   sound/xen/xen_snd_front.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
> index a9e5c2cd7698..f12fb8eeaa27 100644
> --- a/sound/xen/xen_snd_front.c
> +++ b/sound/xen/xen_snd_front.c
> @@ -250,7 +250,6 @@ static void sndback_changed(struct xenbus_device *xb_dev,
>   	case XenbusStateReconfigured:
>   		/* fall through */
>   	case XenbusStateInitialised:
> -		/* fall through */
>   		break;
>   
>   	case XenbusStateInitialising:
Thank you,
Oleksandr
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-19  6:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-19  4:57 [PATCH] ALSA: xen-front: remove unneeded switch fall-through Li RongQing
2019-02-19  6:56 ` Oleksandr Andrushchenko
2019-02-19  6:56 ` Oleksandr Andrushchenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.