All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: Drop CMDLINE_* dependency on ATAGS
@ 2022-09-27 13:28 ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-09-27 13:28 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Russell King, Linus Walleij, Ard Biesheuvel, Russell King, soc,
	linux-arm-kernel, linux-renesas-soc, linux-kernel,
	Geert Uytterhoeven

On arm32, the configuration options to specify the kernel command line
type depend on ATAGS.  However, the actual CMDLINE cofiguration option
does not depend on ATAGS, and the code that handles this is not specific
to ATAGS (see drivers/of/fdt.c:early_init_dt_scan_chosen()).

Hence users who desire to override the kernel command line on arm32 must
enable support for ATAGS, even on a pure-DT system.  Other architectures
(arm64, loongarch, microblaze, nios2, powerpc, and riscv) do not impose
such a restriction.

Hence drop the dependency on ATAGS.

Fixes: bd51e2f595580fb6 ("ARM: 7506/1: allow for ATAGS to be configured out when DT support is selected")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index ea8adbf25651438a..68923a69b1d41188 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1599,7 +1599,6 @@ config CMDLINE
 choice
 	prompt "Kernel command line type" if CMDLINE != ""
 	default CMDLINE_FROM_BOOTLOADER
-	depends on ATAGS
 
 config CMDLINE_FROM_BOOTLOADER
 	bool "Use bootloader kernel arguments if available"
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] ARM: Drop CMDLINE_* dependency on ATAGS
@ 2022-09-27 13:28 ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-09-27 13:28 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Russell King, Linus Walleij, Ard Biesheuvel, Russell King, soc,
	linux-arm-kernel, linux-renesas-soc, linux-kernel,
	Geert Uytterhoeven

On arm32, the configuration options to specify the kernel command line
type depend on ATAGS.  However, the actual CMDLINE cofiguration option
does not depend on ATAGS, and the code that handles this is not specific
to ATAGS (see drivers/of/fdt.c:early_init_dt_scan_chosen()).

Hence users who desire to override the kernel command line on arm32 must
enable support for ATAGS, even on a pure-DT system.  Other architectures
(arm64, loongarch, microblaze, nios2, powerpc, and riscv) do not impose
such a restriction.

Hence drop the dependency on ATAGS.

Fixes: bd51e2f595580fb6 ("ARM: 7506/1: allow for ATAGS to be configured out when DT support is selected")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index ea8adbf25651438a..68923a69b1d41188 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1599,7 +1599,6 @@ config CMDLINE
 choice
 	prompt "Kernel command line type" if CMDLINE != ""
 	default CMDLINE_FROM_BOOTLOADER
-	depends on ATAGS
 
 config CMDLINE_FROM_BOOTLOADER
 	bool "Use bootloader kernel arguments if available"
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: Drop CMDLINE_* dependency on ATAGS
  2022-09-27 13:28 ` Geert Uytterhoeven
@ 2022-09-27 13:34   ` Ard Biesheuvel
  -1 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2022-09-27 13:34 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Arnd Bergmann, Russell King, Linus Walleij, Russell King, soc,
	linux-arm-kernel, linux-renesas-soc, linux-kernel

On Tue, 27 Sept 2022 at 15:28, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> On arm32, the configuration options to specify the kernel command line
> type depend on ATAGS.  However, the actual CMDLINE cofiguration option
> does not depend on ATAGS, and the code that handles this is not specific
> to ATAGS (see drivers/of/fdt.c:early_init_dt_scan_chosen()).
>
> Hence users who desire to override the kernel command line on arm32 must
> enable support for ATAGS, even on a pure-DT system.  Other architectures
> (arm64, loongarch, microblaze, nios2, powerpc, and riscv) do not impose
> such a restriction.
>
> Hence drop the dependency on ATAGS.
>
> Fixes: bd51e2f595580fb6 ("ARM: 7506/1: allow for ATAGS to be configured out when DT support is selected")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  arch/arm/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index ea8adbf25651438a..68923a69b1d41188 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1599,7 +1599,6 @@ config CMDLINE
>  choice
>         prompt "Kernel command line type" if CMDLINE != ""
>         default CMDLINE_FROM_BOOTLOADER
> -       depends on ATAGS
>
>  config CMDLINE_FROM_BOOTLOADER
>         bool "Use bootloader kernel arguments if available"
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: Drop CMDLINE_* dependency on ATAGS
@ 2022-09-27 13:34   ` Ard Biesheuvel
  0 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2022-09-27 13:34 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Arnd Bergmann, Russell King, Linus Walleij, Russell King, soc,
	linux-arm-kernel, linux-renesas-soc, linux-kernel

On Tue, 27 Sept 2022 at 15:28, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> On arm32, the configuration options to specify the kernel command line
> type depend on ATAGS.  However, the actual CMDLINE cofiguration option
> does not depend on ATAGS, and the code that handles this is not specific
> to ATAGS (see drivers/of/fdt.c:early_init_dt_scan_chosen()).
>
> Hence users who desire to override the kernel command line on arm32 must
> enable support for ATAGS, even on a pure-DT system.  Other architectures
> (arm64, loongarch, microblaze, nios2, powerpc, and riscv) do not impose
> such a restriction.
>
> Hence drop the dependency on ATAGS.
>
> Fixes: bd51e2f595580fb6 ("ARM: 7506/1: allow for ATAGS to be configured out when DT support is selected")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  arch/arm/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index ea8adbf25651438a..68923a69b1d41188 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1599,7 +1599,6 @@ config CMDLINE
>  choice
>         prompt "Kernel command line type" if CMDLINE != ""
>         default CMDLINE_FROM_BOOTLOADER
> -       depends on ATAGS
>
>  config CMDLINE_FROM_BOOTLOADER
>         bool "Use bootloader kernel arguments if available"
> --
> 2.25.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: Drop CMDLINE_* dependency on ATAGS
  2022-09-27 13:28 ` Geert Uytterhoeven
  (?)
  (?)
@ 2022-09-28 21:00 ` patchwork-bot+linux-soc
  -1 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+linux-soc @ 2022-09-28 21:00 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: soc

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Tue, 27 Sep 2022 15:28:26 +0200 you wrote:
> On arm32, the configuration options to specify the kernel command line
> type depend on ATAGS.  However, the actual CMDLINE cofiguration option
> does not depend on ATAGS, and the code that handles this is not specific
> to ATAGS (see drivers/of/fdt.c:early_init_dt_scan_chosen()).
> 
> Hence users who desire to override the kernel command line on arm32 must
> enable support for ATAGS, even on a pure-DT system.  Other architectures
> (arm64, loongarch, microblaze, nios2, powerpc, and riscv) do not impose
> such a restriction.
> 
> [...]

Here is the summary with links:
  - ARM: Drop CMDLINE_* dependency on ATAGS
    https://git.kernel.org/soc/soc/c/136f4b1ec7c9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-28 21:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 13:28 [PATCH] ARM: Drop CMDLINE_* dependency on ATAGS Geert Uytterhoeven
2022-09-27 13:28 ` Geert Uytterhoeven
2022-09-27 13:34 ` Ard Biesheuvel
2022-09-27 13:34   ` Ard Biesheuvel
2022-09-28 21:00 ` patchwork-bot+linux-soc

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.