Re: [PATCH-for-5.1] gdbstub: Rename GByteArray variable 'mem_buf' as 'array' - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"David Hildenbrand" <david@redhat.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Marek Vasut" <marex@denx.de>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	qemu-ppc@nongnu.org,
	"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
	"Stafford Horne" <shorne@gmail.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>,
	qemu-riscv@nongnu.org,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Chris Wulff" <crwulff@gmail.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Michael Walle" <michael@walle.cc>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH-for-5.1] gdbstub: Rename GByteArray variable 'mem_buf' as 'array'
Date: Tue, 14 Apr 2020 13:35:17 +0200	[thread overview]
Message-ID: <09f9ae36-f8e9-8412-cd97-f3f386907b6f@redhat.com> (raw)
In-Reply-To: <20200414112849.21787-1-philmd@redhat.com>

On 4/14/20 1:28 PM, Philippe Mathieu-Daudé wrote:
> GByteArray type has should not be treated as a u8[] buffer.
> The GLib Byte Arrays API should be used instead.
> Rename the 'mem_buf' variable as 'array' to make it more
> obvious in the code.

I forgot to mention this variable was used as u8[] buffer prior to 
commit a010bdbe719 ("extend GByteArray to read register helpers").

> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20200414111846.27495-1-philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   include/exec/gdbstub.h      | 34 +++++++-------
>   include/hw/core/cpu.h       |  2 +-
>   target/alpha/cpu.h          |  2 +-
>   target/arm/cpu.h            |  4 +-
>   target/cris/cpu.h           |  4 +-
>   target/hppa/cpu.h           |  2 +-
>   target/i386/cpu.h           |  2 +-
>   target/lm32/cpu.h           |  2 +-
>   target/m68k/cpu.h           |  2 +-
>   target/microblaze/cpu.h     |  2 +-
>   target/mips/internal.h      |  2 +-
>   target/openrisc/cpu.h       |  2 +-
>   target/ppc/cpu.h            |  4 +-
>   target/riscv/cpu.h          |  2 +-
>   target/rx/cpu.h             |  2 +-
>   target/s390x/internal.h     |  2 +-
>   target/sh4/cpu.h            |  2 +-
>   target/sparc/cpu.h          |  2 +-
>   target/xtensa/cpu.h         |  2 +-
>   gdbstub.c                   |  6 +--
>   hw/core/cpu.c               |  3 +-
>   target/alpha/gdbstub.c      |  4 +-
>   target/arm/gdbstub.c        | 10 ++--
>   target/arm/gdbstub64.c      | 10 ++--
>   target/cris/gdbstub.c       | 34 +++++++-------
>   target/hppa/gdbstub.c       |  6 +--
>   target/i386/gdbstub.c       | 92 ++++++++++++++++++-------------------
>   target/lm32/gdbstub.c       | 18 ++++----
>   target/m68k/gdbstub.c       | 10 ++--
>   target/m68k/helper.c        | 24 +++++-----
>   target/microblaze/gdbstub.c |  6 +--
>   target/mips/gdbstub.c       | 30 ++++++------
>   target/nios2/cpu.c          |  8 ++--
>   target/openrisc/gdbstub.c   | 10 ++--
>   target/riscv/gdbstub.c      |  6 +--
>   target/rx/gdbstub.c         | 22 ++++-----
>   target/s390x/gdbstub.c      | 28 +++++------
>   target/sh4/gdbstub.c        | 38 +++++++--------
>   target/sparc/gdbstub.c      | 46 +++++++++----------
>   target/xtensa/gdbstub.c     | 20 ++++----
>   40 files changed, 254 insertions(+), 253 deletions(-)