All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: <jaegeuk@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>,
	<linux-kernel@vger.kernel.org>, <chao@kernel.org>
Subject: Re: [PATCH] f2fs: set deadline to drop expired inmem pages
Date: Tue, 10 Apr 2018 15:38:55 +0800	[thread overview]
Message-ID: <09fd3144-d1c5-ca02-178d-b467d6fbe0e1@huawei.com> (raw)
In-Reply-To: <20180408081312.6190-1-yuchao0@huawei.com>

Hi Jaegeuk,

On 2018/4/8 16:13, Chao Yu wrote:
> f2fs doesn't allow abuse on atomic write class interface, so except
> limiting in-mem pages' total memory usage capacity, we need to limit
> start-commit time as well, otherwise we may run into infinite loop
> during foreground GC because target blocks in victim segment are
> belong to atomic opened file for long time.
> 
> Now, we will check the condition with f2fs_balance_fs_bg in
> background threads, once if user doesn't commit data exceeding 30
> seconds, we will drop all cached data, so I expect it can keep our
> system running safely to prevent Dos attack.

Is it worth to add this patch to avoid abuse on atomic write interface by user?
Thanks,

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH] f2fs: set deadline to drop expired inmem pages
Date: Tue, 10 Apr 2018 15:38:55 +0800	[thread overview]
Message-ID: <09fd3144-d1c5-ca02-178d-b467d6fbe0e1@huawei.com> (raw)
In-Reply-To: <20180408081312.6190-1-yuchao0@huawei.com>

Hi Jaegeuk,

On 2018/4/8 16:13, Chao Yu wrote:
> f2fs doesn't allow abuse on atomic write class interface, so except
> limiting in-mem pages' total memory usage capacity, we need to limit
> start-commit time as well, otherwise we may run into infinite loop
> during foreground GC because target blocks in victim segment are
> belong to atomic opened file for long time.
> 
> Now, we will check the condition with f2fs_balance_fs_bg in
> background threads, once if user doesn't commit data exceeding 30
> seconds, we will drop all cached data, so I expect it can keep our
> system running safely to prevent Dos attack.

Is it worth to add this patch to avoid abuse on atomic write interface by user?
Thanks,

  reply	other threads:[~2018-04-10  7:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-08  8:13 [PATCH] f2fs: set deadline to drop expired inmem pages Chao Yu
2018-04-08  8:13 ` Chao Yu
2018-04-10  7:38 ` Chao Yu [this message]
2018-04-10  7:38   ` Chao Yu
2018-04-13  1:04   ` Jaegeuk Kim
2018-04-13  1:25     ` Chao Yu
2018-04-13  1:25       ` Chao Yu
2018-04-13  4:05       ` Jaegeuk Kim
2018-04-13  6:08         ` Chao Yu
2018-04-13  6:08           ` Chao Yu
2018-04-16 20:16           ` Jaegeuk Kim
2018-04-17  6:44             ` Chao Yu
2018-04-17  6:44               ` Chao Yu
2018-04-17 11:45               ` Chao Yu
2018-04-17 11:45                 ` Chao Yu
2018-04-18  4:14                 ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09fd3144-d1c5-ca02-178d-b467d6fbe0e1@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.