Re: [meta-oe][PATCH 1/1] busybox: remove bbappend

[Khem Raj <raj.khem@gmail.com>]

On Aug 23, 2013, at 4:33 AM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:

> This bbappend has effectively been merged into OE-Core, although the
> log buffer size is the busybox default rather than 64K - layers may
> change this either by providing their own /etc/default/busybox-syslog
> file (when using systemd) or modifying the
> CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time
> config

I think it would be better if we added this option via a kconfig fragment
in OE-Core if DISTRO_FEATURES contained systemd and then remove this from
here. I say this because otherwise size of circular buffer goes back to 16k
from 64k and may not be enough to hold valuable info. On modern systems I
think we can afford 64k. I would even argue to make it default in busybox.
having said that, busybox-syslogd may be redundant when using systemd since
we have journald with systemd but there might still be lot of use cases
of busybox-syslogd. Either of these above approaches are fine with me.

> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> meta-oe/recipes-core/busybox/busybox/busybox-syslog.default |  1 -
> meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend        | 11 -----------
> 2 files changed, 12 deletions(-)
> delete mode 100644 meta-oe/recipes-core/busybox/busybox/busybox-syslog.default
> delete mode 100644 meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
> 
> diff --git a/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default b/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default
> deleted file mode 100644
> index 8a21e6d..0000000
> --- a/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default
> +++ /dev/null
> @@ -1 +0,0 @@
> -OPTIONS="-C64"
> diff --git a/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend b/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
> deleted file mode 100644
> index 7a2f0c3..0000000
> --- a/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -# look for files in the layer first
> -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> -
> -SRC_URI += "file://busybox-syslog.default"
> -
> -do_install_append() {
> -    install -d ${D}${sysconfdir}/default
> -    install -m 0644 ${WORKDIR}/busybox-syslog.default ${D}${sysconfdir}/default/busybox-syslog
> -}
> -
> -FILES_${PN}-syslog += "${sysconfdir}/default/busybox-syslog"
> -- 
> 1.8.1.2
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel