Re: [meta-oe][PATCH 1/1] busybox: remove bbappend

[Khem Raj <raj.khem@gmail.com>]

On Aug 26, 2013, at 2:53 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:

> On Monday 26 August 2013 14:39:10 Khem Raj wrote:
>> On Aug 24, 2013, at 2:47 AM, Paul Eggleton <paul.eggleton@linux.intel.com>
>> wrote:
>>> On Friday 23 August 2013 10:36:15 Khem Raj wrote:
>>>> On Aug 23, 2013, at 4:33 AM, Paul Eggleton
>>>> <paul.eggleton@linux.intel.com> wrote:
>>>>> This bbappend has effectively been merged into OE-Core, although the
>>>>> log buffer size is the busybox default rather than 64K - layers may
>>>>> change this either by providing their own /etc/default/busybox-syslog
>>>>> file (when using systemd) or modifying the
>>>>> CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time
>>>>> config
>>>> 
>>>> I think it would be better if we added this option via a kconfig fragment
>>>> in OE-Core if DISTRO_FEATURES contained systemd and then remove this from
>>>> here. I say this because otherwise size of circular buffer goes back to
>>>> 16k from 64k and may not be enough to hold valuable info.
>>> 
>>> Why is this specific to systemd?
>> 
>> It probably is not. Otavio added it, so I am CCing him
>> however this is default used in many distros, just to keep enough
>> messages around while you can affort 64K buffer which is not a huge ask
>> these days.
> 
> If it's generally useful and not specific to systemd (and it seems it isn't the 
> latter) I'd have to say I agree, let's set the default in our busybox 
> defconfig.
> 

I have no issues with changed the defconfig.

> Cheers,
> Paul
> 
> -- 
> 
> Paul Eggleton
> Intel Open Source Technology Centre