From: Vijay Khemka <vijaykhemka@fb.com>
To: Ed Tanous <ed.tanous@intel.com>, Patrick Venture <venture@google.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: pid control configuration
Date: Fri, 31 May 2019 21:00:10 +0000 [thread overview]
Message-ID: <0AA4F6A3-830C-4F62-A8B5-7D26BF65A16C@fb.com> (raw)
In-Reply-To: <945b4275-2441-8562-7efe-5bc7a9eca4f7@intel.com>
On 5/15/19, 2:50 PM, "Ed Tanous" <ed.tanous@intel.com> wrote:
On 5/15/19 12:21 PM, Vijay Khemka wrote:
>
>
> Ed, please see if following declaration in entity manager would work as I am not defining any pid values here.
> {
> "Class": "fan",
> "Inputs": [
> "MB_FAN0_TACH"
> ],
> "Name": "MB_FAN0_TACH",
> "Outputs": [
> "Pwm 1"
> ],
> "Type": "Pid",
> "Zones": [
> "Pid 1"
> ]
> },
>
> >>
> >> Regards
> >> -Vijay
> >>
>
>
I'm assuming you loaded this on a system. If it gave you the behavior
you're looking for, you're done. If it didn't, it's probably time to
start debugging and tuning.
This config is failing with below message.
Apr 12 23:32:39 tiogapass swampd[1310]: terminate called after throwing an instance of 'std::out_of_range'
Apr 12 23:32:39 tiogapass swampd[1310]: what(): _Map_base::at
Is there any default data which I can be used for config but has no impact in its action?
I run my systems in the cascade controller setup. If you're deviating
from that, you'll likely find some places that need better documentation
and code improvements.
next prev parent reply other threads:[~2019-05-31 21:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 22:53 pid control configuration Vijay Khemka
2019-05-01 23:05 ` Ed Tanous
2019-05-01 23:10 ` Patrick Venture
2019-05-01 23:15 ` Patrick Venture
2019-05-02 23:24 ` Vijay Khemka
2019-05-06 16:20 ` Ed Tanous
2019-05-06 18:18 ` Vijay Khemka
2019-05-06 18:54 ` Ed Tanous
2019-05-10 21:20 ` Vijay Khemka
2019-05-13 16:32 ` Patrick Venture
2019-05-13 17:32 ` Ed Tanous
2019-05-15 19:21 ` Vijay Khemka
2019-05-15 21:50 ` Ed Tanous
2019-05-16 0:07 ` Vijay Khemka
2019-05-31 21:00 ` Vijay Khemka [this message]
2019-06-03 17:43 ` Ed Tanous
2019-06-03 18:18 ` Vijay Khemka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0AA4F6A3-830C-4F62-A8B5-7D26BF65A16C@fb.com \
--to=vijaykhemka@fb.com \
--cc=ed.tanous@intel.com \
--cc=openbmc@lists.ozlabs.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.