From: Vijay Khemka <vijaykhemka@fb.com>
To: Ed Tanous <ed.tanous@intel.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: pid control configuration
Date: Fri, 10 May 2019 21:20:38 +0000 [thread overview]
Message-ID: <14F05B01-0B7D-44D1-A599-5EDD8CC3A6C8@fb.com> (raw)
In-Reply-To: <1b82951d-4293-0525-a562-000899544c2e@intel.com>
On 5/6/19, 9:20 AM, "Ed Tanous" <ed.tanous@intel.com> wrote:
On 5/2/19 4:24 PM, Vijay Khemka wrote:
> My understanding here is pid data are only defined for temp sensors which will generate pwm values for fan.
>
The above is not how phosphor pid control operates. The temperature
controllers "request" a given fan RPM, then the fan PID controller
(which is scanned much more quickly than the temperature controllers)
attempts to drive the fan to that speed. This ends up being a two stage
feedback loop that can perform better than a single PID loop.
Ed, we are not using cascade control here in facebook. We only use outer loop which gives data for fan to drive.
Is it possible to still run Phosphor pid controller with single loop?
Regards
-Vijay
next prev parent reply other threads:[~2019-05-10 21:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 22:53 pid control configuration Vijay Khemka
2019-05-01 23:05 ` Ed Tanous
2019-05-01 23:10 ` Patrick Venture
2019-05-01 23:15 ` Patrick Venture
2019-05-02 23:24 ` Vijay Khemka
2019-05-06 16:20 ` Ed Tanous
2019-05-06 18:18 ` Vijay Khemka
2019-05-06 18:54 ` Ed Tanous
2019-05-10 21:20 ` Vijay Khemka [this message]
2019-05-13 16:32 ` Patrick Venture
2019-05-13 17:32 ` Ed Tanous
2019-05-15 19:21 ` Vijay Khemka
2019-05-15 21:50 ` Ed Tanous
2019-05-16 0:07 ` Vijay Khemka
2019-05-31 21:00 ` Vijay Khemka
2019-06-03 17:43 ` Ed Tanous
2019-06-03 18:18 ` Vijay Khemka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14F05B01-0B7D-44D1-A599-5EDD8CC3A6C8@fb.com \
--to=vijaykhemka@fb.com \
--cc=ed.tanous@intel.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.