From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Ian Jackson" <iwj@xenproject.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"Oleksandr_Andrushchenko@epam.com"
<Oleksandr_Andrushchenko@epam.com>, "Paul Durrant" <paul@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
Date: Tue, 19 Oct 2021 11:32:38 +0000 [thread overview]
Message-ID: <0B9FADC4-6375-4069-8444-43346879F585@arm.com> (raw)
In-Reply-To: <4471eef0-5dfc-876d-5f4b-e5b163032210@suse.com>
Hi Jan,
> On 19 Oct 2021, at 12:25, Jan Beulich <jbeulich@suse.com> wrote:
>
> On 19.10.2021 13:12, Ian Jackson wrote:
>> Bertrand Marquis writes ("[PATCH 0/3] Fixes: PCI devices passthrough on Arm"):
>>> This patch serie is a follow-up after various findings on d59168dc05
>>> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
>>> agreed in [1].
>>>
>>> It does the following:
>>> - enable vpci_add_handlers on x86 and not only on arm
>>> - remove __hwdom_init flag for vpci_add_handlers
>>> - add missing vpci handler cleanup in error path during pci_device_add
>>> and pci_device_remove
>>
>> Thanks. Roger, Jan, what do you think of this ?
>
> I'll get to this, but at the first glance I'd say that the change in
> patch 1 coming before what patch 2 does is already a problem.
Because path 1 is actually introducing a bug solved by patch 2, I should have thought of that.
I can either invert those 2 (or actually put patch 1 at the end) or merge patch 1 and 2 together.
Bertrand
>
> Jan
>
next prev parent reply other threads:[~2021-10-19 11:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 10:40 [PATCH 0/3] Fixes: PCI devices passthrough on Arm Bertrand Marquis
2021-10-19 10:40 ` [PATCH 1/3] xen/arm: call vpci_add_handlers on x86 Bertrand Marquis
2021-10-19 12:29 ` Jan Beulich
2021-10-19 13:05 ` Bertrand Marquis
2021-10-19 10:40 ` [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers Bertrand Marquis
2021-10-19 12:39 ` Jan Beulich
2021-10-19 13:17 ` Roger Pau Monné
2021-10-19 13:20 ` Jan Beulich
2021-10-19 13:43 ` Bertrand Marquis
2021-10-19 10:40 ` [PATCH 3/3] xen/pci: Add missing vpci handler cleanup Bertrand Marquis
2021-10-19 11:12 ` [PATCH 0/3] Fixes: PCI devices passthrough on Arm Ian Jackson
2021-10-19 11:25 ` Jan Beulich
2021-10-19 11:32 ` Bertrand Marquis [this message]
2021-10-19 12:26 ` Jan Beulich
2021-10-19 13:11 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0B9FADC4-6375-4069-8444-43346879F585@arm.com \
--to=bertrand.marquis@arm.com \
--cc=Oleksandr_Andrushchenko@epam.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.