All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: iwj@xenproject.org, sstabellini@kernel.org,
	Oleksandr_Andrushchenko@epam.com,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers
Date: Tue, 19 Oct 2021 14:39:17 +0200	[thread overview]
Message-ID: <116f5313-f2a3-376b-a0a3-af0d14d82125@suse.com> (raw)
In-Reply-To: <33b03be7eeea521953790542eb31d5a1386d2b81.1634639117.git.bertrand.marquis@arm.com>

On 19.10.2021 12:40, Bertrand Marquis wrote:
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -54,7 +54,7 @@ void vpci_remove_device(struct pci_dev *pdev)
>      pdev->vpci = NULL;
>  }
>  
> -int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
> +int vpci_add_handlers(struct pci_dev *pdev)

A fundamental requirement when altering section attributes is to
also check that all referenced entities are appropriately placed.
Afaict this is not the case for __start_vpci_array[], and you'll
need to also adjust linker scripts to deal with that. Further
you'd have to check that all functions referenced by that array
aren't __hwdom_init. In taking an example (init_msi()) I'm
actually surprised to find it's not marked __hwdom_init. So
maybe all is fine as far as these are concerned.

Jan



  reply	other threads:[~2021-10-19 12:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 10:40 [PATCH 0/3] Fixes: PCI devices passthrough on Arm Bertrand Marquis
2021-10-19 10:40 ` [PATCH 1/3] xen/arm: call vpci_add_handlers on x86 Bertrand Marquis
2021-10-19 12:29   ` Jan Beulich
2021-10-19 13:05     ` Bertrand Marquis
2021-10-19 10:40 ` [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers Bertrand Marquis
2021-10-19 12:39   ` Jan Beulich [this message]
2021-10-19 13:17     ` Roger Pau Monné
2021-10-19 13:20       ` Jan Beulich
2021-10-19 13:43       ` Bertrand Marquis
2021-10-19 10:40 ` [PATCH 3/3] xen/pci: Add missing vpci handler cleanup Bertrand Marquis
2021-10-19 11:12 ` [PATCH 0/3] Fixes: PCI devices passthrough on Arm Ian Jackson
2021-10-19 11:25   ` Jan Beulich
2021-10-19 11:32     ` Bertrand Marquis
2021-10-19 12:26 ` Jan Beulich
2021-10-19 13:11   ` Bertrand Marquis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=116f5313-f2a3-376b-a0a3-af0d14d82125@suse.com \
    --to=jbeulich@suse.com \
    --cc=Oleksandr_Andrushchenko@epam.com \
    --cc=bertrand.marquis@arm.com \
    --cc=iwj@xenproject.org \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.