* [patch] iwlwifi: mvm: catch underflow error earlier
@ 2015-08-21 8:48 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-08-21 8:48 UTC (permalink / raw)
To: Johannes Berg
Cc: Emmanuel Grumbach, Intel Linux Wireless, Kalle Valo,
Luciano Coelho, Eliad Peller, Liad Kaufman, Matti Gottlieb,
Alexander Bondar, linux-wireless, kernel-janitors
My static checker complains that we don't check for underflows in
iwl_dbgfs_fw_dbg_conf_write(). This is harmless because we have a
sanity check in iwl_mvm_start_fw_dbg_conf(), but we may as well make
this unsigned and silence the underflow warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/iwlwifi/mvm/debugfs.c
index ca4a1f8..7d69a55 100644
--- a/drivers/net/wireless/iwlwifi/mvm/debugfs.c
+++ b/drivers/net/wireless/iwlwifi/mvm/debugfs.c
@@ -949,9 +949,10 @@ static ssize_t iwl_dbgfs_fw_dbg_conf_write(struct iwl_mvm *mvm,
char *buf, size_t count,
loff_t *ppos)
{
- int ret, conf_id;
+ unsigned int conf_id;
+ int ret;
- ret = kstrtoint(buf, 0, &conf_id);
+ ret = kstrtouint(buf, 0, &conf_id);
if (ret)
return ret;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [patch] iwlwifi: mvm: catch underflow error earlier
@ 2015-08-21 8:48 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-08-21 8:48 UTC (permalink / raw)
To: Johannes Berg
Cc: Emmanuel Grumbach, Intel Linux Wireless, Kalle Valo,
Luciano Coelho, Eliad Peller, Liad Kaufman, Matti Gottlieb,
Alexander Bondar, linux-wireless, kernel-janitors
My static checker complains that we don't check for underflows in
iwl_dbgfs_fw_dbg_conf_write(). This is harmless because we have a
sanity check in iwl_mvm_start_fw_dbg_conf(), but we may as well make
this unsigned and silence the underflow warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/iwlwifi/mvm/debugfs.c
index ca4a1f8..7d69a55 100644
--- a/drivers/net/wireless/iwlwifi/mvm/debugfs.c
+++ b/drivers/net/wireless/iwlwifi/mvm/debugfs.c
@@ -949,9 +949,10 @@ static ssize_t iwl_dbgfs_fw_dbg_conf_write(struct iwl_mvm *mvm,
char *buf, size_t count,
loff_t *ppos)
{
- int ret, conf_id;
+ unsigned int conf_id;
+ int ret;
- ret = kstrtoint(buf, 0, &conf_id);
+ ret = kstrtouint(buf, 0, &conf_id);
if (ret)
return ret;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] iwlwifi: mvm: catch underflow error earlier
2015-08-21 8:48 ` Dan Carpenter
(?)
@ 2015-08-22 17:25 ` Grumbach, Emmanuel
-1 siblings, 0 replies; 3+ messages in thread
From: Grumbach, Emmanuel @ 2015-08-22 17:25 UTC (permalink / raw)
To: Dan Carpenter, Berg, Johannes
Cc: Intel Linux Wireless, Kalle Valo, Coelho, Luciano, Eliad Peller,
Kaufman, Liad, Gottlieb, Matti, Bondar, Alexander,
linux-wireless, kernel-janitors
Hi Dan,
On 08/21/2015 11:49 AM, Dan Carpenter wrote:
> My static checker complains that we don't check for underflows in
> iwl_dbgfs_fw_dbg_conf_write(). This is harmless because we have a
> sanity check in iwl_mvm_start_fw_dbg_conf(), but we may as well make
> this unsigned and silence the underflow warning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Applied in our internal tree. Thanks.
> diff --git a/drivers/net/wireless/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/iwlwifi/mvm/debugfs.c
> index ca4a1f8..7d69a55 100644
> --- a/drivers/net/wireless/iwlwifi/mvm/debugfs.c
> +++ b/drivers/net/wireless/iwlwifi/mvm/debugfs.c
> @@ -949,9 +949,10 @@ static ssize_t iwl_dbgfs_fw_dbg_conf_write(struct iwl_mvm *mvm,
> char *buf, size_t count,
> loff_t *ppos)
> {
> - int ret, conf_id;
> + unsigned int conf_id;
> + int ret;
>
> - ret = kstrtoint(buf, 0, &conf_id);
> + ret = kstrtouint(buf, 0, &conf_id);
> if (ret)
> return ret;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-22 17:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-21 8:48 [patch] iwlwifi: mvm: catch underflow error earlier Dan Carpenter
2015-08-21 8:48 ` Dan Carpenter
2015-08-22 17:25 ` Grumbach, Emmanuel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.