* [PATCH] iwlwifi: fix erroneous return value
@ 2016-02-10 17:08 Anton Protopopov
2016-02-11 6:36 ` Grumbach, Emmanuel
0 siblings, 1 reply; 2+ messages in thread
From: Anton Protopopov @ 2016-02-10 17:08 UTC (permalink / raw)
To: Johannes Berg, Emmanuel Grumbach, Kalle Valo, Eran Harary
Cc: Intel Linux Wireless, linux-wireless, netdev, linux-kernel,
Anton Protopopov
The iwl_trans_pcie_start_fw() function may return the positive value EIO
instead of -EIO in case of error.
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
---
drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
index d60a467..920ea9d 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
@@ -1034,7 +1034,7 @@ static int iwl_trans_pcie_start_fw(struct iwl_trans *trans,
if (trans_pcie->is_down) {
IWL_WARN(trans,
"Can't start_fw since the HW hasn't been started\n");
- ret = EIO;
+ ret = -EIO;
goto out;
}
--
2.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iwlwifi: fix erroneous return value
2016-02-10 17:08 [PATCH] iwlwifi: fix erroneous return value Anton Protopopov
@ 2016-02-11 6:36 ` Grumbach, Emmanuel
0 siblings, 0 replies; 2+ messages in thread
From: Grumbach, Emmanuel @ 2016-02-11 6:36 UTC (permalink / raw)
To: Anton Protopopov, Berg, Johannes, Kalle Valo, Eran Harary
Cc: linuxwifi, linux-wireless, netdev, linux-kernel
On 02/10/2016 07:10 PM, Anton Protopopov wrote:
> The iwl_trans_pcie_start_fw() function may return the positive value EIO
> instead of -EIO in case of error.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
> ---
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> index d60a467..920ea9d 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
> @@ -1034,7 +1034,7 @@ static int iwl_trans_pcie_start_fw(struct iwl_trans *trans,
> if (trans_pcie->is_down) {
> IWL_WARN(trans,
> "Can't start_fw since the HW hasn't been started\n");
> - ret = EIO;
> + ret = -EIO;
> goto out;
> }
>
applied - thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-11 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 17:08 [PATCH] iwlwifi: fix erroneous return value Anton Protopopov
2016-02-11 6:36 ` Grumbach, Emmanuel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.