* [PATCH] mac80211_hwsim: Set global RRM capability
@ 2016-02-25 9:24 Emmanuel Grumbach
2016-02-25 10:01 ` kbuild test robot
2016-03-02 12:24 ` Johannes Berg
0 siblings, 2 replies; 9+ messages in thread
From: Emmanuel Grumbach @ 2016-02-25 9:24 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, David Spinadel, Emmanuel Grumbach
From: David Spinadel <david.spinadel@intel.com>
Allow publishing RRM capabilities for features that are not
HW dependent.
Signed-off-by: David Spinadel <david.spinadel@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
drivers/net/wireless/mac80211_hwsim.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index ee37af1..ff45688 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -2458,6 +2458,7 @@ static int mac80211_hwsim_new_radio(struct genl_info *info,
NL80211_FEATURE_DYNAMIC_SMPS |
NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR;
wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_VHT_IBSS);
+ wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_RRM);
/* ask mac80211 to reserve space for magic */
hw->vif_data_size = sizeof(struct hwsim_vif_priv);
--
2.5.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] mac80211_hwsim: Set global RRM capability
2016-02-25 9:24 [PATCH] mac80211_hwsim: Set global RRM capability Emmanuel Grumbach
@ 2016-02-25 10:01 ` kbuild test robot
2016-02-26 7:17 ` Kalle Valo
2016-03-02 12:24 ` Johannes Berg
1 sibling, 1 reply; 9+ messages in thread
From: kbuild test robot @ 2016-02-25 10:01 UTC (permalink / raw)
To: Emmanuel Grumbach
Cc: kbuild-all, johannes, linux-wireless, David Spinadel, Emmanuel Grumbach
[-- Attachment #1: Type: text/plain, Size: 1999 bytes --]
Hi David,
[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.5-rc5 next-20160224]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/mac80211_hwsim-Set-global-RRM-capability/20160225-172733
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: sparc64-allyesconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64
All errors (new ones prefixed by >>):
drivers/net/wireless/mac80211_hwsim.c: In function 'mac80211_hwsim_new_radio':
>> drivers/net/wireless/mac80211_hwsim.c:2462:35: error: 'NL80211_EXT_FEATURE_RRM' undeclared (first use in this function)
wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_RRM);
^
drivers/net/wireless/mac80211_hwsim.c:2462:35: note: each undeclared identifier is reported only once for each function it appears in
vim +/NL80211_EXT_FEATURE_RRM +2462 drivers/net/wireless/mac80211_hwsim.c
2456 hw->wiphy->features |= NL80211_FEATURE_ACTIVE_MONITOR |
2457 NL80211_FEATURE_AP_MODE_CHAN_WIDTH_CHANGE |
2458 NL80211_FEATURE_STATIC_SMPS |
2459 NL80211_FEATURE_DYNAMIC_SMPS |
2460 NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR;
2461 wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_VHT_IBSS);
> 2462 wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_RRM);
2463
2464 /* ask mac80211 to reserve space for magic */
2465 hw->vif_data_size = sizeof(struct hwsim_vif_priv);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 45113 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mac80211_hwsim: Set global RRM capability
2016-02-25 10:01 ` kbuild test robot
@ 2016-02-26 7:17 ` Kalle Valo
2016-02-26 8:18 ` Fengguang Wu
0 siblings, 1 reply; 9+ messages in thread
From: Kalle Valo @ 2016-02-26 7:17 UTC (permalink / raw)
To: kbuild test robot
Cc: Emmanuel Grumbach, kbuild-all, johannes, linux-wireless, David Spinadel
kbuild test robot <lkp@intel.com> writes:
> Hi David,
>
> [auto build test ERROR on wireless-drivers-next/master]
> [also build test ERROR on v4.5-rc5 next-20160224]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url: https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/mac80211_hwsim-Set-global-RRM-capability/20160225-172733
> base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
> config: sparc64-allyesconfig (attached as .config)
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=sparc64
>
> All errors (new ones prefixed by >>):
>
> drivers/net/wireless/mac80211_hwsim.c: In function 'mac80211_hwsim_new_radio':
>>> drivers/net/wireless/mac80211_hwsim.c:2462:35: error: 'NL80211_EXT_FEATURE_RRM' undeclared (first use in this function)
> wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_RRM);
> ^
> drivers/net/wireless/mac80211_hwsim.c:2462:35: note: each undeclared identifier is reported only once for each function it appears in
I think this build failure is because mac80211_hwsim is an exception to
other wireless drivers and is applied via mac80211-next. Should we add
an entry for mac80211_hwsim to MAINTAINERS with the correct git tree? I
think kbuild test robot follows MAINTAINERS file nowdays (or at least I
understood that's the plan).
--
Kalle Valo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mac80211_hwsim: Set global RRM capability
2016-02-26 7:17 ` Kalle Valo
@ 2016-02-26 8:18 ` Fengguang Wu
2016-02-26 9:47 ` Johannes Berg
0 siblings, 1 reply; 9+ messages in thread
From: Fengguang Wu @ 2016-02-26 8:18 UTC (permalink / raw)
To: Kalle Valo
Cc: Emmanuel Grumbach, kbuild-all, johannes, linux-wireless,
David Spinadel, Ye, Xiaolong
On Fri, Feb 26, 2016 at 09:17:15AM +0200, Kalle Valo wrote:
> kbuild test robot <lkp@intel.com> writes:
>
> > Hi David,
> >
> > [auto build test ERROR on wireless-drivers-next/master]
> > [also build test ERROR on v4.5-rc5 next-20160224]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> >
> > url: https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/mac80211_hwsim-Set-global-RRM-capability/20160225-172733
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
> > config: sparc64-allyesconfig (attached as .config)
> > reproduce:
> > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # save the attached .config to linux build tree
> > make.cross ARCH=sparc64
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/net/wireless/mac80211_hwsim.c: In function 'mac80211_hwsim_new_radio':
> >>> drivers/net/wireless/mac80211_hwsim.c:2462:35: error: 'NL80211_EXT_FEATURE_RRM' undeclared (first use in this function)
> > wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_RRM);
> > ^
> > drivers/net/wireless/mac80211_hwsim.c:2462:35: note: each undeclared identifier is reported only once for each function it appears in
>
> I think this build failure is because mac80211_hwsim is an exception to
> other wireless drivers and is applied via mac80211-next. Should we add
> an entry for mac80211_hwsim to MAINTAINERS with the correct git tree? I
> think kbuild test robot follows MAINTAINERS file nowdays (or at least I
> understood that's the plan).
That's right. The robot parses MAINTAINERS when judging which tree
to apply LKML patches to.
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mac80211_hwsim: Set global RRM capability
2016-02-26 8:18 ` Fengguang Wu
@ 2016-02-26 9:47 ` Johannes Berg
0 siblings, 0 replies; 9+ messages in thread
From: Johannes Berg @ 2016-02-26 9:47 UTC (permalink / raw)
To: Fengguang Wu, Kalle Valo
Cc: Emmanuel Grumbach, kbuild-all, linux-wireless, David Spinadel,
Ye, Xiaolong
On Fri, 2016-02-26 at 16:18 +0800, Fengguang Wu wrote:
>
> > I think this build failure is because mac80211_hwsim is an
> > exception to
> > other wireless drivers and is applied via mac80211-next. Should we
> > add
> > an entry for mac80211_hwsim to MAINTAINERS with the correct git
> > tree? I
> > think kbuild test robot follows MAINTAINERS file nowdays (or at
> > least I
> > understood that's the plan).
>
> That's right. The robot parses MAINTAINERS when judging which tree
> to apply LKML patches to.
>
Great. I'll add a commit to make mac80211_hwsim just part of the
MAC80211 entry.
johannes
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mac80211_hwsim: Set global RRM capability
2016-02-25 9:24 [PATCH] mac80211_hwsim: Set global RRM capability Emmanuel Grumbach
2016-02-25 10:01 ` kbuild test robot
@ 2016-03-02 12:24 ` Johannes Berg
2016-03-02 12:36 ` Grumbach, Emmanuel
1 sibling, 1 reply; 9+ messages in thread
From: Johannes Berg @ 2016-03-02 12:24 UTC (permalink / raw)
To: Emmanuel Grumbach; +Cc: linux-wireless, David Spinadel
On Thu, 2016-02-25 at 11:24 +0200, Emmanuel Grumbach wrote:
> From: David Spinadel <david.spinadel@intel.com>
>
> Allow publishing RRM capabilities for features that are not
> HW dependent.
Actually, come to think of it, why don't we do this in mac80211 rather
than the drivers?
The only capability it requires is inserting the IEs, and that's
handled in mac80211.
johannes
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] mac80211_hwsim: Set global RRM capability
2016-03-02 12:24 ` Johannes Berg
@ 2016-03-02 12:36 ` Grumbach, Emmanuel
2016-03-03 15:45 ` Johannes Berg
0 siblings, 1 reply; 9+ messages in thread
From: Grumbach, Emmanuel @ 2016-03-02 12:36 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Spinadel, David
PiANCj4gT24gVGh1LCAyMDE2LTAyLTI1IGF0IDExOjI0ICswMjAwLCBFbW1hbnVlbCBHcnVtYmFj
aCB3cm90ZToNCj4gPiBGcm9tOiBEYXZpZCBTcGluYWRlbCA8ZGF2aWQuc3BpbmFkZWxAaW50ZWwu
Y29tPg0KPiA+DQo+ID4gQWxsb3cgcHVibGlzaGluZyBSUk0gY2FwYWJpbGl0aWVzIGZvciBmZWF0
dXJlcyB0aGF0IGFyZSBub3QgSFcNCj4gPiBkZXBlbmRlbnQuDQo+IA0KPiBBY3R1YWxseSwgY29t
ZSB0byB0aGluayBvZiBpdCwgd2h5IGRvbid0IHdlIGRvIHRoaXMgaW4gbWFjODAyMTEgcmF0aGVy
IHRoYW4NCj4gdGhlIGRyaXZlcnM/DQo+IA0KPiBUaGUgb25seSBjYXBhYmlsaXR5IGl0IHJlcXVp
cmVzIGlzIGluc2VydGluZyB0aGUgSUVzLCBhbmQgdGhhdCdzIGhhbmRsZWQgaW4NCj4gbWFjODAy
MTEuDQo+IA0KDQpJIGhhZCB0aGUgc2FtZSB0aGlua2luZywgYnV0IHNvbWVob3cgcGVvcGxlIGNv
bnZpbmNlZCBtZSB0aGF0IGEgZHJpdmVyIG1heSBwcmVmZXIgbm90IHRvIGFkdmVydGlzZSB0aGlz
IHdpdGhvdXQgaXRzIGV4cGxpY2l0IGNvbnNlbnQuIA0K
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mac80211_hwsim: Set global RRM capability
2016-03-02 12:36 ` Grumbach, Emmanuel
@ 2016-03-03 15:45 ` Johannes Berg
2016-03-04 5:39 ` Grumbach, Emmanuel
0 siblings, 1 reply; 9+ messages in thread
From: Johannes Berg @ 2016-03-03 15:45 UTC (permalink / raw)
To: Grumbach, Emmanuel; +Cc: linux-wireless, Spinadel, David
On Wed, 2016-03-02 at 12:36 +0000, Grumbach, Emmanuel wrote:
> >
> I had the same thinking, but somehow people convinced me that a
> driver may prefer not to advertise this without its explicit
> consent.
So ... What are the arguments? :)
johannes
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mac80211_hwsim: Set global RRM capability
2016-03-03 15:45 ` Johannes Berg
@ 2016-03-04 5:39 ` Grumbach, Emmanuel
0 siblings, 0 replies; 9+ messages in thread
From: Grumbach, Emmanuel @ 2016-03-04 5:39 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Spinadel, David
On 03/03/2016 05:45 PM, Johannes Berg wrote:
> On Wed, 2016-03-02 at 12:36 +0000, Grumbach, Emmanuel wrote:
>>>
>> I had the same thinking, but somehow people convinced me that a
>> driver may prefer not to advertise this without its explicit
>> consent.
>
> So ... What are the arguments? :)
>
Well.. a driver may not want to advertise it... Moot...
I guess we can / should move it to mac80211.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-03-04 5:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-25 9:24 [PATCH] mac80211_hwsim: Set global RRM capability Emmanuel Grumbach
2016-02-25 10:01 ` kbuild test robot
2016-02-26 7:17 ` Kalle Valo
2016-02-26 8:18 ` Fengguang Wu
2016-02-26 9:47 ` Johannes Berg
2016-03-02 12:24 ` Johannes Berg
2016-03-02 12:36 ` Grumbach, Emmanuel
2016-03-03 15:45 ` Johannes Berg
2016-03-04 5:39 ` Grumbach, Emmanuel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.