* [PATCH v3] iwlwifi: dvm: use alloc_ordered_workqueue()
@ 2016-03-19 5:15 Eva Rachel Retuya
2016-03-23 8:33 ` Grumbach, Emmanuel
0 siblings, 1 reply; 3+ messages in thread
From: Eva Rachel Retuya @ 2016-03-19 5:15 UTC (permalink / raw)
To: outreachy-kernel
Cc: johannes.berg, emmanuel.grumbach, linuxwifi, kvalo,
linux-wireless, netdev, linux-kernel, tj, Eva Rachel Retuya
Use alloc_ordered_workqueue() to allocate the workqueue instead of
create_singlethread_workqueue() since the latter is deprecated and is scheduled
for removal.
There are work items doing related operations that shouldn't be swapped when
queued in a certain order hence preserve the strict execution ordering of a
single threaded (ST) workqueue by switching to alloc_ordered_workqueue().
WQ_MEM_RECLAIM flag is not needed since the worker is not depended
during memory reclaim.
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
---
Changes in v3:
* revise commit message about WQ_MEM_RECLAIM
* add 'Acked-by:' from previous feedback
Changes in v2:
* switch from alloc_workqueue() to alloc_ordered_workqueue()
* remove unneeded flags: WQ_MEM_RECLAIM and WQ_HIGHPRI
* update commit message to reflect change
drivers/net/wireless/intel/iwlwifi/dvm/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/main.c b/drivers/net/wireless/intel/iwlwifi/dvm/main.c
index f62c2d7..14396d8 100644
--- a/drivers/net/wireless/intel/iwlwifi/dvm/main.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/main.c
@@ -1071,7 +1071,7 @@ static void iwl_bg_restart(struct work_struct *data)
static void iwl_setup_deferred_work(struct iwl_priv *priv)
{
- priv->workqueue = create_singlethread_workqueue(DRV_NAME);
+ priv->workqueue = alloc_ordered_workqueue(DRV_NAME, 0);
INIT_WORK(&priv->restart, iwl_bg_restart);
INIT_WORK(&priv->beacon_update, iwl_bg_beacon_update);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] iwlwifi: dvm: use alloc_ordered_workqueue()
2016-03-19 5:15 [PATCH v3] iwlwifi: dvm: use alloc_ordered_workqueue() Eva Rachel Retuya
@ 2016-03-23 8:33 ` Grumbach, Emmanuel
0 siblings, 0 replies; 3+ messages in thread
From: Grumbach, Emmanuel @ 2016-03-23 8:33 UTC (permalink / raw)
To: Eva Rachel Retuya, outreachy-kernel
Cc: Berg, Johannes, linuxwifi, kvalo, linux-wireless, netdev,
linux-kernel, tj
On 03/19/2016 07:15 AM, Eva Rachel Retuya wrote:
> Use alloc_ordered_workqueue() to allocate the workqueue instead of
> create_singlethread_workqueue() since the latter is deprecated and is scheduled
> for removal.
>
> There are work items doing related operations that shouldn't be swapped when
> queued in a certain order hence preserve the strict execution ordering of a
> single threaded (ST) workqueue by switching to alloc_ordered_workqueue().
>
> WQ_MEM_RECLAIM flag is not needed since the worker is not depended
> during memory reclaim.
>
> Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
> Acked-by: Tejun Heo <tj@kernel.org>
> ---
Applied - thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] iwlwifi: dvm: use alloc_ordered_workqueue()
@ 2016-03-23 8:33 ` Grumbach, Emmanuel
0 siblings, 0 replies; 3+ messages in thread
From: Grumbach, Emmanuel @ 2016-03-23 8:33 UTC (permalink / raw)
To: Eva Rachel Retuya, outreachy-kernel
Cc: Berg, Johannes, linuxwifi, kvalo, linux-wireless, netdev,
linux-kernel, tj
On 03/19/2016 07:15 AM, Eva Rachel Retuya wrote:
> Use alloc_ordered_workqueue() to allocate the workqueue instead of
> create_singlethread_workqueue() since the latter is deprecated and is scheduled
> for removal.
>
> There are work items doing related operations that shouldn't be swapped when
> queued in a certain order hence preserve the strict execution ordering of a
> single threaded (ST) workqueue by switching to alloc_ordered_workqueue().
>
> WQ_MEM_RECLAIM flag is not needed since the worker is not depended
> during memory reclaim.
>
> Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
> Acked-by: Tejun Heo <tj@kernel.org>
> ---
Applied - thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-23 8:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-19 5:15 [PATCH v3] iwlwifi: dvm: use alloc_ordered_workqueue() Eva Rachel Retuya
2016-03-23 8:33 ` Grumbach, Emmanuel
2016-03-23 8:33 ` Grumbach, Emmanuel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.