Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers

From: Song Liu <songliubraving@fb.com>
To: Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	"michael.chan@broadcom.com" <michael.chan@broadcom.com>,
	Ariel Elior <ariel.elior@cavium.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Tariq Toukan <tariqt@mellanox.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	"jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>,
	Jay Vosburgh <j.vosburgh@gmail.com>,
	Veaceslav Falico <vfalico@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>
Subject: Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers
Date: Tue, 25 Sep 2018 23:36:46 +0000	[thread overview]
Message-ID: <0C70D33A-E4E6-49D6-88CF-D4E3222C7060@fb.com> (raw)
In-Reply-To: <CANn89i+8mngtTLs8gzmEFjreW9ie64MPmZWaUDV+KRR7wgNfMA@mail.gmail.com>


> On Sep 24, 2018, at 8:30 AM, Eric Dumazet <edumazet@google.com> wrote:
> 
> On Sun, Sep 23, 2018 at 10:04 PM David Miller <davem@davemloft.net> wrote:
>> 
>> Series applied, thanks Eric.
> 
> Thanks David.
> 
> Song, would you please this additional patch ?
> 
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index 3219a2932463096566ce8ff336ecdf699422dd65..2ad45babe621b2c979ad5496b7df4342e4efbaa6
> 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -150,13 +150,6 @@ static void poll_one_napi(struct napi_struct *napi)
> {
>        int work = 0;
> 
> -       /* net_rx_action's ->poll() invocations and our's are
> -        * synchronized by this test which is only made while
> -        * holding the napi->poll_lock.
> -        */
> -       if (!test_bit(NAPI_STATE_SCHED, &napi->state))
> -               return;
> -
>        /* If we set this bit but see that it has already been set,
>         * that indicates that napi has been disabled and we need
>         * to abort this operation


Reviewed-and-tested-by: Song Liu <songliubraving@fb.com>