All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, michael.chan@broadcom.com,
	ariel.elior@cavium.com, eric.dumazet@gmail.com,
	tariqt@mellanox.com, saeedm@mellanox.com,
	jeffrey.t.kirsher@intel.com, jakub.kicinski@netronome.com,
	songliubraving@fb.com, j.vosburgh@gmail.com, vfalico@gmail.com,
	andy@greyhouse.net
Subject: Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers
Date: Sun, 23 Sep 2018 22:04:40 -0700 (PDT)	[thread overview]
Message-ID: <20180923.220440.434897583339366571.davem@davemloft.net> (raw)
In-Reply-To: <20180921222752.101307-1-edumazet@google.com>

From: Eric Dumazet <edumazet@google.com>
Date: Fri, 21 Sep 2018 15:27:37 -0700

> As diagnosed by Song Liu, ndo_poll_controller() can
> be very dangerous on loaded hosts, since the cpu
> calling ndo_poll_controller() might steal all NAPI
> contexts (for all RX/TX queues of the NIC).
> 
> This capture, showing one ksoftirqd eating all cycles
> can last for unlimited amount of time, since one
> cpu is generally not able to drain all the queues under load.
> 
> It seems that all networking drivers that do use NAPI
> for their TX completions, should not provide a ndo_poll_controller() :
> 
> Most NAPI drivers have netpoll support already handled
> in core networking stack, since netpoll_poll_dev()
> uses poll_napi(dev) to iterate through registered
> NAPI contexts for a device.
> 
> This patch series take care of the first round, we will
> handle other drivers in future rounds.

Series applied, thanks Eric.

  parent reply	other threads:[~2018-09-24 11:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 22:27 [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers Eric Dumazet
2018-09-21 22:27 ` [PATCH net 01/15] netpoll: make ndo_poll_controller() optional Eric Dumazet
2018-09-21 22:27 ` [PATCH net 02/15] bonding: use netpoll_poll_dev() helper Eric Dumazet
2018-09-22 10:23   ` Jay Vosburgh
2018-09-21 22:27 ` [PATCH net 03/15] ixgbe: remove ndo_poll_controller Eric Dumazet
2018-09-21 22:27 ` [PATCH net 04/15] ixgbevf: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 05/15] fm10k: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 06/15] ixgb: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 07/15] igb: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 08/15] ice: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 09/15] i40evf: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 10/15] mlx4: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 11/15] mlx5: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 12/15] bnx2x: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 13/15] bnxt: " Eric Dumazet
2018-09-21 22:27 ` [PATCH net 14/15] nfp: " Eric Dumazet
2018-09-21 23:41   ` Jakub Kicinski
2018-09-21 22:27 ` [PATCH net 15/15] tun: " Eric Dumazet
2018-09-23 19:29 ` [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers David Miller
2018-09-23 19:47   ` Eric Dumazet
2018-09-24  5:04 ` David Miller [this message]
2018-09-24 15:30   ` Eric Dumazet
2018-09-24 19:30     ` Song Liu
2018-09-24 19:41       ` Eric Dumazet
2018-09-24 20:00         ` Song Liu
2018-09-24 20:56           ` Eric Dumazet
2018-09-24 21:05             ` Eric Dumazet
2018-09-24 21:18               ` Song Liu
2018-09-25 14:02                 ` Michael Chan
2018-09-25 14:20                   ` Eric Dumazet
2018-09-25 14:43                     ` Michael Chan
2018-09-25 18:25                       ` Song Liu
2018-09-25 21:09                         ` Michael Chan
2018-09-25 23:36     ` Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180923.220440.434897583339366571.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andy@greyhouse.net \
    --cc=ariel.elior@cavium.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=j.vosburgh@gmail.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=songliubraving@fb.com \
    --cc=tariqt@mellanox.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.